From: <Claudiu.Beznea@microchip.com>
To: <Nicolas.Ferre@microchip.com>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>, <sre@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: arm: atmel: add binding for SAM9X60 shutdown controller
Date: Mon, 18 Feb 2019 14:47:22 +0000 [thread overview]
Message-ID: <44adcef4-a3df-f906-2d69-f357af1ebfaf@microchip.com> (raw)
In-Reply-To: <97af1d45-d74b-87d3-c934-baae80307e1d@microchip.com>
On 18.02.2019 13:01, Nicolas Ferre - M43238 wrote:
> On 14/02/2019 at 12:24, Claudiu Beznea - M18063 wrote:
>> From: Claudiu Beznea <claudiu.beznea@microchip.com>
>>
>> Add documentation for SAM9X60 shutdown controller.
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> ---
>> Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
>> index 14f319f694b7..9711052c5800 100644
>> --- a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
>> +++ b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
>> @@ -83,7 +83,7 @@ SHDWC SAMA5D2-Compatible Shutdown Controller
>> 1) shdwc node
>>
>> required properties:
>> -- compatible: should be "atmel,sama5d2-shdwc".
>> +- compatible: should be "atmel,sama5d2-shdwc" or "microchip,sam9x60-shdwc".
>> - reg: should contain registers location and length
>> - clocks: phandle to input clock.
>> - #address-cells: should be one. The cell is the wake-up input index.
>> @@ -95,6 +95,10 @@ optional properties:
>> microseconds. It's usually a board-related property.
>> - atmel,wakeup-rtc-timer: boolean to enable Real-Time Clock wake-up.
>>
>> +optional properties for microchip,sam9x60-shdwc:
>
> is it for sam9x60 only or is the optional property "debounce-delay-us"
> applicable to this SoC?
No, I meant only to RTC and RTT.
>
>> +- atmel,wakeup-rtc-timer: boolean to enable Real-Time Clock wake-up.
>> +- atmel,wakeup-rtt-timer: boolean to enable Real-time Timer Wake-up.
>
> Well, I would make clear that the only additional optional property is
> "atmel,wakeup-rtt-timer" while the 2 other optional properties still
> apply...
Ok, I will take care of this in next version.
Thank you,
Claudiu Beznea
>
>
>> The node contains child nodes for each wake-up input that the platform uses.
>>
>> 2) input nodes
>>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-02-18 14:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 11:24 [PATCH 0/3] add support for SAM9X60's shutdown controller Claudiu.Beznea
2019-02-14 11:24 ` [PATCH 1/3] power: reset: at91-poweroff: add RTT wakeup capability Claudiu.Beznea
2019-02-18 10:59 ` Nicolas.Ferre
2019-02-14 11:24 ` [PATCH 2/3] power: reset: at91-poweroff: add support for SAM9X60 Claudiu.Beznea
2019-02-18 10:59 ` Nicolas.Ferre
2019-02-14 11:24 ` [PATCH 3/3] dt-bindings: arm: atmel: add binding for SAM9X60 shutdown controller Claudiu.Beznea
2019-02-18 11:01 ` Nicolas.Ferre
2019-02-18 14:47 ` Claudiu.Beznea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44adcef4-a3df-f906-2d69-f357af1ebfaf@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).