From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10D8BC433EF for ; Fri, 22 Apr 2022 15:34:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XhNYyH0hoGev/z5HntUTnHA5pm/tdeq3CO5lkGOc45Q=; b=GtMaHkmk44nAZ06T0mvo/X091y NnMDdze79W/TLWjx4qNXVAr0uoDJq9b1AlWe/7+vdGJoAMI4HAQqfkuORnZIFg4lPGZ/lammUhczE ADTmZXWdSchQ5JEHpLkmS7PGRGZwNTi02lWQXIAFZoUSD6fbnMUiQdVcDLJSaZl/Trz1wCStsMygW Eij3E7g9jxmpS/6WXYy1ZsXeoLxvmJaPsfAibgmeQGNeHmvQlw2NW56xY3IrhIUsNwdX7nsMsr1H0 PV77LUJUv3FQlZIgEppWANTvq4/B3UIu/HHwhNuqnCObZIPsQn7otmBB0XULXXquk2JSYRlqMB217 xeBE8rrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhvH6-001923-OW; Fri, 22 Apr 2022 15:32:48 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhvH3-00190k-1B for linux-arm-kernel@lists.infradead.org; Fri, 22 Apr 2022 15:32:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650641560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+o3QI2qLDiKgmdGnQtt8Rgfs8/7qkV8vtGRNkkMknPA=; b=Xt0iXCLbVFLKSvqCepAXk7968Z01ZoKcxxFe53Hy6ikWQ/dq6HcPAnh24WAY3VVnWFOR2Y HbRckHpJ20P17A0G4L1s0HX1ETIwtA9NzrQ1Q0VEk8xgil6P6LF2N59ScxIBAKya/+2b8g +JaohGDQtSX99SepvX/g+AdpF8UqrCc= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-351-hP95BOukPDeXCn7Ej0rXyQ-1; Fri, 22 Apr 2022 11:32:39 -0400 X-MC-Unique: hP95BOukPDeXCn7Ej0rXyQ-1 Received: by mail-qv1-f70.google.com with SMTP id o1-20020ad44561000000b0044635418a3cso6922855qvu.0 for ; Fri, 22 Apr 2022 08:32:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=+o3QI2qLDiKgmdGnQtt8Rgfs8/7qkV8vtGRNkkMknPA=; b=zev06SlvW/B+XDJvLpAhyLyqlM5CRVuONcZH/sX2T9Mq7rHEiJKKjjSNILa72DO2xc ZJqOoh7KupGRhGRa7H2TX3Rf3cuHbHXsIY53+Q2elfZaZTFzAG8UNds0GllYdPxWA2N9 Qf82vVyjn5QStbgE+/ShaTJ8MTVwJUzq7Bfl272b60x7b+HhVKp/Nz+JQyPJyRKhf9Sf S31jRfDfAe/iOTHTLAMpuLTjLqU27APwhDgMDcJP7GRhF2ZHY7Po4mIJ7r2zRt63Lhjf 8zhTbBHRKXr7kYkJeY1TvpVrUQT0SdPcbbGRDzX6RkDYT646HonRl4VrUKMeUsP1r5th Cz2Q== X-Gm-Message-State: AOAM531ccX0wtQgQfZRTx7CO4LLeHEVYHCC/Ytz+F48ciBJqVgDYIwtP x9nNpdNIzxj9c729t1AYBlNsCPX2AtkRU3J9opd9V2bu6bepsIwcL8ovnkqjr6pCamt+E8W0p61 yMok80E4JtS2lp0xgWhdBypirWuxWK7AqwOU= X-Received: by 2002:a37:8d44:0:b0:69a:224a:dc27 with SMTP id p65-20020a378d44000000b0069a224adc27mr2989686qkd.563.1650641559150; Fri, 22 Apr 2022 08:32:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyw3Fqo3Nt15GFg/eHVhsKryB84/WiPdXDZP8hr3iO7fiPjDzNqt+7pAsJpGw+YTIzbAezHA== X-Received: by 2002:a37:8d44:0:b0:69a:224a:dc27 with SMTP id p65-20020a378d44000000b0069a224adc27mr2989647qkd.563.1650641558767; Fri, 22 Apr 2022 08:32:38 -0700 (PDT) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id v3-20020a05622a188300b002f201623acasm1364883qtc.50.2022.04.22.08.32.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 08:32:38 -0700 (PDT) Subject: Re: [PATCH] staging: vchiq_arm: change vchiq_platform_init from global to static To: Dan Carpenter Cc: nsaenz@kernel.org, bcm-kernel-feedback-list@broadcom.com, gregkh@linuxfoundation.org, stefan.wahren@i2se.com, gascoar@gmail.com, ojaswin98@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20220418164356.3532969-1-trix@redhat.com> <20220422144423.GI2462@kadam> From: Tom Rix Message-ID: <4594e273-caae-686c-4a4e-875a7bd70e0c@redhat.com> Date: Fri, 22 Apr 2022 08:32:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220422144423.GI2462@kadam> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220422_083245_220263_E0AC18EE X-CRM114-Status: GOOD ( 13.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/22/22 7:44 AM, Dan Carpenter wrote: > On Mon, Apr 18, 2022 at 12:43:56PM -0400, Tom Rix wrote: >> Smatch reports this issue >> vchiq_arm.c:466:5: warning: symbol 'vchiq_platform_init' >> was not declared. Should it be static? > This is a Sparse warning, not Smatch. Yes, this is correct. Though I am using make CC=cgcc And forgot which one I had installed last. Tom > > Use this command for Smatch > ~/smatch/smatch_scripts/kchecker drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > > And this command for Sparse > ~/smatch/smatch_scripts/kchecker --sparse drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > > regards, > dan carpenter > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel