From: Lucas Stach <l.stach@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>,
Laurentiu Palcu <laurentiu.palcu@nxp.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Guido Günther" <agx@sigxcpu.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/5] arm64: dts: imx8mq: add DCSS node
Date: Mon, 23 Sep 2019 19:00:58 +0200 [thread overview]
Message-ID: <45ad0ec1bfd5af4f46efd7d24c627822ac17fdbf.camel@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5AOVfBpz2Azh65iT_W3CBZUxf9KnqA=kdow7XWd4j--Qg@mail.gmail.com>
Am Montag, den 23.09.2019, 13:12 -0300 schrieb Fabio Estevam:
> Hi Laurentiu,
>
> On Mon, Sep 23, 2019 at 11:14 AM Laurentiu Palcu
> <laurentiu.palcu@nxp.com> wrote:
>
> > +
> > + dcss: dcss@0x32e00000 {
>
> Node names should be generic, so:
>
> dcss: display-controller@32e00000
>
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + compatible = "nxp,imx8mq-dcss";
> > + reg = <0x32e00000 0x2D000>,
> > <0x32e2f000 0x1000>;
>
> 0x2d000 for consistency.
>
> > + interrupts = <6>, <8>, <9>;
>
> The interrupts are passed in the <GIC_SPI xxx IRQ_TYPE_LEVEL_HIGH>
> format.
No, they are not. Those are imx-irqsteer IRQs, this controller has 0
irq cells, so the description in this patch is correct.
Regards,
Lucas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-23 17:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 14:13 [PATCH 0/5] Add support for iMX8MQ Display Controller Subsystem Laurentiu Palcu
2019-09-23 14:13 ` [PATCH 1/5] clk: imx8mq: Add VIDEO2_PLL clock Laurentiu Palcu
2019-09-23 14:13 ` [PATCH 4/5] dt-bindings: display: imx: add bindings for DCSS Laurentiu Palcu
2019-09-24 18:53 ` Rob Herring
2019-09-25 6:14 ` Laurentiu Palcu
2019-09-23 14:13 ` [PATCH 5/5] arm64: dts: imx8mq: add DCSS node Laurentiu Palcu
2019-09-23 16:12 ` Fabio Estevam
2019-09-23 17:00 ` Lucas Stach [this message]
2019-09-23 17:53 ` Fabio Estevam
2019-09-24 7:29 ` Laurentiu Palcu
2019-09-23 16:54 ` Stephen Boyd
2019-09-24 7:25 ` Laurentiu Palcu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ad0ec1bfd5af4f46efd7d24c627822ac17fdbf.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=laurentiu.palcu@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).