From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3057ECAAA1 for ; Tue, 6 Sep 2022 17:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e57iyfetPxUtAXMj9ZKFkRLrleWAOvE38Tmx0TcTpm8=; b=oSl3zSQFo1WKIq Humdm+F6UEEWHnXkYJIBtnG2vVq43fH8mY2UeSRL6x8qksRK+HIeCjt9COPXgMoVJ8ohv6nhY8swR 6RcIAPZLTsKhDGAHNFCw7FENCgyf7+1K7WtzSLEkXmf2w7roPIYM8/hyXj76ucOywo7PXm2cPd94s a/h93B0w1i7qUn6FIoGq0wTdGej6y3SrxSTclp5S9bCHmcXag9TCNPDn/QwtyVSkpxE4Y+16l0inl jxuj7NRbk+sLSQV0mMIVlebuGiqAEzWWjtYncn04pSt2tNYhUUWW6WH5qFBwmQaseho0leXI0xLQj EL09QtxZysvXEqcv8Zgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVcFL-00FrXT-B9; Tue, 06 Sep 2022 17:20:25 +0000 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVc1H-00FkBp-1e for linux-arm-kernel@lists.infradead.org; Tue, 06 Sep 2022 17:05:52 +0000 Received: by mail-qk1-x735.google.com with SMTP id g16so8620189qkl.11 for ; Tue, 06 Sep 2022 10:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=8sd1XUbOAaqPt2UCp3leBFo+ZTg1rtmlDOW2QOnPSY4=; b=UpW2c3Q5SPY5cpVDcDaldZhV6TrTm9uikL8Sd8wiKKD4SaxIUKoPBHv2xlT/0T+O7L wCu7F64Ybkzrdh56zxEGQXeG/IpapGwwmx77FSCnENV9Lu9pLSapSlNaENmkBhniPZKy w6Xwd68F9ZzNULGVSCZJyeyNRsKXvudlclI4hJgOSnjlExEJTYgxpdIh3HftxjAmzRB8 W4L/L2C++Ddmcov4GGvSGX1RATzP2qgW6Bi7UoCtEDbqJh1KLK/z9sOQ8XiwbNcp7tfP BP+CR9ko7ggnxxhmKNfrdlBr8CTO506lDq917+e8kVpuy/xtkM/vHIAloK4gcW+xfZ1a O8Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=8sd1XUbOAaqPt2UCp3leBFo+ZTg1rtmlDOW2QOnPSY4=; b=s7ViZveM/pbxDwUIeK05ijRzkpu18xBRT751GoKKLb1W3l6Uz9mgOUz6nMFRzrQZTQ C5Xo3rULFyl5LbKE/zvQxTGatIGCoAilPrSjwBZMyaczXuXo4CB27kOOtHD5VGEwTdqF UHa1DmhKMkl0geIXhB6xpujctLz3E3TVBiGZtAqVfJL0DkIGcmtVgxh5F4Ay0yIa8uQc KnDvBIB8c6CM149pGOTautPCXdAhGSCi5EuBjr8JB3nesjmQ6/ITaRMhVKsh2Vaav0WS ykq03L7eueGEnWJQFNTpRmuDj6g0aBxiwpTDOtpiN9vxqtC1XA/nKKFEfWtxsirSL0wF B1LA== X-Gm-Message-State: ACgBeo2GOkyirHE8ZBKj0Itjne03RJnCPix3jlfyB7HXd5EDlt7JxmJW BYNT5nVE3Yhh4i4Cj+mZe/o= X-Google-Smtp-Source: AA6agR5Fh76feQksNNuMqw8LuVW2nPF1DLvwm04cZ58xFgMHtAIHU/k+SKMVvtgd5SOemtCLL7r4Kg== X-Received: by 2002:a05:620a:4089:b0:6bb:97e6:d5b1 with SMTP id f9-20020a05620a408900b006bb97e6d5b1mr37512666qko.117.1662483948729; Tue, 06 Sep 2022 10:05:48 -0700 (PDT) Received: from [192.168.1.3] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id fp5-20020a05622a508500b0031e9ab4e4cesm9876026qtb.26.2022.09.06.10.05.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Sep 2022 10:05:48 -0700 (PDT) Message-ID: <45cdae58-632a-7cbb-c9d5-74c126ba6a3e@gmail.com> Date: Tue, 6 Sep 2022 10:05:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH net-next 2/2] ARM: dts: aspeed: elbert: Enable mac3 controller Content-Language: en-US To: Andrew Lunn , Tao Ren Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heyi Guo , Dylan Hung , Guangbin Huang , Liang He , Hao Chen , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Tao Ren , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20220905235634.20957-1-rentao.bupt@gmail.com> <20220905235634.20957-3-rentao.bupt@gmail.com> From: Florian Fainelli In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220906_100551_172872_11498EB9 X-CRM114-Status: GOOD ( 28.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/6/2022 4:55 AM, Andrew Lunn wrote: > On Mon, Sep 05, 2022 at 06:41:33PM -0700, Tao Ren wrote: >> Hi Andrew, >> >> On Tue, Sep 06, 2022 at 02:22:50AM +0200, Andrew Lunn wrote: >>> On Mon, Sep 05, 2022 at 04:56:34PM -0700, rentao.bupt@gmail.com wrote: >>>> From: Tao Ren >>>> >>>> Enable mac3 controller in Elbert dts: Elbert MAC3 is connected to the >>>> onboard switch directly (fixed link). >>> >>> What is the switch? Could you also add a DT node for it? >>> >>>> >>>> Signed-off-by: Tao Ren >>>> --- >>>> arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts | 11 +++++++++++ >>>> 1 file changed, 11 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts >>>> index 27b43fe099f1..52cb617783ac 100644 >>>> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts >>>> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts >>>> @@ -183,3 +183,14 @@ imux31: i2c@7 { >>>> &i2c11 { >>>> status = "okay"; >>>> }; >>>> + >>>> +&mac3 { >>>> + status = "okay"; >>>> + phy-mode = "rgmii"; >>> >>> 'rgmii' is suspicious, though not necessarily wrong. This value is >>> normally passed to the PHY, so the PHY inserts the RGMII delay. You >>> however don't have a PHY. So i assume the switch is inserting the >>> delay? Again, being able to see the DT properties for the switch would >>> be useful. >>> >>> Andrew >> >> Thank you for the quick review! >> >> The BMC mac3 is connected to BCM53134P's IMP_RGMII port, and there is no >> PHY between BMC MAC and BCM53134P. BCM53134P loads configurations from >> its EEPROM when the chip is powered. > > So i assume you have the switch RGMII port doing the delays. That is > fine. > >> Could you please point me an example showing how to describe the switch in >> dts? Anyhow I will need to improve the patch description and comments in >> v2. > > It looks like drivers/net/dsa/b53 does not support this particular > switch. You could consider extending the driver. See > > Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml > > for documentation of the binding. Correct the 53134 is not supported at the moment by the b53 driver, however it should not be too hard to support it, if you would be willing to add it, I would be glad to review patches. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel