From: Robin Murphy <robin.murphy@arm.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: mark.rutland@arm.com, wanpengli@tencent.com, kvm@vger.kernel.org,
narmstrong@baylibre.com, catalin.marinas@arm.com,
will.deacon@arm.com, rkrcmar@redhat.com, hpa@zytor.com,
khilman@baylibre.com, joro@8bytes.org, x86@kernel.org,
mingo@redhat.com, linux-arm-kernel@lists.infradead.org,
syzbot <syzbot+46f1dd7dbbe2bfb98b10@syzkaller.appspotmail.com>,
devicetree@vger.kernel.org, syzkaller-bugs@googlegroups.com,
robh+dt@kernel.org, bp@alien8.de,
linux-amlogic@lists.infradead.org, tglx@linutronix.de,
Dmitry Vyukov <dvyukov@google.com>,
jmattson@google.com, USB list <linux-usb@vger.kernel.org>,
linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com,
carlo@caione.org, Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: KASAN: slab-out-of-bounds Read in handle_vmptrld
Date: Fri, 13 Sep 2019 16:32:48 +0100 [thread overview]
Message-ID: <462660f4-1537-cece-b55f-0ceba0269eb8@arm.com> (raw)
In-Reply-To: <6a0ec3a2-2a52-f67a-6140-e0a60874538a@redhat.com>
On 13/09/2019 16:01, Paolo Bonzini wrote:
> On 13/09/19 15:02, Greg Kroah-Hartman wrote:
>> Look at linux-next, we "should" have fixed up hcd_buffer_alloc() now to
>> not need this type of thing. If we got it wrong, please let us know and
>> then yes, a fix like this would be most appreciated :)
>
> I still see
>
> /* some USB hosts just use PIO */
> if (!hcd_uses_dma(hcd)) {
> *dma = ~(dma_addr_t) 0;
> return kmalloc(size, mem_flags);
> }
>
> in linux-next's hcd_buffer_alloc and also in usb.git's usb-next branch.
> I also see the same
>
> if (remap_pfn_range(vma, vma->vm_start,
> virt_to_phys(usbm->mem) >> PAGE_SHIFT,
> size, vma->vm_page_prot) < 0) {
> ...
> }
>
> in usbdev_mmap. Of course it's possible that I'm looking at the wrong
> branch, or just being dense.
Oh, that bit of usbdev_mmap() is already known to be pretty much totally
bogus for various reasons - there have been a few threads about it, of
which I think [1] is both the most recent and the most informative.
There was another patch[2], but that might have stalled (and might need
reworking with additional hcd_uses_dma() checks anyway).
Robin.
[1]
https://lore.kernel.org/linux-arm-kernel/20190808084636.GB15080@priv-mua.localdomain/
[2]
https://lore.kernel.org/linux-usb/20190801220134.3295-1-gavinli@thegavinli.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-13 15:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 20:38 KASAN: slab-out-of-bounds Read in handle_vmptrld syzbot
2019-09-12 12:25 ` Will Deacon
2019-09-12 13:54 ` Vitaly Kuznetsov
2019-09-12 16:49 ` Paolo Bonzini
2019-09-13 4:46 ` Greg Kroah-Hartman
2019-09-13 7:34 ` Paolo Bonzini
2019-09-13 13:02 ` Greg Kroah-Hartman
2019-09-13 15:01 ` Paolo Bonzini
2019-09-13 15:32 ` Robin Murphy [this message]
2019-09-13 21:39 ` Paolo Bonzini
2019-09-13 15:36 ` Alan Stern
2019-09-13 16:14 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=462660f4-1537-cece-b55f-0ceba0269eb8@arm.com \
--to=robin.murphy@arm.com \
--cc=bp@alien8.de \
--cc=carlo@caione.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=khilman@baylibre.com \
--cc=kvm@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=narmstrong@baylibre.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=syzbot+46f1dd7dbbe2bfb98b10@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).