From: Matthias Brugger <matthias.bgg@gmail.com>
To: Crystal Guo <crystal.guo@mediatek.com>
Cc: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
srv_heupstream <srv_heupstream@mediatek.com>,
"Seiya Wang (王迺君)" <seiya.wang@mediatek.com>,
"Erin Lo (羅雅齡)" <erin.lo@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [v2,1/3] dt-binding: mediatek: mt8192: update mtk-wdt document
Date: Thu, 30 Jul 2020 11:02:23 +0200 [thread overview]
Message-ID: <47a351dd-7b67-6280-a80f-c5299a4f260a@gmail.com> (raw)
In-Reply-To: <1596072913.11360.12.camel@mhfsdcap03>
On 30/07/2020 03:35, Crystal Guo wrote:
> On Wed, 2020-07-29 at 18:18 +0800, Matthias Brugger wrote:
>>
>> On 29/07/2020 12:02, Crystal Guo wrote:
>>> update mtk-wdt document for MT8192 platform
>>
>>
>> should be two patches. one fixing the compatibles and second adding new board.
>>
>>>
>>> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
>>> ---
>>> Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>>> index 4dd36bd..e36ba60 100644
>>> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>>> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>>> @@ -4,14 +4,15 @@ Required properties:
>>>
>>> - compatible should contain:
>>> "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
>>> - "mediatek,mt2712-wdt", "mediatek,mt6589-wdt": for MT2712
>>> + "mediatek,mt2712-wdt": for MT2712
>>> "mediatek,mt6589-wdt": for MT6589
>>> "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
>>> "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
>>> "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
>>> "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
>>> - "mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183
>>> + "mediatek,mt8183-wdt": for MT8183
>>
>> We will need to update the DTSI in a seperate patch as well.
>
> Yes, this patch is based on
> https://patchwork.kernel.org/patch/11690401/ , which modify description
> for mt2712 and mt8183.
>
I don't understand your comment. This patch modifies the binding. The link you
provide is from an older version of the series (which is called v2 as well...)
So repeating myself: if you are updating the binding descritpion you will have
to update the dtsi as well as otherwise the binding and the dtsi are out of sync.
Regards,
Matthias
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-30 9:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 10:01 [v2,0/3] add watchdog support for mt8192 Crystal Guo
2020-07-29 10:02 ` [v2,1/3] dt-binding: mediatek: mt8192: update mtk-wdt document Crystal Guo
2020-07-29 10:18 ` Matthias Brugger
2020-07-30 1:35 ` Crystal Guo
2020-07-30 9:02 ` Matthias Brugger [this message]
2020-07-29 10:02 ` [v2,2/3] dt-binding: mt8192: add toprgu reset-controller head file Crystal Guo
2020-07-30 9:04 ` Matthias Brugger
2020-07-29 10:02 ` [v2,3/3] watchdog: mt8192: add wdt support Crystal Guo
2020-07-30 9:03 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47a351dd-7b67-6280-a80f-c5299a4f260a@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=crystal.guo@mediatek.com \
--cc=erin.lo@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=seiya.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).