linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pinctrl: bcm2835: Accept fewer than expected IRQs
@ 2021-05-21  9:01 Ivan T. Ivanov
  2021-05-21 15:08 ` Florian Fainelli
  2021-05-28  0:56 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Ivan T. Ivanov @ 2021-05-21  9:01 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Phil Elwell, Nicolas Saenz Julienne, Florian Fainelli, Ray Jui,
	Scott Branden, bcm-kernel-feedback-list, linux-gpio,
	linux-rpi-kernel, linux-arm-kernel, linux-kernel

From: Phil Elwell <phil@raspberrypi.com>

The downstream .dts files only request two GPIO IRQs. Truncate the
array of parent IRQs when irq_of_parse_and_map returns 0.

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
---
 drivers/pinctrl/bcm/pinctrl-bcm2835.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
index 1d21129f7751..2c87af1180c4 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
@@ -1274,9 +1274,13 @@ static int bcm2835_pinctrl_probe(struct platform_device *pdev)
 		char *name;
 
 		girq->parents[i] = irq_of_parse_and_map(np, i);
-		if (!is_7211)
+		if (!is_7211) {
+			if (!girq->parents[i]) {
+				girq->num_parents = i;
+				break;
+			}
 			continue;
-
+		}
 		/* Skip over the all banks interrupts */
 		pc->wake_irq[i] = irq_of_parse_and_map(np, i +
 						       BCM2835_NUM_IRQS + 1);
-- 
2.31.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: bcm2835: Accept fewer than expected IRQs
  2021-05-21  9:01 [PATCH] pinctrl: bcm2835: Accept fewer than expected IRQs Ivan T. Ivanov
@ 2021-05-21 15:08 ` Florian Fainelli
  2021-05-28  0:56 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2021-05-21 15:08 UTC (permalink / raw)
  To: Ivan T. Ivanov, Linus Walleij
  Cc: Phil Elwell, Nicolas Saenz Julienne, Ray Jui, Scott Branden,
	bcm-kernel-feedback-list, linux-gpio, linux-rpi-kernel,
	linux-arm-kernel, linux-kernel



On 5/21/2021 2:01 AM, Ivan T. Ivanov wrote:
> From: Phil Elwell <phil@raspberrypi.com>
> 
> The downstream .dts files only request two GPIO IRQs. Truncate the
> array of parent IRQs when irq_of_parse_and_map returns 0.
> 
> Signed-off-by: Phil Elwell <phil@raspberrypi.com>
> Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
> ---
>  drivers/pinctrl/bcm/pinctrl-bcm2835.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> index 1d21129f7751..2c87af1180c4 100644
> --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> @@ -1274,9 +1274,13 @@ static int bcm2835_pinctrl_probe(struct platform_device *pdev)
>  		char *name;
>  
>  		girq->parents[i] = irq_of_parse_and_map(np, i);
> -		if (!is_7211)
> +		if (!is_7211) {
> +			if (!girq->parents[i]) {
> +				girq->num_parents = i;
> +				break;
> +			}
>  			continue;

This assumes that interrupts are specified in an ordered way and skipped
in an ordered way as well, however given that we just hand
girq->parents[] to the GPIOLIB core, I don't really see a better solution:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: bcm2835: Accept fewer than expected IRQs
  2021-05-21  9:01 [PATCH] pinctrl: bcm2835: Accept fewer than expected IRQs Ivan T. Ivanov
  2021-05-21 15:08 ` Florian Fainelli
@ 2021-05-28  0:56 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2021-05-28  0:56 UTC (permalink / raw)
  To: Ivan T. Ivanov
  Cc: Phil Elwell, Nicolas Saenz Julienne, Florian Fainelli, Ray Jui,
	Scott Branden, bcm-kernel-feedback-list,
	open list:GPIO SUBSYSTEM, linux-rpi-kernel, Linux ARM,
	linux-kernel

On Fri, May 21, 2021 at 11:02 AM Ivan T. Ivanov <iivanov@suse.de> wrote:

> From: Phil Elwell <phil@raspberrypi.com>
>
> The downstream .dts files only request two GPIO IRQs. Truncate the
> array of parent IRQs when irq_of_parse_and_map returns 0.
>
> Signed-off-by: Phil Elwell <phil@raspberrypi.com>
> Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>

Patch applied.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-28  1:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21  9:01 [PATCH] pinctrl: bcm2835: Accept fewer than expected IRQs Ivan T. Ivanov
2021-05-21 15:08 ` Florian Fainelli
2021-05-28  0:56 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).