From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EE6CC47076 for ; Fri, 21 May 2021 15:32:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFFF5613D6 for ; Fri, 21 May 2021 15:32:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFFF5613D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Vt8eQWB7s+u98TRbXPxOoWlIY+GdSNvZ5XfaHc1j93g=; b=eijanFCRn8rOAUrWLOAz3EO29v 3Xa3ZFpATAfu7Bw+igEy0N0OhyWAyV1vkG4E8gm9+7JvckAuETlgp5loqtHs5yFSClSN7R5zBdVfN cqCIvYs2rX7toFk4SnYpgu83CP9Qi7TKCFd/sp/VWH68iJ0mThC3MJrXDQER8Zl1fuZkYYKE2igtw oJcx1eCGeZzoHHRJYXAKQsxXJbqVE6c2c91QY9TvlzLc53pVR2CEXk4AdFt9oIn76JvSwBjlP2Fje +Ht7M2HqCiRWZ6Q3LWqsVi+opgx4vQ/G9h5078B8FevWL22OKOE51obNN0Abh3B4nhKMbanl7haKM +b2kaxeA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk76z-0003E2-VC; Fri, 21 May 2021 15:30:54 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk72x-0001OK-2C; Fri, 21 May 2021 15:26:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=ZK5vDUvIgC6bF48AUmy/OX+Gvz7Keg1NucsMNX6Zy4o=; b=jGZk3jTYXXsLqkZoDbNvY38t5l fszcjx1kJvV7AwlBf1WqE8GDxIGlrYMraSbUKnGabJjO/gdwR5B6c5IGE2wKzJyOGEOoAUbNHF9Hi DDxU12ri4VLvIyhG53XFMDUGNeax+PiGlOCf1/Smcdv9ewj7UhLb/XFJjaIGs5xWgUf8dpuopyqXh Xt/cfkhFuXEFoFqHY0XUCCdTXn+dzpKlMzLH435sP4dyOcdTU12WsGdfL4VyvtBiDc2H3yjIkMT8x KbhDxBaj0Kw1Frm1eBKonYJt4jg5RE4LyiIi6Mk56rAdnLP8DXOqFfO72nedy8Rn87dY7GFtjizOw oi9JcRDA==; Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk6lm-00HDfc-VO; Fri, 21 May 2021 15:09:00 +0000 Received: by mail-pj1-x102c.google.com with SMTP id o17-20020a17090a9f91b029015cef5b3c50so7489817pjp.4; Fri, 21 May 2021 08:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZK5vDUvIgC6bF48AUmy/OX+Gvz7Keg1NucsMNX6Zy4o=; b=Dx9XkbBe/GmK+FqmIbzp0hVenlj7MFt21Nz/kQwk43TKsYOEi/sCG+pnhjucrJlB4q jRqOR4U2z9qArpH/YOhny/fD/vxBvpic0qZS2jCRM50tbrp1x2/nAUbFVLP7Qi19JCNn qE+wcRC2PDchPNCgBK/kplZ23l4XdAGwwvK+devv43Tmy2PXYdX97oc1fqD8wahEWSJM S61yrAdAUsXDHexNw5S8uDNv9I5m5zDfnwbBzysVhBp7QDRB17vjUxauVdwpiCZ5QOm6 GSKGV9qn/UZSHH/cHz1QKfJLUx8l+eGWf0kuCA7n9SDNwDoPDs6CXjEoCKn+r8OWexA7 I/nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZK5vDUvIgC6bF48AUmy/OX+Gvz7Keg1NucsMNX6Zy4o=; b=qUeuYdymDmQWnA9y3T/Q2hoN5R2y7uRtV/mdQrNW+livfOPOTTBYylgzGvz58uhAH+ yszpnAzbxka3UHA+rwsMW1MCs0P3YYRat0l3tgoSoXPcBP2xehcVpG0UiW8Z/NY20VUP TFOMw9D4TMrdEdffxK2kpiUT6WAU+aynqYWw4M4VwozZJqbfHVdqC8ksS9mu4TaNGvyi CqOaRF4VSZiNw6NwW0jYUVxBA6UTtY2QtJ/PzCp7nxh4G4f4OeFRHaKMrZBaxhPfbODA nDEMBnji03Tm+vfoSBrQDn1Xhg5dpxeX11Xpa/JAZinOvPUV5kA9ZYk4dKJhY6KfMq3/ xLlA== X-Gm-Message-State: AOAM533IKspiZfLTBNkgo7UPNYy+cpNnwxmQQrb+odnZ6dobANnOI6bM mWVt1Z40nsTCTSD/IKvo3Wo= X-Google-Smtp-Source: ABdhPJwCvPiXdUhwh8fr71RC4veZs/oxr51w/F6wONFAA1gyWJCkV4ltIEByJrdN3ZMeHTUqHNOGzQ== X-Received: by 2002:a17:90a:5309:: with SMTP id x9mr1458823pjh.111.1621609736739; Fri, 21 May 2021 08:08:56 -0700 (PDT) Received: from [10.230.29.202] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id h26sm4443160pfo.203.2021.05.21.08.08.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 May 2021 08:08:56 -0700 (PDT) Subject: Re: [PATCH] pinctrl: bcm2835: Accept fewer than expected IRQs To: "Ivan T. Ivanov" , Linus Walleij Cc: Phil Elwell , Nicolas Saenz Julienne , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210521090158.26932-1-iivanov@suse.de> From: Florian Fainelli Message-ID: <47bf2b41-d42f-fb25-ee9e-5527f3324b17@gmail.com> Date: Fri, 21 May 2021 08:08:47 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210521090158.26932-1-iivanov@suse.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_080859_048960_BCEE59EF X-CRM114-Status: GOOD ( 16.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/21/2021 2:01 AM, Ivan T. Ivanov wrote: > From: Phil Elwell > > The downstream .dts files only request two GPIO IRQs. Truncate the > array of parent IRQs when irq_of_parse_and_map returns 0. > > Signed-off-by: Phil Elwell > Signed-off-by: Ivan T. Ivanov > --- > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c > index 1d21129f7751..2c87af1180c4 100644 > --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c > +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c > @@ -1274,9 +1274,13 @@ static int bcm2835_pinctrl_probe(struct platform_device *pdev) > char *name; > > girq->parents[i] = irq_of_parse_and_map(np, i); > - if (!is_7211) > + if (!is_7211) { > + if (!girq->parents[i]) { > + girq->num_parents = i; > + break; > + } > continue; This assumes that interrupts are specified in an ordered way and skipped in an ordered way as well, however given that we just hand girq->parents[] to the GPIOLIB core, I don't really see a better solution: Reviewed-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel