From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05D98C433F5 for ; Wed, 18 May 2022 07:11:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0dgp1ICzbxOMJ/Da0YMB8TPXHfV0NhVY3Jd9zkgojuQ=; b=WGFfEUtjWvhACZ kFzbYd6SIkYOxsirWZICthtxq1zIGAwo3NWtgTvs37vxO05+nmbyCZo5IUYHMMPRBF+Qa42IFa5ON 5V8uEqcpWQk1CGbFqGJUqGuxgBWjkXcMk86pqSkHx7ier9B/ZqNfPntKhKXOyt3NPSePcCXBANb8D 9/F7d07gCBupjPMS0CALkAKjxwrwzWU1M7gaYjRuXJ0haOUpG4KxSRD1A8b8WSvNOCa034gNWDKqQ GE13ggtzYFJyXHJL5aExQ9g9yFnENZr01aLEx11WzAnlZGRZFYEu3BycCF8W87d/SKqZA2QxSkCJh GMuS053DzYjv1+jN0U0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrDpW-00HZsO-9f; Wed, 18 May 2022 07:10:46 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrDpS-00HZmN-68 for linux-arm-kernel@lists.infradead.org; Wed, 18 May 2022 07:10:43 +0000 Received: by mail-lj1-x22e.google.com with SMTP id e4so877169ljb.13 for ; Wed, 18 May 2022 00:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=3Y8OJ4m37PdLh73LbFGI/TuzXq1G8Ucqe1McDv0L7Qw=; b=JlRL3HITVZDBdmopILmaqrXqcydYXnTFfA0RbaXJbD2R6mI4kpyWHi65gSQko9aprB P9nxJK3bJt+ZO8+d4WtIfXXIvuo4d7cWHXS7ZUi/Rn0pSKMQm/z49nWk2Z1p2kpDWzeb eY6Rt7EVpZNbMZMl1UWOZY4k5Fdck5a9n+YZLC/hj39z9iA6iFsnWAgP0Mn0KI2uyBH0 HFeAnEI3f5QaXorFlyvUUbGWWeuJFgoNVWPl+YQr2P1ANzlOfIWnXpLpXO7JiT+lmDMW i7e0reIrs4BWnUZgPOdTN/uRTK+JG6M0PcTz0DGkyfyByHp17nbfFEFUdRrjlmFdwwHW Gmmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=3Y8OJ4m37PdLh73LbFGI/TuzXq1G8Ucqe1McDv0L7Qw=; b=rdVCBhKCXLHvA42jtE3m1ufIKK2rAq8qVKV5AV0SHGhBKpIKLqJ1o22qcBtifA6BMI yFltMmi+h3URLJqGTYQIS1MBLX3Vc1Q55fmtj3A2vkbPD2LodbJ5/l48kdXM5FJz5HDQ ble2DUUHAsd4w6JWO8cZA/LMPRmZQm8Mv0FpNqgiB+qooCMgqybLeHIXKxfydcJfulzG raW85taMP+rPf5W/9TvBNgwbu4c7m+gxcbDREZJxWiqYDM+u0b32XmumYrHM9on8yJEO KktG2D3JoGR98fGbiuigrQ27YfoiYctk77PnVX1MRiFx13gEoaA1koZETKxZPUmObAWx P0tA== X-Gm-Message-State: AOAM530pX/UpASPdycIlt6c5H1UROvM6E2ieqqiYGKUCOY41ri6u7lC3 y1f1x+3gLMuC+5N0yu0sgin5eQ== X-Google-Smtp-Source: ABdhPJzj42Ts+E0zWJxIYpaHRi4UHdNOsl6Cqe1/VeyvP4ZMGYSeJJ1PRrAkfVQTPLuuDvkN9oZcOQ== X-Received: by 2002:a05:651c:a11:b0:250:5da4:e7b1 with SMTP id k17-20020a05651c0a1100b002505da4e7b1mr16453099ljq.268.1652857838821; Wed, 18 May 2022 00:10:38 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id a12-20020a056512020c00b0047255d2115asm118471lfo.137.2022.05.18.00.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 00:10:38 -0700 (PDT) Message-ID: <47f84a32-18e1-5612-b95c-607e2f19f9d8@linaro.org> Date: Wed, 18 May 2022 09:10:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/4] dmaengine: sprd-dma: Remove unneeded ERROR check before clk_disable_unprepare Content-Language: en-US To: Jiabing Wan , Vinod Koul , Orson Zhai , Baolin Wang , Chunyan Zhang , Linus Walleij , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220516084139.8864-1-wanjiabing@vivo.com> <20220516084139.8864-3-wanjiabing@vivo.com> <214de163-d576-d9be-76f2-3b70eefd6e68@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220518_001042_269315_2B4F5349 X-CRM114-Status: GOOD ( 10.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/05/2022 04:44, Jiabing Wan wrote: > Hi, > > On 2022/5/17 23:13, Krzysztof Kozlowski wrote: >> On 16/05/2022 10:41, Wan Jiabing wrote: >>> clk_disable_unprepare() already checks ERROR by using IS_ERR_OR_NULL. >> Hmm, maybe I am looking at different sources, but which commit >> introduced IS_ERR_OR_NULL() check? Where is it in the sources? >> > In commit 4dff95dc9477a, IS_ERR_OR_NULL check is added in clk_disable() > and clk_unprepare(). > And clk_disable_unprepare() just calls clk_disable() and clk_unprepare(): Thank you, indeed, I was mislead a bit by clk_prepare() which is not symmetric. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel