From: houlong wei <houlong.wei@mediatek.com>
To: Eizan Miyamoto <eizan@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
"dafna.hirschfeld@collabora.com" <dafna.hirschfeld@collabora.com>,
"Andrew-CT Chen (陳智迪)" <Andrew-CT.Chen@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Minghsiu Tsai (蔡明修)" <Minghsiu.Tsai@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
houlong.wei@mediatek.com
Subject: Re: [PATCH] media: mtk-mdp: make mtk_mdp_comp_init static
Date: Mon, 16 Aug 2021 12:26:07 +0800 [thread overview]
Message-ID: <484e199d23a09d79f121ea37eb9e7d95eabfd886.camel@mediatek.com> (raw)
In-Reply-To: <20210811171512.1.I4a34d99ace27ad2fe55e22c90244d3bba2c29bab@changeid>
On Wed, 2021-08-11 at 15:15 +0800, Eizan Miyamoto wrote:
> This function isn't and doesn't need to be used outside of
> mtk_mdp_comp.c
>
> This patch depends on and is a follow-up to
>
https://patchwork.kernel.org/project/linux-mediatek/list/?series=524929
>
> Signed-off-by: Eizan Miyamoto <eizan@chromium.org>
> ---
Reviewed-by: Houlong Wei <houlong.wei@mediatek.com>
> drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 2 +-
> drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> index 9527649de98e..2cf8f1864f8c 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> @@ -234,7 +234,7 @@ static const struct component_ops
> mtk_mdp_component_ops = {
> .unbind = mtk_mdp_comp_unbind,
> };
>
> -int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev)
> +static int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct
> device *dev)
> {
> struct device_node *larb_node;
> struct platform_device *larb_pdev;
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> index e3d6aef52869..aa6442cc8c1d 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> @@ -21,8 +21,6 @@ struct mtk_mdp_comp {
> struct device *larb_dev;
> };
>
> -int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device
> *dev);
> -
> int mtk_mdp_comp_power_on(struct mtk_mdp_comp *comp);
> int mtk_mdp_comp_power_off(struct mtk_mdp_comp *comp);
>
> --
> 2.32.0.605.g8dce9f2422-goog
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-16 4:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 7:15 [PATCH] media: mtk-mdp: make mtk_mdp_comp_init static Eizan Miyamoto
2021-08-16 4:26 ` houlong wei [this message]
2022-04-27 8:05 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484e199d23a09d79f121ea37eb9e7d95eabfd886.camel@mediatek.com \
--to=houlong.wei@mediatek.com \
--cc=Andrew-CT.Chen@mediatek.com \
--cc=Minghsiu.Tsai@mediatek.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=eizan@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).