From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2536C10F0E for ; Tue, 9 Apr 2019 05:20:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9277D20883 for ; Tue, 9 Apr 2019 05:20:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F6R+iY8f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9277D20883 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vNwEaBkeTTMU93Yv+2gVWR/cJ9ug4Z87gtIMtYP4K6E=; b=F6R+iY8fY26/9qIMqbWIePB0H CyffujKcrjcrbRd8nKeaDgwuWH5n6QSR2nh9oTTRmpTMG+NXpR1TNiVsy0NiC/arZ+AU3nwYU6DWY 4z56M+gbKNNpDIkzd2yEdGnVUPhiIL9smYetXiJsXy8pQAypuREgeFD06iCfGge6/x0j+E3rnkhlC BQmJ4ZgNJIMWCucPoLSgDCpmXjBb5zB5ARpdPd8nxEyvGwhKW4oXsO3EoubLV/hVmuJnecHa2ww1a eeSpoTPjZOogdGujnO/CVM9LztHBaENT0tAhe009dJ41nWulsqtqdzrk/s3c7NJcJG/WT7Pv+4dFQ c9HrefApA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDjBO-0004rn-5q; Tue, 09 Apr 2019 05:20:30 +0000 Received: from mail-pl1-f195.google.com ([209.85.214.195]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDjBK-0004qW-7Q for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2019 05:20:28 +0000 Received: by mail-pl1-f195.google.com with SMTP id a96so3990022pla.6 for ; Mon, 08 Apr 2019 22:20:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1YUfMPM7RT1o5URCsP5/A8wjExy9E/3T5zL1WxdDFpI=; b=DhS8bqMRl2fBS5/DZnGoRi0GuGKi9AZMhO2bYZRnH0wwDYsM52Bhy4KiXjp4QuBNWp XElh+n8KMw0Tgg2aJv6n85FVMLrmETlOwe1wrVqjAYpRecIZ4VIFjNYzWy7xjXCwymBD gTAVz7ZFCJNIPdGiY53ljFiHlNh+0I/Yijac5QSHJsZ6XUfcnl84p01//ug5K301ieE9 /JIw37FNDwBRS88HZPDOkasFN25T1Z1C3rKx5MO+yn8oNKemrCHvl1J5Ju8KcH/JUcPs scR+StKyrHxLykck6pEgveYYQCGqbwjsXa1vJDduR3t6yZ9fnWssiTQXAzxnrZwrJNYQ VmeA== X-Gm-Message-State: APjAAAWbgTXoZhmyNpfx83/xnLGeuQtw8hDxbLECo/yeqSa7HHxV5sKv gkr/1wZYCpJKUE3uLUSkphB95rpx8dH+SQ== X-Google-Smtp-Source: APXvYqzhrg94zZKMqARZTPlnpBF65FbExNLYEDlH8PaVsNnFFrNS5x/xA9UeSdVBUIhP+KvcD/Laog== X-Received: by 2002:a17:902:b715:: with SMTP id d21mr35489861pls.103.1554787224724; Mon, 08 Apr 2019 22:20:24 -0700 (PDT) Received: from localhost.localdomain ([209.132.188.81]) by smtp.gmail.com with ESMTPSA id y19sm43192451pfn.164.2019.04.08.22.20.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Apr 2019 22:20:23 -0700 (PDT) Subject: Re: [PATCH 0/3] support reserving crashkernel above 4G on arm64 kdump To: Chen Zhou , catalin.marinas@arm.com, will.deacon@arm.com, akpm@linux-foundation.org, rppt@linux.ibm.com, ard.biesheuvel@linaro.org, takahiro.akashi@linaro.org References: <20190403030546.23718-1-chenzhou10@huawei.com> From: Bhupesh Sharma Message-ID: <49012d55-2020-e2ac-1102-59a5f3911a29@redhat.com> Date: Tue, 9 Apr 2019 13:20:16 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20190403030546.23718-1-chenzhou10@huawei.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190408_222026_264671_D0A61588 X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mm@kvack.org, wangkefeng.wang@huawei.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Chen, Thanks for the patchset. Before I review the patches in detail, I have a couple of generic queries. Please see them in-line: On 04/03/2019 11:05 AM, Chen Zhou wrote: > When crashkernel is reserved above 4G in memory, kernel should reserve > some amount of low memory for swiotlb and some DMA buffers. So there may > be two crash kernel regions, one is below 4G, the other is above 4G. > > Crash dump kernel reads more than one crash kernel regions via a dtb > property under node /chosen, > linux,usable-memory-range = . > > Besides, we need to modify kexec-tools: > arm64: support more than one crash kernel regions > > Chen Zhou (3): > arm64: kdump: support reserving crashkernel above 4G > arm64: kdump: support more than one crash kernel regions > kdump: update Documentation about crashkernel on arm64 > > Documentation/admin-guide/kernel-parameters.txt | 4 +- > arch/arm64/kernel/setup.c | 3 + > arch/arm64/mm/init.c | 108 ++++++++++++++++++++---- > include/linux/memblock.h | 1 + > mm/memblock.c | 40 +++++++++ > 5 files changed, 139 insertions(+), 17 deletions(-) I am wondering about the use-case for the same. I remember normally fedora-based arm64 systems can do well with a maximum crashkernel size of <=512MB reserved below the 4G boundary. So, do you mean that for your use-case (may be a huawei board based setup?), you need: - more than 512MB of crashkernel size, or - you want to split the crashkernel reservation across the 4GB boundary irrespective of the crashkernel size value. Thanks, Bhupesh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel