From: Randy Dunlap <rdunlap@infradead.org>
To: patrice.chotard@foss.st.com, Mark Brown <broonie@kernel.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: linux-spi@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, christophe.kerello@foss.st.com
Subject: Re: [PATCH] spi: stm32-qspi: Fix W=1 build warning
Date: Fri, 4 Jun 2021 08:27:01 -0700 [thread overview]
Message-ID: <49902b8a-c16a-423a-d528-3d35cac402bc@infradead.org> (raw)
In-Reply-To: <20210604075009.25914-1-patrice.chotard@foss.st.com>
On 6/4/21 12:50 AM, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
>
> Fix the following compilation warning using W=1 build:
> arm-linux-gnueabi-ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
This is a build error, not a warning. The complete message is:
ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':
spi-stm32-qspi.c:(.text+0x661): undefined reference to `spi_mem_supports_op'
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
thanks.
> ---
> drivers/spi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index f4481fe48bf0..e71a4c514f7b 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -806,6 +806,7 @@ config SPI_STM32_QSPI
> tristate "STMicroelectronics STM32 QUAD SPI controller"
> depends on ARCH_STM32 || COMPILE_TEST
> depends on OF
> + depends on SPI_MEM
> help
> This enables support for the Quad SPI controller in master mode.
> This driver does not support generic SPI. The implementation only
>
--
~Randy
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-04 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 7:50 [PATCH] spi: stm32-qspi: Fix W=1 build warning patrice.chotard
2021-06-04 15:27 ` Randy Dunlap [this message]
2021-06-04 16:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49902b8a-c16a-423a-d528-3d35cac402bc@infradead.org \
--to=rdunlap@infradead.org \
--cc=alexandre.torgue@foss.st.com \
--cc=broonie@kernel.org \
--cc=christophe.kerello@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=patrice.chotard@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).