From: Philippe CORNU <philippe.cornu@st.com>
To: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"a.hajda@samsung.com" <a.hajda@samsung.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"jernej.skrabec@siol.net" <jernej.skrabec@siol.net>,
"heiko@sntech.de" <heiko@sntech.de>,
"jonas@kwiboo.se" <jonas@kwiboo.se>,
"narmstrong@baylibre.com" <narmstrong@baylibre.com>,
"hjc@rock-chips.com" <hjc@rock-chips.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yannick FERTRE <yannick.fertre@st.com>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Laurent.pinchart@ideasonboard.com"
<Laurent.pinchart@ideasonboard.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"christoph.muellner@theobroma-systems.com"
<christoph.muellner@theobroma-systems.com>
Subject: Re: [PATCH v2 1/5] drm/bridge/synopsys: dsi: move phy_ops callbacks around panel enablement
Date: Tue, 12 Nov 2019 15:37:17 +0000 [thread overview]
Message-ID: <49f6386b-30c8-a181-5785-2ecdf5f95d2a@st.com> (raw)
In-Reply-To: <20191108000253.8560-2-heiko.stuebner@theobroma-systems.com>
Hi Heiko,
On 11/8/19 1:02 AM, Heiko Stuebner wrote:
> If implementation-specific phy_ops need to be defined they probably
> should be enabled before trying to talk to the panel and disabled only
> after the panel was disabled.
>
> Right now they are enabled last and disabled first, so might make it
> impossible to talk to some panels - example for this being the px30
> with an external Innosilicon dphy that needs the phy to be enabled
> to transfer commands to the panel.
>
> So move the calls appropriately.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index 675442bfc1bd..49f5600a1dea 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -797,9 +797,6 @@ static void dw_mipi_dsi_bridge_post_disable(struct drm_bridge *bridge)
> struct dw_mipi_dsi *dsi = bridge_to_dsi(bridge);
> const struct dw_mipi_dsi_phy_ops *phy_ops = dsi->plat_data->phy_ops;
>
> - if (phy_ops->power_off)
> - phy_ops->power_off(dsi->plat_data->priv_data);
> -
> /*
> * Switch to command mode before panel-bridge post_disable &
> * panel unprepare.
> @@ -816,6 +813,9 @@ static void dw_mipi_dsi_bridge_post_disable(struct drm_bridge *bridge)
> */
> dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge);
>
> + if (phy_ops->power_off)
> + phy_ops->power_off(dsi->plat_data->priv_data);
> +
> if (dsi->slave) {
> dw_mipi_dsi_disable(dsi->slave);
> clk_disable_unprepare(dsi->slave->pclk);
> @@ -882,6 +882,9 @@ static void dw_mipi_dsi_mode_set(struct dw_mipi_dsi *dsi,
>
> /* Switch to cmd mode for panel-bridge pre_enable & panel prepare */
> dw_mipi_dsi_set_mode(dsi, 0);
> +
> + if (phy_ops->power_on)
> + phy_ops->power_on(dsi->plat_data->priv_data);
> }
>
> static void dw_mipi_dsi_bridge_mode_set(struct drm_bridge *bridge,
> @@ -898,15 +901,11 @@ static void dw_mipi_dsi_bridge_mode_set(struct drm_bridge *bridge,
> static void dw_mipi_dsi_bridge_enable(struct drm_bridge *bridge)
> {
> struct dw_mipi_dsi *dsi = bridge_to_dsi(bridge);
> - const struct dw_mipi_dsi_phy_ops *phy_ops = dsi->plat_data->phy_ops;
>
> /* Switch to video mode for panel-bridge enable & panel enable */
> dw_mipi_dsi_set_mode(dsi, MIPI_DSI_MODE_VIDEO);
> if (dsi->slave)
> dw_mipi_dsi_set_mode(dsi->slave, MIPI_DSI_MODE_VIDEO);
> -
> - if (phy_ops->power_on)
> - phy_ops->power_on(dsi->plat_data->priv_data);
> }
>
> static enum drm_mode_status
>
Tested-by: Yannick Fertre <yannick.fertre@st.com>
Reviewed-by: Philippe Cornu <philippe.cornu@st.com>
Many thanks,
Philippe :-)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-12 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 0:02 [PATCH v2 0/5] dw-mipi-dsi support for Rockchip px30 Heiko Stuebner
2019-11-08 0:02 ` [PATCH v2 1/5] drm/bridge/synopsys: dsi: move phy_ops callbacks around panel enablement Heiko Stuebner
2019-11-12 14:26 ` Neil Armstrong
2019-11-12 15:37 ` Philippe CORNU [this message]
2019-11-08 0:02 ` [PATCH v2 2/5] dt-bindings: display: rockchip-dsi: document external phys Heiko Stuebner
2019-11-14 1:52 ` Rob Herring
2019-11-08 0:02 ` [PATCH v2 3/5] drm/rockchip: add ability to handle external dphys in mipi-dsi Heiko Stuebner
2019-11-08 0:02 ` [PATCH v2 4/5] dt-bindings: display: rockchip-dsi: add px30 compatible Heiko Stuebner
2019-11-14 1:52 ` Rob Herring
2019-11-08 0:02 ` [PATCH v2 5/5] drm/rockchip: dsi: add px30 support Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49f6386b-30c8-a181-5785-2ecdf5f95d2a@st.com \
--to=philippe.cornu@st.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).