From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: i.MX & IRQF_ONESHOT
Date: Thu, 13 Jan 2011 12:12:16 +0100 [thread overview]
Message-ID: <4D2EDE10.3040809@atmel.com> (raw)
In-Reply-To: <20110113091355.GP24920@pengutronix.de>
Le 13/01/2011 10:13, Uwe Kleine-K?nig :
> <jason77.wang@gmail.com>
> Bcc:
> Subject: Re: i.MX & IRQF_ONESHOT
> Reply-To:
> In-Reply-To: <4D2EB6EF.7030608@eukrea.com>
>
> Hello,
>
> [adding tglx who AFAIK invented threaded irqs and the people involved
> in 2991a1ca6e9b to Cc]
>
> On Thu, Jan 13, 2011 at 09:25:19AM +0100, Eric B?nard wrote:
>> while testing 2.6.37 on our i.MX27 based board - code in
>> arch/arm/mach-imx/eukrea_mbimx27-baseboard.c - I noticed the
>> touchscreen controller (ADS7846) doesn't work anymore.
>>
>> A few IRQ are generated when probing for the chipset and starting
>> calibration (usually first point works), then nothing more (even if
>> the IRQ signals is generated as seen on the scope, the irq count
>> doesn't increase anymore and stays <= 4 and no data is reported to
>> the input layer).
>>
>> drivers/input/touchscreen/ads7846.c was switched to threaded IRQ in
>> commit 2991a1ca6e9b13b639a82c0eec0cbc191bf1f42f where was added :
>> irq_flags |= IRQF_ONESHOT;
> AFAIK this is how threaded irq usually work. The irq should get
> reenabled by irq_thread -> irq_finalize_oneshot then.
>
>> Commenting out this line in the ads7846 driver makes it work again.
>> Am I missing something obvious or is there a reason for IRQF_ONESHOT
>> creating trouble with gpio irq or SPI on i.MX ?
> I don't know. Is the irq masked? pending?
Just to let you know that I have the same issue on my at91sam9g10ek:
atmel_spi + ads7846 (using ADS7843e actually).
... solved by same workaround.
Best regards,
--
Nicolas Ferre
next prev parent reply other threads:[~2011-01-13 11:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 9:13 No subject Uwe Kleine-König
2011-01-13 11:12 ` Nicolas Ferre [this message]
2011-01-13 18:15 ` i.MX & IRQF_ONESHOT Thomas Gleixner
2011-01-13 21:12 ` Eric Bénard
2011-01-13 21:24 ` Uwe Kleine-König
2011-01-14 7:35 ` Eric Bénard
2011-01-14 10:57 ` Thomas Gleixner
2011-01-14 13:08 ` Uwe Kleine-König
2011-02-02 21:20 ` Uwe Kleine-König
2011-02-02 21:26 ` Eric Bénard
2011-01-14 11:25 ` Nicolas Ferre
2011-01-14 11:47 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2011-01-13 8:25 Eric Bénard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2EDE10.3040809@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).