From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83810C433F5 for ; Fri, 18 Mar 2022 13:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HnRBErVt/IAxFLKXezinHhiWgc2rWOGmPOMEqGlS3uY=; b=WLiqW/5b7dAScx +Y6MzbeFP5NCMGP18cpzRPA40EC/DK9VnF043V5qrvyl5KIbtNz7rCtR0dCUMxf5NhNgqDiloDhzP cSLcefD/CuL3tFU+Nh74SbEJDHtToLn254kh7GO5qkISsk4cz4pBnnTUrflTQXxvlVz+KIy6RWk7+ LUfGP6ERRLCufimNvRn+cfMM9cz7RuVqvYVCoExmYljTK1XMZMts/5UKLfzHyyL4G+15YIEka+4aj 8HUZX745ZP7fAjL0sTGbsOkaH5RyLonYHlGOOB3CSf3yF0Q039A0wgZIwF86aKmtNVGS7GA8DkS7Q /RPoQwQjTdvUanNlKEEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVCHK-001g9G-Qj; Fri, 18 Mar 2022 13:04:26 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVCHG-001g86-JN; Fri, 18 Mar 2022 13:04:24 +0000 X-UUID: 952df146d52443609ab6f8a40de147b7-20220318 X-UUID: 952df146d52443609ab6f8a40de147b7-20220318 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 506439869; Fri, 18 Mar 2022 06:04:17 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 18 Mar 2022 06:04:15 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Fri, 18 Mar 2022 21:04:13 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 18 Mar 2022 21:04:13 +0800 Message-ID: <4a59806ad9adbfcaa4c34cdf79d615e24e666442.camel@mediatek.com> Subject: Re: [PATCH v15 19/22] drm/mediatek: modify mediatek-drm for mt8195 multi mmsys support From: Nancy.Lin To: CK Hu , Rob Herring , "Matthias Brugger" , Chun-Kuang Hu , Philipp Zabel , , AngeloGioacchino Del Regno , CC: , , Yongqiang Niu , , David Airlie , "jason-jh . lin" , , , Nick Desaulniers , , , Nathan Chancellor , , Date: Fri, 18 Mar 2022 21:04:13 +0800 In-Reply-To: References: <20220311015506.11232-1-nancy.lin@mediatek.com> <20220311015506.11232-20-nancy.lin@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220318_060422_675519_56A0161B X-CRM114-Status: GOOD ( 21.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi CK, Thanks for the review. On Mon, 2022-03-14 at 18:08 +0800, CK Hu wrote: > Hi, Nancy: > > On Fri, 2022-03-11 at 09:55 +0800, Nancy.Lin wrote: > > MT8195 have two mmsys. Modify drm for MT8195 multi-mmsys support. > > The two mmsys (vdosys0 and vdosys1) will bring up two drm drivers, > > only one drm driver register as the drm device. > > Each drm driver binds its own component. The last bind drm driver > > allocates and registers the drm device to drm core. > > Each crtc path is created with the corresponding drm driver data. > > > > Signed-off-by: Nancy.Lin > > Reviewed-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 24 +- > > drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 3 +- > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 300 ++++++++++++++++++-- > > ---- > > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 10 +- > > 4 files changed, 246 insertions(+), 91 deletions(-) > > > > > > [snip] > > > > > static const struct mtk_mmsys_driver_data > > mt8195_vdosys0_driver_data > > = { > > .main_path = mt8195_mtk_ddp_main, > > .main_len = ARRAY_SIZE(mt8195_mtk_ddp_main), > > + .mmsys_dev_num = 2, > > After apply this patch, vdosys0 only would not work. So I think this > should be set to 1 in this patch, and set to 2 in the patch that > support mt8195 vdosys1. With this modification, > > Reviewed-by: CK Hu > OK, I will fix it. Regards, Nancy > > }; > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel