From: Chanwoo Choi <cw00.choi@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Chen-Yu Tsai <wens@csie.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Support Opensource <support.opensource@diasemi.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Milo Kim <milo.kim@ti.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sangbeom Kim <sbkim73@samsung.com>,
Tony Lindgren <tony@atomide.com>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 17/42] mfd: max77693: use PLATFORM_DEVID_NONE
Date: Mon, 28 Sep 2020 12:16:22 +0900 [thread overview]
Message-ID: <4a9d8a2f-defb-9f88-9211-fcf2cf985f28@samsung.com> (raw)
In-Reply-To: <20200921205016.20461-17-krzk@kernel.org>
On 9/22/20 5:49 AM, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/mfd/max77693.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 596ed85cab3b..02fbdf0a66c3 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -274,7 +274,7 @@ static int max77693_i2c_probe(struct i2c_client *i2c,
>
> pm_runtime_set_active(max77693->dev);
>
> - ret = mfd_add_devices(max77693->dev, -1, max77693_devs,
> + ret = mfd_add_devices(max77693->dev, PLATFORM_DEVID_NONE, max77693_devs,
> ARRAY_SIZE(max77693_devs), NULL, 0, NULL);
> if (ret < 0)
> goto err_mfd;
>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-28 3:04 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 20:49 [PATCH 01/42] mfd: arizona: use PLATFORM_DEVID_NONE Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 02/42] mfd: as3711: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 03/42] mfd: as3722: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 04/42] mfd: atmel-hlcdc: " Krzysztof Kozlowski
2020-09-22 6:49 ` Alexandre Belloni
2020-09-21 20:49 ` [PATCH 05/42] mfd: axp20x: " Krzysztof Kozlowski
2020-09-22 8:21 ` Andy Shevchenko
2020-09-21 20:49 ` [PATCH 06/42] mfd: bcm2835: " Krzysztof Kozlowski
2020-09-21 21:12 ` Florian Fainelli
2020-09-22 10:34 ` Nicolas Saenz Julienne
2020-09-21 20:49 ` [PATCH 07/42] mfd: bcm590xx: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 08/42] mfd: da9055: " Krzysztof Kozlowski
2020-09-22 9:04 ` Adam Thomson
2020-09-21 20:49 ` [PATCH 09/42] mfd: da9150: " Krzysztof Kozlowski
2020-09-22 9:05 ` Adam Thomson
2020-09-21 20:49 ` [PATCH 10/42] mfd: intel_msic: " Krzysztof Kozlowski
2020-09-22 8:22 ` Andy Shevchenko
2020-09-21 20:49 ` [PATCH 11/42] mfd: intel_soc_pmic: " Krzysztof Kozlowski
2020-09-22 8:22 ` Andy Shevchenko
2020-09-21 20:49 ` [PATCH 12/42] mfd: kempld: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 13/42] mfd: lp8788: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 14/42] mfd: lp3943: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 15/42] mfd: max14577: " Krzysztof Kozlowski
2020-09-28 3:15 ` Chanwoo Choi
2020-09-21 20:49 ` [PATCH 16/42] mfd: max77686: " Krzysztof Kozlowski
2020-09-28 3:16 ` Chanwoo Choi
2020-09-21 20:49 ` [PATCH 17/42] mfd: max77693: " Krzysztof Kozlowski
2020-09-28 3:16 ` Chanwoo Choi [this message]
2020-09-21 20:49 ` [PATCH 18/42] mfd: max77843: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 19/42] mfd: max8907: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 20/42] mfd: max8997: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 21/42] mfd: max8998: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 22/42] mfd: mc13xxx: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 23/42] mfd: rc5t583: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 24/42] mfd: rdc321x: " Krzysztof Kozlowski
2020-09-21 21:12 ` Florian Fainelli
2020-09-21 20:49 ` [PATCH 25/42] mfd: retu: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 26/42] mfd: rt5033: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 27/42] mfd: sec: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 28/42] mfd: sky81452: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 29/42] mfd: sta2x11: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 30/42] mfd: tc3589x: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 31/42] mfd: timberdale: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 32/42] mfd: tps6507x: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 33/42] mfd: tps65090: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 34/42] mfd: tps65217: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 35/42] mfd: tps6586x: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 36/42] mfd: tps65910: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 37/42] mfd: tps80031: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 38/42] mfd: twl6040: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 39/42] mfd: vx855: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 40/42] mfd: wl1273: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 41/42] mfd: wm8400: " Krzysztof Kozlowski
2020-09-22 8:48 ` Charles Keepax
2020-09-21 20:50 ` [PATCH 42/42] mfd: wm8994: " Krzysztof Kozlowski
2020-09-22 8:48 ` Charles Keepax
2020-09-22 8:48 ` [PATCH 01/42] mfd: arizona: " Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a9d8a2f-defb-9f88-9211-fcf2cf985f28@samsung.com \
--to=cw00.choi@samsung.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=b.zolnierkie@samsung.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=milo.kim@ti.com \
--cc=nicolas.ferre@microchip.com \
--cc=nsaenzjulienne@suse.de \
--cc=patches@opensource.cirrus.com \
--cc=rjui@broadcom.com \
--cc=sbkim73@samsung.com \
--cc=sbranden@broadcom.com \
--cc=support.opensource@diasemi.com \
--cc=tony@atomide.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).