From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16B86C433EF for ; Mon, 6 Jun 2022 10:53:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+aKGF+6c97Pr+uSSWqqC6dLdHPNImzASfpynVf7Q4wA=; b=obJJLCUBWZngIW d/m5rvtmIiIeHURY3JjQ6yipzTi/G7aSTvJ+qXkUz3s5xvAaIo5vNlRAUgJlDyInaPUT5ltYgvXgH Pa1nSGJeUasVkAbDMk9wN1luUUsZVWzqmDrXaTdnSU3ipKrql9RXBNh4uh1dnpJEGcLqp7Pp0HmZ/ sTvru+0jGjMRhdIbKxlB60LALY87FaFmzloO9TemdvgXthvBml3lpK57Mrp/wbdxKfJrIdXQtXTYg KRWMWroCxPyWhXkPlhtU9sY0TPrGSi8TSbdrOl8k4MyLhI/sBYKpgkqVXhZHTfEO8G3HEwcHhpzkG kw56fE9Rb2UEWkenO5sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyALC-000roK-VI; Mon, 06 Jun 2022 10:52:11 +0000 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyAL8-000rex-5H for linux-arm-kernel@lists.infradead.org; Mon, 06 Jun 2022 10:52:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Ze8TQqRMhX7HpjoC+K0KtEGfpNVrb+81cSLdx8Azg70=; b=lak033I39OfXfSbKzJeUe8BC8roSULxmHxkZK/86LIzVrv8YZl24KwE2 CqOqDz+qJaFRZchikutxcTI/ls7zHelAHy5VbFp3UMxMzR8FFnTB6ReUz O99ZKjfI+buUt3CFhkEPzwXXpdDGv3NWuu8YYX7TbkyI8HrijqiKvP97B Y=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=keisuke.nishimura@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.91,280,1647298800"; d="scan'208";a="39634374" Received: from eth-east-parth2-46-193-69-7.wb.wifirst.net (HELO [10.188.210.33]) ([46.193.69.7]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2022 12:51:55 +0200 Message-ID: <4ad227dc-3972-82f5-6c71-271becc37e66@inria.fr> Date: Mon, 6 Jun 2022 19:51:55 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: mainline build failure due to f1e4c916f97f ("drm/edid: add EDID block count and size helpers") Content-Language: en-US To: Arnd Bergmann Cc: Julia Lawall , Jani Nikula , Sudip Mukherjee , Russell King , Viresh Kumar , Shiraz Hashim , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel , Linux Kernel Mailing List , Linux ARM , SoC Team , Linus Torvalds References: <91E67F46-A3C7-4159-9E0C-C6C6306F3669@inria.fr> From: Keisuke Nishimura In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_035206_640552_B6711E10 X-CRM114-Status: GOOD ( 10.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/06/02 16:38, Arnd Bergmann wrote: > I think that SmPL script worked great, almost every instance is > something that ought to be changed, as long as it stops reporting > those structures that are also __aligned(). I would extend it to > also report structures with 'bool', 'enum', or any pointer, but that > could give more false-positives. Maybe have a separate script > for those instances embedding atomics or spinlocks (very broken) > vs the other members (causes more harm than good or might > need alignment). I extended my script to detect __packed struct or union without __aligned. It is split in two scripts. The first one is to search for problematic cases where __packed structs/unions have atomic types or spinlock types. In this version, types whose names contain "atomic" or "spinlock" are targeted. == Scripts == @r@ type T; identifier i; type b =~ ".*(atomic|spinlock).*"; position p; attribute name __packed, __aligned; attribute at; @@ T@p { ... b i; ... } at; @script:python@ p <