From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9E9CC433EF for ; Wed, 27 Oct 2021 16:11:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99BEA60F6F for ; Wed, 27 Oct 2021 16:11:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 99BEA60F6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=PIevjV3kLjtJQG2bDYs3ynfAnULY6jn2qPq9jY3ejsM=; b=jQyZrxGw/2rEIy2Q3aPct4JySt HSIU7I55UJQZJY4gzq7d7moryJ9js6DuXXykOuFF6gzrz7ZTpaDrFHDp6p98dukuNmyk1QD7fHbR0 Lg0zajUSgC5oJ8M/DudKxYtQVd7+CFke23JmTO6c3eZQfMZdmp7N3yvziSEJfexx+zgE1yFscSM+G SlBNBHY0fm2uPULok7/lNH8yEcQzLSLR4/vBEIoNG5YuSk2tPAfCfTJorwy5iT9310hHZrp7txpv9 SiKbPgaAc4M1o06Tt079X40u2taDnOykGzhHLa7jAp7SfthzLH9X2HQVYYibCEqrlY+NEooYHVYzL L6EUimgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mflVZ-005PvD-OH; Wed, 27 Oct 2021 16:10:34 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mflVV-005Ptf-SR for linux-arm-kernel@lists.infradead.org; Wed, 27 Oct 2021 16:10:31 +0000 Received: from [192.168.254.32] (unknown [47.187.212.181]) by linux.microsoft.com (Postfix) with ESMTPSA id 5CF082034CB2; Wed, 27 Oct 2021 09:10:28 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5CF082034CB2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1635351029; bh=KPTUkYPm4k91ndaje5wemec3HSxDBjpY1g+uVBjvLeI=; h=Subject:To:References:From:Date:In-Reply-To:From; b=nA0OuFiMFY5cSanBoeqPKPrT1BxaPwRNv3n+3EZV9TuVewEtkeCjK0IWNiim6UcvI y5O+1hekcSe6kYxc5A0Yq0c2tDUUujMh+Jg1TtjRB34Erzxap/hYGFRftpXiTH+U6+ 1mFeMQ+VOPTQfbNWaUpccTrjEr48BjzgUCi3cwh8= Subject: Re: [PATCH v10 06/11] arm64: Make profile_pc() use arch_stack_walk() To: "nobuta.keiya@fujitsu.com" , "mark.rutland@arm.com" , "broonie@kernel.org" , "jpoimboe@redhat.com" , "ardb@kernel.org" , "sjitindarsingh@gmail.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "jmorris@namei.org" , "linux-arm-kernel@lists.infradead.org" , "live-patching@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20211015025847.17694-1-madvenka@linux.microsoft.com> <20211015025847.17694-7-madvenka@linux.microsoft.com> From: "Madhavan T. Venkataraman" Message-ID: <4af5d1e4-75cc-f5a6-8552-5a2f0f631724@linux.microsoft.com> Date: Wed, 27 Oct 2021 11:10:27 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211027_091030_004999_37DF08B0 X-CRM114-Status: GOOD ( 16.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/24/21 9:18 PM, nobuta.keiya@fujitsu.com wrote: > Hi, > >> -----Original Message----- >> From: madvenka@linux.microsoft.com >> Sent: Friday, October 15, 2021 11:59 AM >> To: mark.rutland@arm.com; broonie@kernel.org; jpoimboe@redhat.com; ardb@kernel.org; Nobuta, Keiya/信田 圭哉 >> ; sjitindarsingh@gmail.com; catalin.marinas@arm.com; will@kernel.org; jmorris@namei.org; >> linux-arm-kernel@lists.infradead.org; live-patching@vger.kernel.org; linux-kernel@vger.kernel.org; >> madvenka@linux.microsoft.com >> Subject: [PATCH v10 06/11] arm64: Make profile_pc() use arch_stack_walk() >> >> From: "Madhavan T. Venkataraman" >> >> Currently, profile_pc() in ARM64 code walks the stack using >> start_backtrace() and unwind_frame(). Make it use arch_stack_walk() instead. This makes maintenance easier. >> >> Signed-off-by: Madhavan T. Venkataraman >> --- >> arch/arm64/kernel/time.c | 22 +++++++++++++--------- >> 1 file changed, 13 insertions(+), 9 deletions(-) >> >> diff --git a/arch/arm64/kernel/time.c b/arch/arm64/kernel/time.c index eebbc8d7123e..671b3038a772 100644 >> --- a/arch/arm64/kernel/time.c >> +++ b/arch/arm64/kernel/time.c >> @@ -32,22 +32,26 @@ >> #include >> #include >> >> +static bool profile_pc_cb(void *arg, unsigned long pc) { >> + unsigned long *prof_pc = arg; >> + >> + if (in_lock_functions(pc)) >> + return true; >> + *prof_pc = pc; >> + return false; >> +} >> + >> unsigned long profile_pc(struct pt_regs *regs) { >> - struct stackframe frame; >> + unsigned long prof_pc = 0; >> >> if (!in_lock_functions(regs->pc)) >> return regs->pc; >> >> - start_backtrace(&frame, regs->regs[29], regs->pc); >> - >> - do { >> - int ret = unwind_frame(NULL, &frame); >> - if (ret < 0) >> - return 0; >> - } while (in_lock_functions(frame.pc)); >> + arch_stack_walk(profile_pc_cb, &prof_pc, current, regs); >> >> - return frame.pc; >> + return prof_pc; >> } >> EXPORT_SYMBOL(profile_pc); >> >> -- >> 2.25.1 > > > I've got build error with CONFIG_ACPI=n: > ==== > arch/arm64/kernel/time.c: In function 'profile_pc': > arch/arm64/kernel/time.c:52:2: error: implicit declaration of function 'arch_stack_walk' [-Werror=implicit-function-declaration] > 52 | arch_stack_walk(profile_pc_cb, &prof_pc, current, regs); > | ^~~~~~~~~~~~~~~ > ==== > > I think it should include instead of . > OK. I will fix this. Thanks for catching this. Madhavan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel