From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF1E6C433DB for ; Thu, 4 Mar 2021 20:58:06 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51D7D64F23 for ; Thu, 4 Mar 2021 20:58:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51D7D64F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u1TaPuDujtaZ09Q6UVew3qqCDV50L9NJndLW9uHXb1A=; b=lts7OGe6oYVpMiVEkc6NLKha0 cDmV++tBlJ68JgrqALaw2whBcPfZRg2V18/85iSSWPhv3JettxNY4S2ESQGFjZGx9hu8kH9rJPzQL VU0dVApgWDyJj21t6sXYynZKXf88q5PaBabPpDZ1+70oGmft2jHgPavq8t7ubGkodvbfjxmMg9qFN Y1NxIv0dc9obo4TQEF3UoYiNMPT7CAFVTOTSsyF4gkkA5WDUY5md8wlJ99bp7p/EU494Z3MEmKiJd +ZdmneESy6godZbwHfy5doW0PagEJ43gpX0tU00JIELM9/ep4jPNEkF9b/hKd2v3Ch6a5TqBW/MYw UEDqrqcOA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHv1F-00A4Wh-5V; Thu, 04 Mar 2021 20:56:25 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHv1A-00A4US-0s for linux-arm-kernel@lists.infradead.org; Thu, 04 Mar 2021 20:56:22 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 124Ku0we019009; Thu, 4 Mar 2021 14:56:00 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1614891360; bh=KQoevqNLdq6Vcqe7xjay1VRDOuM0RiWmMq8okhEq7ic=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=fgb3unhSTrmmj9vU82YIe5gyRn1s4ROHL06A7F8wBnz4lc81erEHp5foT8ybuC3HM zTAn1Irg0HB8YInd71KpwuDfCgiRycEoLyPOzjjKqF62oy5Y9czpZWJ37x9ornf3e/ I4NENCXn1IFyO8RyKHSJxcsUndxnixe9400ykAAg= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 124Ku0Dm009620 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 4 Mar 2021 14:56:00 -0600 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 4 Mar 2021 14:55:59 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 4 Mar 2021 14:55:59 -0600 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 124KtvkN009698; Thu, 4 Mar 2021 14:55:58 -0600 Subject: Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Remove extra of_node_put() To: Tony Lindgren , Daniel Lezcano , Thomas Gleixner CC: Keerthy , , , References: <20210304072135.52712-1-tony@atomide.com> <20210304072135.52712-3-tony@atomide.com> From: Grygorii Strashko Message-ID: <4c23ce3e-3304-b10d-5054-f421822b5dc2@ti.com> Date: Thu, 4 Mar 2021 22:55:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210304072135.52712-3-tony@atomide.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/03/2021 09:21, Tony Lindgren wrote: > We have of_translate_address() already do of_node_put() as needed. > I probably looked at __of_translate_address() earlier by accident > that of_translate_address() uses. I do not see of_node_put() in of_translate_address() and __of_translate_address() is doing of_node_get(dev); ? > > Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support") > Signed-off-by: Tony Lindgren > --- > drivers/clocksource/timer-ti-dm-systimer.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/clocksource/timer-ti-dm-systimer.c b/drivers/clocksource/timer-ti-dm-systimer.c > --- a/drivers/clocksource/timer-ti-dm-systimer.c > +++ b/drivers/clocksource/timer-ti-dm-systimer.c > @@ -265,7 +265,6 @@ static void __init dmtimer_systimer_assign_alwon(void) > pa == 0x48318000) > continue; > > - of_node_put(np); > break; > } > } > @@ -300,7 +299,6 @@ static u32 __init dmtimer_systimer_find_first_available(void) > continue; > } > > - of_node_put(np); > break; > } > } > -- Best regards, grygorii _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel