From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D09DCC433F5 for ; Sat, 23 Oct 2021 12:51:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A10D60FC3 for ; Sat, 23 Oct 2021 12:51:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8A10D60FC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=JWruVAwwoVKlpwRM/rm5rdmHKt5mfLrG8pqEtqJ0k9E=; b=sNkfh/1Pg5LKDqModkaDuU4rBr +CezQ0/B7vE/fRACsFXVLW4xBV4NGMRb1oGsxcm8GX2SidchXszUTJhWIUQBejdVAfyo+6al3paFI VS0YClfGpE6X8HE+80AgrFIgzYhMqKfZMMA9Subfkl7J5Wd+TgAydfqahwBoa2uFwElw0RvdJeiJF SWWXcL9RqBkNQINkmwDk7Dr/EXnRXZ18C7thXE/5Y2OFn3Jp6jOqJAZTV+WDsaCxEArUCIHkSLmjo vK3e1Th4Kiq3xe6qHHI2ZMS8rIfJ9D+VfQOG66ijrx+KvUat2pQt2xppPrN00+mPweHN8nwRyE9yK gqhztVZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1meGSf-00Cm1h-VT; Sat, 23 Oct 2021 12:49:22 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1meGSc-00Cm14-5E for linux-arm-kernel@lists.infradead.org; Sat, 23 Oct 2021 12:49:19 +0000 Received: from [192.168.254.32] (unknown [47.187.212.181]) by linux.microsoft.com (Postfix) with ESMTPSA id A0CEE2064891; Sat, 23 Oct 2021 05:49:12 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A0CEE2064891 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1634993353; bh=xFXuz9rWSnTF5MnVRUBihVdw9KXSz2G2i8s+MV54MGs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=MyYom8geXOg8HqEQJRagVh7NRn+nyAPArhhuQaY/De8NjNB2y0l9ZS65Kb0yJi+3J m/dLNcPFaiFEDL+OLyYWU57lThwPyNP/x4RcF23n8y3Q0rJKhFsCKDjWWejTi0ntM1 kyHpKu3qL9Ucxc5YoduFkndzjlQiFdqggCnvYlyY= Subject: Re: [PATCH v10 02/11] arm64: Make perf_callchain_kernel() use arch_stack_walk() To: Mark Rutland Cc: broonie@kernel.org, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211015025847.17694-1-madvenka@linux.microsoft.com> <20211015025847.17694-3-madvenka@linux.microsoft.com> <20211022181154.GM86184@C02TD0UTHF1T.local> From: "Madhavan T. Venkataraman" Message-ID: <4de6800b-54fc-a74d-598f-80fc40924976@linux.microsoft.com> Date: Sat, 23 Oct 2021 07:49:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211022181154.GM86184@C02TD0UTHF1T.local> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211023_054918_311338_0F2016A6 X-CRM114-Status: GOOD ( 13.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/22/21 1:11 PM, Mark Rutland wrote: > On Thu, Oct 14, 2021 at 09:58:38PM -0500, madvenka@linux.microsoft.com wrote: >> From: "Madhavan T. Venkataraman" >> >> Currently, perf_callchain_kernel() in ARM64 code walks the stack using >> start_backtrace() and walk_stackframe(). Make it use arch_stack_walk() >> instead. This makes maintenance easier. >> >> Signed-off-by: Madhavan T. Venkataraman > > This looks good to me; bailing out when perf_callchain_store() can't > accept any more entries absolutely makes sense. > > I gave this a spin with: > > | # perf record -g -c1 ls > | # perf report > > ... and the recorded callchains look sane. > > Reviewed-by: Mark Rutland > Tested-by: Mark Rutland > Thanks a lot! > As mentioned on patch 1, I'd like to get this rebased atop Peter's > untangling of ARCH_STACKWALK from STACKTRACE. > Will do. Thanks. Madhavan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel