linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Gavin Shan <gshan@redhat.com>
To: Will Deacon <will@kernel.org>, kvmarm@lists.cs.columbia.edu
Cc: kernel-team@android.com, Suzuki Poulose <suzuki.poulose@arm.com>,
	Marc Zyngier <maz@kernel.org>,
	Quentin Perret <qperret@google.com>,
	James Morse <james.morse@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 00/21] KVM: arm64: Rewrite page-table code and fault handling
Date: Thu, 10 Sep 2020 14:06:04 +1000	[thread overview]
Message-ID: <4e41d4c5-1d36-fb28-880d-94235def35ed@redhat.com> (raw)
In-Reply-To: <20200907152344.12978-1-will@kernel.org>

Hi Will and Marc,

On 9/8/20 1:23 AM, Will Deacon wrote:
> Hi all,
> 
> Here's version four of the KVM page-table rework I previously posted here:
> 
>    v1: https://lore.kernel.org/r/20200730153406.25136-1-will@kernel.org
>    v2: https://lore.kernel.org/r/20200818132818.16065-1-will@kernel.org
>    v3: https://lore.kernel.org/r/20200825093953.26493-1-will@kernel.org
> 
> Changes since v3 include:
> 
>    * Removed some more unused code from the old implementation
>    * Renumbered KVM_PGTABLE_PROT_* to match file permissions in hex dumps
>    * Simplified kvm_granule_shift() and removed kvm_start_level()
>    * Only clear valid bit when invalidating a PTE, leaving phys addr intact
>    * Fail gracefully when attempting to allocate without a memory cache
>    * Rewrote stage2_apply_range() as a function instead of a macro
>    * Fixed fault address rounding with hugetlbfs
>    * Fixed permission fault handling when dirty logging is enabled
>    * Added comments
>    * Added reviewer tags
> 
> Many thanks to Alex and Gavin for their comments.
> 
> Will
> 

[...]

Eventually, I'm lucky finding a machine from our pool where 16KB page
size is supported. I tried this series (v4) on this machine, everything
looks good as we expected:

    Host:   5.9.0-rc3 + patchset (v4)
            CONFIG_ARM64_VA_BITS=47
            CONFIG_ARM64_PAGE_SHIFT=14
            Hugepagesize: 32768 kB      (from /proc/meminfo)
    Config: -HugeTLBfs/-THP
            +HugeTLBfs/-THP
            -HugeTLBfs/THP
    Guest:  CONFIG_ARM64_PAGE_SHIFT=12/14/16

Let me know in case there are more tests needed from my side.

Thanks,
Gavin


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-09-10  4:07 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 15:23 [PATCH v4 00/21] KVM: arm64: Rewrite page-table code and fault handling Will Deacon
2020-09-07 15:23 ` [PATCH v4 01/21] KVM: arm64: Remove kvm_mmu_free_memory_caches() Will Deacon
2020-09-07 15:23 ` [PATCH v4 02/21] KVM: arm64: Add stand-alone page-table walker infrastructure Will Deacon
2020-09-08  0:03   ` Gavin Shan
2020-09-10 10:57     ` Will Deacon
2020-09-09 15:29   ` Alexandru Elisei
2020-09-10 12:37     ` Will Deacon
2020-09-10 14:21       ` Andrew Scull
2020-09-11 10:15         ` Will Deacon
2020-09-11 11:22           ` Andrew Scull
2020-09-07 15:23 ` [PATCH v4 03/21] KVM: arm64: Add support for creating kernel-agnostic stage-1 page tables Will Deacon
2020-09-08  1:09   ` Gavin Shan
2020-09-07 15:23 ` [PATCH v4 04/21] KVM: arm64: Use generic allocator for hyp stage-1 page-tables Will Deacon
2020-09-08  1:03   ` Gavin Shan
2020-09-07 15:23 ` [PATCH v4 05/21] KVM: arm64: Add support for creating kernel-agnostic stage-2 page tables Will Deacon
2020-09-07 15:23 ` [PATCH v4 06/21] KVM: arm64: Add support for stage-2 map()/unmap() in generic page-table Will Deacon
2020-09-10 11:20   ` Alexandru Elisei
2020-09-10 12:34     ` Will Deacon
2020-09-10 13:55       ` Alexandru Elisei
2020-09-07 15:23 ` [PATCH v4 07/21] KVM: arm64: Convert kvm_phys_addr_ioremap() to generic page-table API Will Deacon
2020-09-07 15:23 ` [PATCH v4 08/21] KVM: arm64: Convert kvm_set_spte_hva() " Will Deacon
2020-09-07 15:23 ` [PATCH v4 09/21] KVM: arm64: Convert unmap_stage2_range() " Will Deacon
2020-09-07 15:23 ` [PATCH v4 10/21] KVM: arm64: Add support for stage-2 page-aging in generic page-table Will Deacon
2020-09-08 15:30   ` Alexandru Elisei
2020-09-10 12:42     ` Will Deacon
2020-09-07 15:23 ` [PATCH v4 11/21] KVM: arm64: Convert page-aging and access faults to generic page-table API Will Deacon
2020-09-08 15:39   ` Alexandru Elisei
2020-09-07 15:23 ` [PATCH v4 12/21] KVM: arm64: Add support for stage-2 write-protect in generic page-table Will Deacon
2020-09-07 15:23 ` [PATCH v4 13/21] KVM: arm64: Convert write-protect operation to generic page-table API Will Deacon
2020-09-07 15:23 ` [PATCH v4 14/21] KVM: arm64: Add support for stage-2 cache flushing in generic page-table Will Deacon
2020-09-07 15:23 ` [PATCH v4 15/21] KVM: arm64: Convert memslot cache-flushing code to generic page-table API Will Deacon
2020-09-07 15:23 ` [PATCH v4 16/21] KVM: arm64: Add support for relaxing stage-2 perms in generic page-table code Will Deacon
2020-09-08 16:37   ` Alexandru Elisei
2020-09-07 15:23 ` [PATCH v4 17/21] KVM: arm64: Convert user_mem_abort() to generic page-table API Will Deacon
2020-09-09 14:20   ` Alexandru Elisei
2020-09-09 17:12     ` Marc Zyngier
2020-09-10 10:51       ` Will Deacon
2020-09-10 10:58         ` Marc Zyngier
2020-09-10 13:10         ` Alexandru Elisei
2020-09-10 13:20       ` Alexandru Elisei
2020-09-07 15:23 ` [PATCH v4 18/21] KVM: arm64: Check the pgt instead of the pgd when modifying page-table Will Deacon
2020-09-07 15:23 ` [PATCH v4 19/21] KVM: arm64: Remove unused page-table code Will Deacon
2020-09-08 10:33   ` Marc Zyngier
2020-09-10 10:54     ` Will Deacon
2020-09-07 15:23 ` [PATCH v4 20/21] KVM: arm64: Remove unused 'pgd' field from 'struct kvm_s2_mmu' Will Deacon
2020-09-07 15:23 ` [PATCH v4 21/21] KVM: arm64: Don't constrain maximum IPA size based on host configuration Will Deacon
2020-09-09 14:53   ` Alexandru Elisei
2020-09-07 17:16 ` [PATCH v4 00/21] KVM: arm64: Rewrite page-table code and fault handling Marc Zyngier
2020-09-07 17:31   ` Will Deacon
2020-09-10  4:06 ` Gavin Shan [this message]
2020-09-10  4:11   ` Gavin Shan
2020-09-10 10:58   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e41d4c5-1d36-fb28-880d-94235def35ed@redhat.com \
    --to=gshan@redhat.com \
    --cc=alexandru.elisei@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=james.morse@arm.com \
    --cc=kernel-team@android.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=qperret@google.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).