From: Marc Zyngier <maz@kernel.org>
To: Shenming Lu <lushenming@huawei.com>
Cc: Eric Auger <eric.auger@redhat.com>, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
wanghaibin.wang@huawei.com, yuzenghui@huawei.com
Subject: Re: [PATCH v4 5/6] KVM: arm64: GICv4.1: Restore VLPI pending state to physical side
Date: Mon, 15 Mar 2021 09:30:06 +0000 [thread overview]
Message-ID: <4f37549dcc5d3dd59a92bc94f2f0b59b@kernel.org> (raw)
In-Reply-To: <cd821431-52a7-d9a6-1468-8ce0c9446d85@huawei.com>
On 2021-03-15 09:25, Shenming Lu wrote:
> On 2021/3/15 17:20, Marc Zyngier wrote:
>> On 2021-03-15 09:11, Shenming Lu wrote:
>>> On 2021/3/15 16:30, Marc Zyngier wrote:
>>>> On 2021-03-13 08:38, Shenming Lu wrote:
>>>>> From: Zenghui Yu <yuzenghui@huawei.com>
>>>>>
>>>>> When setting the forwarding path of a VLPI (switch to the HW mode),
>>>>> we can also transfer the pending state from irq->pending_latch to
>>>>> VPT (especially in migration, the pending states of VLPIs are
>>>>> restored
>>>>> into kvm’s vgic first). And we currently send "INT+VSYNC" to
>>>>> trigger
>>>>> a VLPI to pending.
>>>>>
>>>>> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
>>>>> Signed-off-by: Shenming Lu <lushenming@huawei.com>
>>>>> ---
>>>>> arch/arm64/kvm/vgic/vgic-v4.c | 18 ++++++++++++++++++
>>>>> 1 file changed, 18 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm64/kvm/vgic/vgic-v4.c
>>>>> b/arch/arm64/kvm/vgic/vgic-v4.c
>>>>> index ac029ba3d337..3b82ab80c2f3 100644
>>>>> --- a/arch/arm64/kvm/vgic/vgic-v4.c
>>>>> +++ b/arch/arm64/kvm/vgic/vgic-v4.c
>>>>> @@ -449,6 +449,24 @@ int kvm_vgic_v4_set_forwarding(struct kvm
>>>>> *kvm, int virq,
>>>>> irq->host_irq = virq;
>>>>> atomic_inc(&map.vpe->vlpi_count);
>>>>>
>>>>> + /* Transfer pending state */
>>>>> + if (irq->pending_latch) {
>>>>> + unsigned long flags;
>>>>> +
>>>>> + ret = irq_set_irqchip_state(irq->host_irq,
>>>>> + IRQCHIP_STATE_PENDING,
>>>>> + irq->pending_latch);
>>>>> + WARN_RATELIMIT(ret, "IRQ %d", irq->host_irq);
>>>>> +
>>>>> + /*
>>>>> + * Clear pending_latch and communicate this state
>>>>> + * change via vgic_queue_irq_unlock.
>>>>> + */
>>>>> + raw_spin_lock_irqsave(&irq->irq_lock, flags);
>>>>> + irq->pending_latch = false;
>>>>> + vgic_queue_irq_unlock(kvm, irq, flags);
>>>>> + }
>>>>> +
>>>>> out:
>>>>> mutex_unlock(&its->its_lock);
>>>>> return ret;
>>>>
>>>> The read side of the pending state isn't locked, but the write side
>>>> is.
>>>> I'd rather you lock the whole sequence for peace of mind.
>>>
>>> Did you mean to lock before emitting the mapping request, Or just
>>> before reading
>>> the pending state?
>>
>> Just before reading the pending state, so that we can't get a
>> concurrent
>> modification of that state while we make the interrupt pending in the
>> VPT
>> and clearing it in the emulation.
>
> Get it. I will correct it right now.
Please hold off sending a new version for a few days. My inbox is
exploding...
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-15 9:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 8:38 [PATCH v4 0/6] KVM: arm64: Add VLPI migration support on GICv4.1 Shenming Lu
2021-03-13 8:38 ` [PATCH v4 1/6] irqchip/gic-v3-its: Add a cache invalidation right after vPE unmapping Shenming Lu
2021-03-13 8:38 ` [PATCH v4 2/6] irqchip/gic-v3-its: Drop the setting of PTZ altogether Shenming Lu
2021-03-13 8:38 ` [PATCH v4 3/6] KVM: arm64: GICv4.1: Add function to get VLPI state Shenming Lu
2021-03-13 8:38 ` [PATCH v4 4/6] KVM: arm64: GICv4.1: Try to save VLPI state in save_pending_tables Shenming Lu
2021-03-13 8:38 ` [PATCH v4 5/6] KVM: arm64: GICv4.1: Restore VLPI pending state to physical side Shenming Lu
2021-03-15 8:30 ` Marc Zyngier
2021-03-15 9:11 ` Shenming Lu
2021-03-15 9:20 ` Marc Zyngier
2021-03-15 9:25 ` Shenming Lu
2021-03-15 9:30 ` Marc Zyngier [this message]
2021-03-13 8:39 ` [PATCH v4 6/6] KVM: arm64: GICv4.1: Give a chance to save VLPI state Shenming Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f37549dcc5d3dd59a92bc94f2f0b59b@kernel.org \
--to=maz@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lushenming@huawei.com \
--cc=wanghaibin.wang@huawei.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).