From: Joe Perches <joe@perches.com>
To: Raviteja Narayanam <raviteja.narayanam@xilinx.com>,
linux-i2c@vger.kernel.org, michal.simek@xilinx.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, git@xilinx.com, marex@denx.de
Subject: Re: [PATCH 03/10] i2c: xiic: Fix coding style issues
Date: Mon, 31 May 2021 08:49:22 -0700 [thread overview]
Message-ID: <4f439c33c8f09da9f0fe44e8eebd98286c3e1e3e.camel@perches.com> (raw)
In-Reply-To: <20210531131948.19477-4-raviteja.narayanam@xilinx.com>
On Mon, 2021-05-31 at 07:19 -0600, Raviteja Narayanam wrote:
> From: Michal Simek <michal.simek@xilinx.com>
>
> Most of these stuff are reported by checkpatch.
trivia:
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
[]
> @@ -519,8 +522,8 @@ static irqreturn_t xiic_process(int irq, void *dev_id)
>
>
> /* Service requesting interrupt */
> if ((pend & XIIC_INTR_ARB_LOST_MASK) ||
> - ((pend & XIIC_INTR_TX_ERROR_MASK) &&
> - !(pend & XIIC_INTR_RX_FULL_MASK))) {
> + ((pend & XIIC_INTR_TX_ERROR_MASK) &&
> + !(pend & XIIC_INTR_RX_FULL_MASK))) {
This last line would more commonly be indented one more space to
align to the appropriate open parenthesis depth.
tab then 4 spaces for
((pend & XIIC_INTR_TX_ERROR_MASK) &&
tab then 5 spaces for
!(pend & XIIC_INTR_RX_FULL_MASK))) {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-31 15:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 13:19 [PATCH 00/10] i2c: xiic: Add features, bug fixes Raviteja Narayanam
2021-05-31 13:19 ` [PATCH 01/10] i2c: xiic: Fix Tx Interrupt path for grouped messages Raviteja Narayanam
2021-05-31 13:19 ` [PATCH 02/10] i2c: xiic: Add standard mode support for > 255 byte read transfers Raviteja Narayanam
2021-06-02 11:17 ` Marek Vasut
2021-06-03 5:33 ` Raviteja Narayanam
2021-06-03 9:57 ` Marek Vasut
2021-06-08 9:46 ` Raviteja Narayanam
2021-05-31 13:19 ` [PATCH 03/10] i2c: xiic: Fix coding style issues Raviteja Narayanam
2021-05-31 15:49 ` Joe Perches [this message]
2021-05-31 13:19 ` [PATCH 04/10] i2c: xiic: Add smbus_block_read functionality Raviteja Narayanam
2021-05-31 13:19 ` [PATCH 05/10] i2c: xiic: Return value of xiic_reinit Raviteja Narayanam
2021-05-31 13:19 ` [PATCH 06/10] i2c: xiic: Fix the type check for xiic_wakeup Raviteja Narayanam
2021-05-31 13:19 ` [PATCH 07/10] i2c: xiic: Switch to Xiic standard mode for i2c-read Raviteja Narayanam
2021-05-31 13:19 ` [PATCH 08/10] i2c: xiic: Remove interrupt enable/disable in Rx path Raviteja Narayanam
2021-05-31 13:19 ` [PATCH 09/10] dt-bindings: i2c: xiic: Add 'xlnx, axi-iic-2.1' to compatible Raviteja Narayanam
2021-05-31 13:19 ` [PATCH 10/10] i2c: xiic: Update compatible with new IP version Raviteja Narayanam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f439c33c8f09da9f0fe44e8eebd98286c3e1e3e.camel@perches.com \
--to=joe@perches.com \
--cc=git@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=michal.simek@xilinx.com \
--cc=raviteja.narayanam@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).