From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FFA7C6FD1D for ; Fri, 17 Mar 2023 08:56:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8RJe/eeEFqijvZZ4BIDzpfpGQW2ZCZOcTn5Byz0G2xI=; b=ScGr6oHz2vFyqN TfdTWN3YZI1fLV53yxiLcnQO4hBaRh3vyjvnGbh6N5JlPI0522r4UULeJDAa6ikmpR+C8T+s57k9Q w39q5Tek1w6jC1V4IfvDVBK0TYfalgi6QABRi18lBEAWOLLEyRwO8naTKkt2KOFygJi5wi3IAXajz cRXTRVRLSUgiOOBrhz+1tulj9TbSEZisLsBys6613h+OBnc8U/1e+dvYqdzCu7Bl7u6gfprMehBGI qE0ueCRozWF1VERxskmJA9FFw9pDg5ohclgCHJl0hgMJdp4xJMC/FZwyotJFunyj3FtiTINxxeWNL UY9v9cQGPyEnSc10dIDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pd5s2-001a6X-1X; Fri, 17 Mar 2023 08:55:30 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pd5rz-001a3f-18 for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 08:55:29 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32H8tKHF084921; Fri, 17 Mar 2023 03:55:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1679043320; bh=iNOyU8jAlyYbzlqmmNzxj5imjqg2Dawl0ITO6Jw3VBE=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=AJjkqJGh1Y/2MZawzjBmnsIgQmcnw8F1UwY5GzR2sWPOziCIba/MCrteVk6tGcvdg 2i/ys17INWggxOiy2BRiOAdm1WzHVdtmGwIiRBW9VxYkqjTOiEZgFGLEILd1iN+siE fHuVKZG338ZjJqwbnLkVUveFccAuNMaCjogQcAEU= Received: from DLEE111.ent.ti.com (dlee111.ent.ti.com [157.170.170.22]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32H8tKm9043688 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Mar 2023 03:55:20 -0500 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 17 Mar 2023 03:55:20 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 17 Mar 2023 03:55:20 -0500 Received: from [10.24.69.114] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32H8tE1a042709; Fri, 17 Mar 2023 03:55:15 -0500 Message-ID: <4f4dd491-e7f6-a963-c185-68521b262b22@ti.com> Date: Fri, 17 Mar 2023 14:25:14 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH v4 4/5] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR Content-Language: en-US To: Roger Quadros , MD Danish Anwar , "Andrew F. Davis" , Suman Anna , Vignesh Raghavendra , Mathieu Poirier , Bjorn Andersson , Santosh Shilimkar , Nishanth Menon CC: , , , , , , References: <20230313111127.1229187-1-danishanwar@ti.com> <20230313111127.1229187-5-danishanwar@ti.com> <60e73395-f670-6eaa-0eb7-389553320a71@kernel.org> <20718115-7606-a77b-7e4d-511ca9c1d798@ti.com> <468f85ad-e4b0-54e1-a5b9-4692ae8a1445@ti.com> <455440f4-7f2b-366e-53ec-700c3bb98534@kernel.org> <22b8860c-12bd-384d-41af-93f1dde9a0fd@ti.com> From: Md Danish Anwar Organization: Texas Instruments In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_015527_517795_EEEAF7A7 X-CRM114-Status: GOOD ( 14.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/03/23 14:01, Roger Quadros wrote: > > > On 17/03/2023 07:02, Md Danish Anwar wrote: >> >> >> On 16/03/23 19:34, Roger Quadros wrote: >>> >>> Hi, >>> >>> On 16/03/2023 15:11, Md Danish Anwar wrote: >>>> >>>> >>>> On 16/03/23 17:49, Roger Quadros wrote: >>>>> >>>>> >>>>> On 16/03/2023 13:44, Md Danish Anwar wrote: >>>>>> >>>>>> On 16/03/23 17:06, Roger Quadros wrote: >>>>>>> Hi, >>>>>>> >>>>>>> On 16/03/2023 13:05, Md Danish Anwar wrote: >>>>>>>> Hi Roger, >>>>>>>> >>>>>>>> On 15/03/23 17:52, Roger Quadros wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> On 13/03/2023 13:11, MD Danish Anwar wrote: >>>>>>>>>> From: Suman Anna >>> >> >> [..] >> >>>> Sure, then I will use the existing enum pru_type. >>>> >>>> The enum pru_type is currently in drivers/remoteproc/pruss.c I will move this >>>> enum definition from there to include/linux/remoteproc/pruss.h >>> >>> There are 2 public pruss.h files. >>> include/linux/remoteproc/pruss.h >>> and >>> include/linux/pruss_driver.h >>> >>> Why is that and when to use what? >>> >> >> The include/linux/remoteproc/pruss.h file was introduced in series [1] as a >> public header file for PRU_RPROC driver (drivers/remoteproc/pru_rproc.c) >> >> The second header file include/linux/pruss_driver.h was introduced much earlier >> as part of [2] , "soc: ti: pruss: Add a platform driver for PRUSS in TI SoCs". >> >> As far as I can see, seems like pruss_driver.h was added as a public header >> file for PRUSS platform driver (drivers/soc/ti/pruss.c) >> >> [1] https://lore.kernel.org/all/20230106121046.886863-1-danishanwar@ti.com/ >> [2] https://lore.kernel.org/all/1542886753-17625-7-git-send-email-rogerq@ti.com/ > > Thanks. "include/linux/remoteproc/pruss.h" seems appropriate for enum pru_type. > > cheers, > -roger Yes, enum pru_type is located in pru_rproc.c, I will move enum pru_type to include/linux/remoteproc/pruss.h and then include include/linux/remoteproc/pruss.h" in pru_rproc.c and any other file that needs this enum. -- Thanks and Regards, Danish. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel