From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Joe Perches" <joe@perches.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Joel Stanley" <joel@jms.id.au>
Cc: linux-aspeed@lists.ozlabs.org, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel@ffwll.ch>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro
Date: Thu, 25 Jul 2019 10:40:32 +0930 [thread overview]
Message-ID: <4f6709f8-381f-415c-8569-798b074b66c5@www.fastmail.com> (raw)
In-Reply-To: <2a0c5ef5c7e20b190156908991e4c964a501d80a.camel@perches.com>
On Thu, 25 Jul 2019, at 02:46, Joe Perches wrote:
> On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote:
> > Arguments are supposed to be ordered high then low.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> > drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h b/drivers/gpu/drm/aspeed/aspeed_gfx.h
> > index a10358bb61ec..095ea03e5833 100644
> > --- a/drivers/gpu/drm/aspeed/aspeed_gfx.h
> > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h
> > @@ -74,7 +74,7 @@ int aspeed_gfx_create_output(struct drm_device *drm);
> > /* CTRL2 */
> > #define CRT_CTRL_DAC_EN BIT(0)
> > #define CRT_CTRL_VBLANK_LINE(x) (((x) << 20) & CRT_CTRL_VBLANK_LINE_MASK)
> > -#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(20, 31)
> > +#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(31, 20)
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
>
> ping?
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-25 1:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190710050444epcas1p250f7aa0f8798a7757df51d66f5970c2a@epcas1p2.samsung.com>
2019-07-10 5:04 ` [PATCH 00/12] treewide: Fix GENMASK misuses Joe Perches
2019-07-10 5:04 ` [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro Joe Perches
2019-07-24 17:16 ` Joe Perches
2019-07-25 1:10 ` Andrew Jeffery [this message]
2019-07-25 1:18 ` Joe Perches
2019-07-25 2:52 ` Joel Stanley
2019-07-25 14:37 ` Joe Perches
2019-07-10 5:04 ` [PATCH 06/12] mmc: meson-mx-sdio: " Joe Perches
2019-07-22 7:23 ` Neil Armstrong
2019-07-22 13:43 ` Ulf Hansson
2019-07-10 5:04 ` [PATCH 07/12] net: ethernet: mediatek: Fix misuses " Joe Perches
2019-07-10 5:04 ` [PATCH 08/12] net: stmmac: " Joe Perches
2019-07-10 10:33 ` Jose Abreu
2019-07-10 5:04 ` [PATCH 10/12] phy: amlogic: G12A: Fix misuse " Joe Perches
2019-07-22 7:23 ` Neil Armstrong
2019-08-23 2:41 ` Kishon Vijay Abraham I
2019-08-23 4:59 ` Joe Perches
2019-07-10 5:04 ` [PATCH 11/12] staging: media: cedrus: " Joe Perches
2019-07-10 7:23 ` Paul Kocialkowski
2019-07-24 17:09 ` Joe Perches
2019-07-24 18:35 ` Greg Kroah-Hartman
2019-07-24 18:39 ` Joe Perches
2019-07-24 18:55 ` Greg Kroah-Hartman
2019-07-25 6:46 ` Hans Verkuil
2019-07-10 9:17 ` [PATCH 00/12] treewide: Fix GENMASK misuses Johannes Berg
2019-07-10 9:43 ` Russell King - ARM Linux admin
2019-07-10 15:45 ` Joe Perches
2019-07-10 16:01 ` Joe Perches
2019-07-11 21:30 ` David Miller
2019-07-12 12:54 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f6709f8-381f-415c-8569-798b074b66c5@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=joe@perches.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).