From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 742E2C433E0 for ; Mon, 8 Feb 2021 06:32:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 154C164E61 for ; Mon, 8 Feb 2021 06:32:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 154C164E61 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sholland.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=t5l31DfxyTXf53fXJHLAJUPpAIC9fphyI+9d0x43zrs=; b=VrwgjrNcBTQfWU81411RfzlJc 1zvkb6IkraTsLh2glksqMGjz6PljRzBDV0Py20EoQRS9PNVwkK81lSP1/+g/luBKSifgbAjSHWbrP twl1gqIy7MjP+HciFzJdOWNWLwUSSPoVOfzmhoLeX219/xvFcxFDgql4004/UTKp221KNgCqzmVA+ BJZaW02Ts/PQq7zPfiLxLS3jQOaKPbDz6EvTPszcvZt7x/GlS6J7nSZu05J0FiXd7L/bBowQ+5kTZ LkdYJx8q4udyzYej5ey70V+UXbRi+32CDWz/jQx7/+kRtRB+YfJkxkTHiHu51JkkFCHIV0yJt+o0C nk+9Y0inQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l905D-0006l7-3G; Mon, 08 Feb 2021 06:31:39 +0000 Received: from new3-smtp.messagingengine.com ([66.111.4.229]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l905A-0006kZ-WC for linux-arm-kernel@lists.infradead.org; Mon, 08 Feb 2021 06:31:37 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id B22075801BA; Mon, 8 Feb 2021 01:31:35 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 08 Feb 2021 01:31:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm1; bh=q yHgJypD7UyjQktxsd90zw6xmRVOTfop9RXXOGsXuwI=; b=klaYOGYQpnHUE8HUU sSSe247L3eQh6ZH3D9HaJX0SaJmHkahb4kg5TRnRxb80Ynq/GHTiO2vfBOPOoubr 8CmJSWTGZu7doLCOcPn3eF1kA7QchCaapoUbwMe8facrpGxsNVZADWxJUhQb/z74 kRmENA8oL4o/EIKAx4qB9MIDXMmNi0zlNFHvUIoy6bBCHvrSqfeoqEdOWHuNTl3Q 0buG0oC2UQ8/WJAmM31Mc1UqWzmbyQTgyweVRwHfrTHiGTEWrFCI+3Iv5cCnJVyd yc8CQDfTXcAghThoDpaSQU4+FC5upvGUTFZlPoG2qwyzqE5eWSLvd2mc9hGY5/L5 cyPuw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=qyHgJypD7UyjQktxsd90zw6xmRVOTfop9RXXOGsXu wI=; b=VOCyJ4nTludCu2lPGjVWCJ5JJZjPWDhWKCahVTLJS0X2SNoyrnWLFtv1z KQyLkH9qMcz34GI2nyFHYyxgJZ3WilziW6dbtQhmNcVYbM5GRVRQbKW6DC2NpLNh 3Lb8kZiCDk/OORkwlzyuRzDwNeyjiXRR2Wym3b1VN4CzsuZhFL/SrbcWPwHtKDW9 FWUD4DIxz0lzttradaLVo02TMoiAaEFY6i0eerGKAo/an2dXSUk45UGuAJe+2qJw ZlCgeeczx4vX/6VcA56FWRF7KhIpFR+su0x9VhEGouyy+h20EuE9dPedAU/yiPx4 UMrhbrzPYzft8MuLSWA33pdTwE9dQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrhedvgdelgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpefurghmuhgv lhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenucggtf frrghtthgvrhhnpefgveffteelheffjeeukedvkedviedtheevgeefkeehueeiieeuteeu gfettdeggeenucfkphepjedtrddufeehrddugeekrdduhedunecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshgrmhhuvghlsehshhholhhlrghn ugdrohhrgh X-ME-Proxy: Received: from [70.135.148.151] (70-135-148-151.lightspeed.stlsmo.sbcglobal.net [70.135.148.151]) by mail.messagingengine.com (Postfix) with ESMTPA id 010B0240057; Mon, 8 Feb 2021 01:31:34 -0500 (EST) Subject: Re: [PATCH] i2c: mv64xxx: Fix check for missing clock To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Jakub Kicinski , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Corentin Labbe References: <20210208062859.11429-1-samuel@sholland.org> <20210208062859.11429-2-samuel@sholland.org> From: Samuel Holland Message-ID: <4f696b13-2475-49f2-5d75-f2120e159142@sholland.org> Date: Mon, 8 Feb 2021 00:31:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux ppc64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20210208062859.11429-2-samuel@sholland.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210208_013137_081539_E8AE0486 X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ondrej Jirman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org, Dan Carpenter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/8/21 12:28 AM, Samuel Holland wrote: > In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error > pointers to optional clocks were replaced by NULL to simplify the resume > callback implementation. However, that commit missed that the IS_ERR > check in mv64xxx_of_config should be replaced with a NULL check. As a > result, the check always passes, even for an invalid device tree. Sorry, please ignore this unrelated patch. I accidentally copied it to the wrong directory before sending this series. Samuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel