From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD82AC43460 for ; Fri, 14 May 2021 10:09:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F086613F1 for ; Fri, 14 May 2021 10:09:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F086613F1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7wlS46dXyjinHECEInob1HPD4BZypPjDeiQeGEsxsic=; b=Cx8WwpQHU7IXLH/UYY14wzaao hfb/2DnioakBePkVGIjfsP84F7R/4euOwolVtomgCgYLGlE+JkW+lR2asuH90cqblp3xKOaYldYzY bpjrH3jLT+VS7Odh25N5CjxJTvJYqPQwJvgS7+QolSze58pYsDD9cH9Zaat5Wb2kjBGV5nA7cMolu /ddeuNqM13/O69yRAkKBy6x1546uwwsRPwVUXQqRmfe6RLmeMVLSaSpys+A2bzgT/yQM3+1RMCBgO XLLZ/mohDkDGBHTri3DmCdc7oI2u4OR0dFdTK+vUvUcXceY2LSP+xgoFk1ve1PtEddpxZqvAPF3IJ zsnp8ZBVQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhUit-007jON-4Y; Fri, 14 May 2021 10:07:11 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhUio-007jNY-FB; Fri, 14 May 2021 10:07:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description; bh=Hd5DQUxNI1yAI6Q0oyaRDpsRJtfrtO9x5rU4anWM5qg=; b=0J/3tNnWhXfIHxSf0P8Zn4CM6B B1xfpYTpwOzGUg0XOuMdRRKzx7dZHSTEk6MiDC1ubOLvGGvvjgInjudtk2/q/PFuGYVQu4UELFx2j ETb8VlOFT9xabSo5jyzib/NB69RgmY1TnH/YQD4QuyYUkR2hriJEYoB3U+Y9tovmM9QSkXoHle+u3 JpIXbmCpV67x23e0tyi/KWRPjrHjlBHgv3fB0OOKZWgsI+iYR6Vl+MsU+/7GRv4n3xPSPiVmWBQaU IUYQIwdTCBdvRl6OkIIwEvKX4U3e2C+LgEQExdX8+vCReSTYo3ab1LUYiVV30/1lBhspyyyqfz6rh iC8PnVdg==; Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhUil-00Bt2W-Tq; Fri, 14 May 2021 10:07:05 +0000 Received: from p5b127fa9.dip0.t-ipconnect.de ([91.18.127.169] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhUia-0001yI-9m; Fri, 14 May 2021 12:06:52 +0200 From: Heiko Stuebner To: cl@rock-chips.com Cc: robh+dt@kernel.org, jagan@amarulasolutions.com, wens@csie.org, uwe@kleine-koenig.org, mail@david-bauer.net, jbx6244@gmail.com, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, jensenhuang@friendlyarm.com, michael@amarulasolutions.com, cnsztl@gmail.com, devicetree@vger.kernel.org, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-i2c@vger.kernel.org, jay.xu@rock-chips.com, shawn.lin@rock-chips.com, david.wu@rock-chips.com, zhangqing@rock-chips.com, huangtao@rock-chips.com, cl@rock-chips.com, wim@linux-watchdog.org, linux@roeck-us.net, jamie@jamieiles.com, linux-watchdog@vger.kernel.org, maz@kernel.org Subject: Re: [RESEND PATCH v4 06/10] dt-bindings: gpio: change items restriction of clock for rockchip, gpio-bank Date: Fri, 14 May 2021 12:06:51 +0200 Message-ID: <5026524.44csPzL39Z@phil> In-Reply-To: <20210513064606.18397-1-cl@rock-chips.com> References: <20210429081151.17558-1-cl@rock-chips.com> <20210513064606.18397-1-cl@rock-chips.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210514_030703_997739_570BC9DC X-CRM114-Status: GOOD ( 15.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Donnerstag, 13. Mai 2021, 08:46:06 CEST schrieb cl@rock-chips.com: > From: Liang Chen > > The clock property need 2 items on some rockchip chips. > > Signed-off-by: Liang Chen this patch should definitly move over to Jianquns gpio driver series, as it introduces the usage of these new clocks. Also while the single-clock variant definitly doesn't need it, I think we may want clock-names "apb_pclk", "debounce-ref" for the 2-clock variants? Heiko > --- > Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > index d993e00..0d62c28 100644 > --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > @@ -22,7 +22,10 @@ properties: > maxItems: 1 > > clocks: > - maxItems: 1 > + minItems: 1 > + items: > + - description: APB interface clock source > + - description: GPIO debounce reference clock source > > gpio-controller: true > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel