linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] clk: add si5351 i2c common clock driver
Date: Sat, 23 Mar 2013 11:07:16 +0100	[thread overview]
Message-ID: <514D7ED4.2030205@metafoo.de> (raw)
In-Reply-To: <514B7C80.2070008@gmail.com>

On 03/21/2013 10:32 PM, Sebastian Hesselbarth wrote:
>>> +
>>> +    dev_info(&client->dev, "registered si5351 i2c client\n");
>>> +
>>
>> That's just noise, imagine every driver would print such a line, your bootlog
>> would be scrolling for hours ;) I'd either remove it or make it dev_dbg
> 
> Actually, I understand not to have it, but if you don't want it you can still
> boot with "quiet", can't you? Having one single line that helps you see it has
> been probed helps a lot. But, I don't have a strong opinion on that and can
> make it dev_dbg.

It is useful during development, but in my opinion only as long as not every
other driver does this as well. If you want to check whether a device has
been probed you can easily do this by checking the drivers sysfs node.

- Lars

  reply	other threads:[~2013-03-23 10:07 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-09 12:59 [PATCH] clk: add si5351 i2c common clock driver Sebastian Hesselbarth
2013-02-11  5:46 ` Mike Turquette
2013-02-11  9:52   ` Sebastian Hesselbarth
2013-02-18 10:19 ` Daniel Mack
2013-02-19 19:15 ` Daniel Mack
2013-02-27 10:01   ` Sebastian Hesselbarth
2013-03-01 15:01     ` Daniel Mack
2013-03-16 13:10 ` [PATCH v2] " Sebastian Hesselbarth
2013-03-16 15:10   ` Daniel Mack
2013-03-18 10:43 ` [PATCH v3] " Sebastian Hesselbarth
2013-03-18 11:37   ` Daniel Mack
2013-03-20  0:26   ` Mike Turquette
2013-03-20  8:20     ` Sebastian Hesselbarth
2013-03-21 18:09   ` Lars-Peter Clausen
2013-03-21 21:32     ` Sebastian Hesselbarth
2013-03-23 10:07       ` Lars-Peter Clausen [this message]
2013-03-23 14:46   ` [PATCH v4] " Sebastian Hesselbarth
2013-04-02 23:46     ` Mike Turquette
2013-04-03 11:10       ` Sebastian Hesselbarth
2013-04-05  5:23     ` [PATCH v5] " Sebastian Hesselbarth
2013-04-07 22:50       ` [v5] " Guenter Roeck
2013-04-07 23:49         ` Sebastian Hesselbarth
2013-04-08  0:17           ` Guenter Roeck
2013-04-08  6:11             ` Sebastian Hesselbarth
2013-04-08 14:54               ` Guenter Roeck
2013-04-08 15:38                 ` Sebastian Hesselbarth
2013-04-08 17:36                   ` Mike Turquette
2013-04-08 18:32                     ` Sebastian Hesselbarth
2013-04-08 16:46       ` [PATCH v6] " Sebastian Hesselbarth
2013-04-08 17:46         ` Guenter Roeck
2013-04-08 18:24           ` Sebastian Hesselbarth
2013-04-10  9:40         ` [PATCH v7] " Sebastian Hesselbarth
2013-04-10 10:17           ` Daniel Mack
2013-04-10 14:48             ` Michal Bachraty
2013-04-10 17:27               ` Sebastian Hesselbarth
2013-04-11  7:44                 ` Michal Bachraty
2013-04-11  8:22                   ` Sebastian Hesselbarth
2013-04-10 19:34           ` Guenter Roeck
2013-04-11 19:42           ` [PATCH v8] " Sebastian Hesselbarth
2013-04-12 11:43             ` Michal Bachraty
2013-04-12 18:19             ` Mike Turquette
     [not found] <fa.WZVD0OA/Ooajh6BejiLf7TwBsJ8@ifi.uio.no>
     [not found] ` <fa.iIqrS6k+Vb5mLqAeL7iTsNsbKyo@ifi.uio.no>
     [not found]   ` <fa.L0b41q+fYFZG0WOFTGKLhn/cGPA@ifi.uio.no>
     [not found]     ` <fa.XCuSmq9Zwp3+wqFO8NEjpwADVZ0@ifi.uio.no>
2013-03-20 13:55       ` [PATCH v3] " michal.bachraty at gmail.com
2013-03-20 16:48         ` Daniel Mack
2013-03-25 11:54           ` Sebastian Hesselbarth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514D7ED4.2030205@metafoo.de \
    --to=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).