From: avinashphilip@ti.com (Philip, Avinash)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] arm: davinci: clock node support for ECAP & EHRPWM
Date: Wed, 20 Mar 2013 11:29:14 +0000 [thread overview]
Message-ID: <518397C60809E147AF5323E0420B992E3EA99E05@DBDE01.ent.ti.com> (raw)
In-Reply-To: <51499C72.9030602@ti.com>
On Wed, Mar 20, 2013 at 16:54:34, Nori, Sekhar wrote:
> On 3/20/2013 12:11 PM, Philip Avinash wrote:
> > Add clock node support for ECAP and EHRPWM modules.
> > Also adds TBCLK for EHRWPM TBCLK to comply with pwm-tiehrpwm
> > driver.
> >
> > Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> > ---
> > Changes Since v1:
> > - TBCLK make it as actual clock with enable/disable feature.
> >
> > :100644 100644 0c4a26d... dbed75c... M arch/arm/mach-davinci/da850.c
> > :100644 100644 de439b7... be77ce2... M arch/arm/mach-davinci/include/mach/da8xx.h
> > arch/arm/mach-davinci/da850.c | 46 ++++++++++++++++++++++++++++
> > arch/arm/mach-davinci/include/mach/da8xx.h | 1 +
> > 2 files changed, 47 insertions(+)
> >
> > diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
> > index 0c4a26d..dbed75c 100644
> > --- a/arch/arm/mach-davinci/da850.c
> > +++ b/arch/arm/mach-davinci/da850.c
> > @@ -383,6 +383,49 @@ static struct clk dsp_clk = {
> > .flags = PSC_LRST | PSC_FORCE,
> > };
> >
> > +static struct clk ehrpwm_clk = {
> > + .name = "ehrpwm",
> > + .parent = &pll0_sysclk2,
> > + .lpsc = DA8XX_LPSC1_PWM,
> > + .gpsc = 1,
> > + .flags = DA850_CLK_ASYNC3,
> > +};
> > +
> > +#define DA8XX_EHRPWM_TBCLKSYNC BIT(12)
> > +
> > +void tblck_enable(struct clk *clk)
>
> This should be static. Also, since tbclk is associated with ehrpwm,
> please call the function ehrpwm_tbclk_enable().
Ok I will correct it.
Thanks
Avinash
>
> > +{
> > + u32 val;
> > +
> > + val = readl(DA8XX_SYSCFG0_VIRT(DA8XX_CFGCHIP1_REG));
> > + val |= DA8XX_EHRPWM_TBCLKSYNC;
> > + writel(val, DA8XX_SYSCFG0_VIRT(DA8XX_CFGCHIP1_REG));
> > +}
> > +
> > +void tblck_disable(struct clk *clk)
>
> Same comment as above applies.
>
> Thanks,
> Sekhar
>
next prev parent reply other threads:[~2013-03-20 11:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 6:41 [PATCH v2 0/3] Platform support for EHRPWM & ECAP devices in DAVINCI Philip Avinash
2013-03-20 6:41 ` [PATCH v2 1/3] ARM: davinci: clk framework support for enable/disable functionality Philip Avinash
2013-03-20 11:19 ` Sekhar Nori
2013-03-20 11:28 ` Philip, Avinash
2013-03-20 6:41 ` [PATCH v2 2/3] arm: davinci: clock node support for ECAP & EHRPWM Philip Avinash
2013-03-20 11:24 ` Sekhar Nori
2013-03-20 11:29 ` Philip, Avinash [this message]
2013-03-20 6:41 ` [PATCH v2 3/3] ARM: davinci: da850: add EHRPWM & ECAP DT node Philip Avinash
2013-03-20 11:29 ` Sekhar Nori
2013-03-20 12:47 ` Peter Korsgaard
2013-03-21 8:01 ` Philip, Avinash
2013-03-22 5:53 ` Sekhar Nori
2013-03-22 8:08 ` Philip, Avinash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518397C60809E147AF5323E0420B992E3EA99E05@DBDE01.ent.ti.com \
--to=avinashphilip@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).