From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (unknown [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1E34C4332F for ; Tue, 8 Nov 2022 20:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mB/4+2DTHvIxpqVIgFdW/JvLagBlKpyrN8KpQWypXVw=; b=d1aUdC6kTmPIUc Vt+R8/IcmexuGai6r5Bk3nR4i/RDgPrBtBj2xjhlTwApNcY7IRp5efZPsa4aGyHG5Nfe0aE66KU92 STGaL8wk9IEedZrl/1Ws/a6Oimb/0nqTWkhrpdlpk2axP0mmHLEANTOQGfBe+9CP571CCPXKgdmO6 LeT16/ITdvLdQlHzHLmXd3CId69VoAmPrA0hi/5aWlErFvdg+DwQrEj8nHDZk0s2HF5r6vUh1EAv3 0mgitsIXiOYNG1DuNeGxMD19Ho1kldUUweN+bGPrHZi7WwTHyt/zoxiv3ghWVTXqSCQdsvI05G1c4 M0Lh3R7oL0tIaaAxxEGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osVdf-008Dvt-Tv; Tue, 08 Nov 2022 20:56:08 +0000 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1osVdc-008DvO-9c for linux-arm-kernel@lists.infradead.org; Tue, 08 Nov 2022 20:56:05 +0000 Received: by mail-lf1-x12c.google.com with SMTP id l12so11755622lfp.6 for ; Tue, 08 Nov 2022 12:56:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZN9uZSDNWvaPFO2rZ2x2Euvj8Fn47RRK/0sBC6DfBoo=; b=CuaG+ej43GV97bUxgLQ9Mm7HA7sNVVPduZA+KOU+AD0jUQpgdK2xLg5+jOzpTkMTkd YRdoqohWEn/klIj6bPC4IgxMSsVVC5svI2BPsorqQfBxwe2o/DohjYx8NEPwa7rt9UKU ZzBGG9pXB6oIJ2M1xF0rDC5J/WyZQlJFOzL436PLSirh6EBvyoOzAwnGoGNKwu+7RWN8 GmyflwkKAKtNq2iUMsLJJCxoFxNgINizTJBJ8uNMxS7U19tp/v6cAF224e07LIq/QTo0 NSiBRikayAq+us4QpLNdvEfZjYkk1nwrFpBCSb26a3cbqrN+o7ih+b5KtV5C0CaseA0o 4K+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZN9uZSDNWvaPFO2rZ2x2Euvj8Fn47RRK/0sBC6DfBoo=; b=VlGzRsCkTNnfyaRCHkYVL0WbfDeEtMLnPrlwUBj0qGAaZeipxnirLl31ovJrrr9Onn VhqFLu1koh6kYNRvCjna80LgbUwWWVH5GdsJeZG/tEm2DqdcJssSU2xto1620xEqhAdx Eyr8vbaJkNGKa8xCYKcBl5n22OBBxfyPM1TLrrA+Wzt7Me7xrJ7VfV7ixv9O9l02+8wa RuyEei8lJySTHfKXKjOMxEtmuntsDy4PtC86OkbYJqngiptAcwUBHVN6tF0cQOypt1sy bfsha5mBSh9I2gf5oaWSKGPwgLLy2fiVPc2pZMPhELH4L03mZSiqETFPWceexCNDRPhR lBtg== X-Gm-Message-State: ANoB5pm+2rISay5ebaN55d10/zJqPcZptSHBY311lh+hW+W6DcBoCJzC J2My3aj+MGf3VcxA77iR3Mg3Gw== X-Google-Smtp-Source: AA0mqf5bvyq3TmeVB175nUAweelEZ+MjMm8/M3KZoRYAcUcfeLH2drcbccrcU5kqWiR1zP0FQH25kg== X-Received: by 2002:ac2:5b8f:0:b0:4b3:e970:693f with SMTP id o15-20020ac25b8f000000b004b3e970693fmr2654998lfn.421.1667940960464; Tue, 08 Nov 2022 12:56:00 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id g4-20020a056512118400b00497a1f92a72sm1933759lfr.221.2022.11.08.12.55.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Nov 2022 12:55:59 -0800 (PST) Message-ID: <531d88b8-75db-1d8f-1384-b8d05594e7b3@linaro.org> Date: Tue, 8 Nov 2022 21:55:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller Content-Language: en-US To: "Russell King (Oracle)" , Linus Walleij , Bartosz Golaszewski , Rob Herring , Lee Jones Cc: Alyssa Rosenzweig , Andy Shevchenko , asahi@lists.linux.dev, devicetree@vger.kernel.org, Hector Martin , Jonathan Corbet , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org, Petr Mladek , Rasmus Villemoes , Sergey Senozhatsky , Steven Rostedt , Sven Peter References: From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221108_125604_371628_78D15A1D X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/11/2022 17:33, Russell King (Oracle) wrote: > Add a DT binding for the Apple Mac System Management Controller. Drop the second, redundant "binding" from subject. It's already in prefix. > > Signed-off-by: Russell King (Oracle) > --- > .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++ > 1 file changed, 67 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/apple,smc.yaml b/Documentation/devicetree/bindings/mfd/apple,smc.yaml > new file mode 100644 > index 000000000000..014eba5a1bbc > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/apple,smc.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple Mac System Management Controller > + > +maintainers: > + - Hector Martin > + > +description: > + Apple Mac System Management Controller implements various functions > + such as GPIO, RTC, power, reboot. > + > +properties: > + compatible: > + items: > + - enum: > + - apple,t6000-smc > + - apple,t8103-smc > + - apple,t8112-smc > + - const: apple,smc > + > + reg: > + items: > + - description: SMC area > + - description: SRAM area > + > + reg-names: > + items: > + - const: smc > + - const: sram > + > + mboxes: > + maxItems: 1 > + > + gpio: > + $ref: /schemas/gpio/gpio-macsmc.yaml So this depends on other patch, so: 1. You need mention the dependency in cover letter (nothing there), 2. Re-order patches. The GPIO cannot go separate tree and this must be explicitly communicated. > + > +additionalProperties: false > + > +required: > + - compatible > + - reg > + - reg-names > + - mboxes > + > +examples: > + - | > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + smc@23e400000 { Usually these are called system-controller, to have a generic name (as asked by DT spec). > + compatible = "apple,t8103-smc", "apple,smc"; > + reg = <0x2 0x3e400000 0x0 0x4000>, > + <0x2 0x3fe00000 0x0 0x100000>; Align the items (opening <). With three above: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel