From: cyrille.pitchen@atmel.com (Cyrille Pitchen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/6] ARM: at91: change compatibility string for sama5d3x gem
Date: Thu, 24 Jul 2014 17:57:42 +0200 [thread overview]
Message-ID: <53D12CF6.6070502@atmel.com> (raw)
In-Reply-To: <20140724151529.GA26190@leverpostej>
Le 24/07/2014 17:15, Mark Rutland a ?crit :
> On Thu, Jul 24, 2014 at 12:51:02PM +0100, Cyrille Pitchen wrote:
>> this new compatibility string prevents macb/gem driver from using the
>> scatter-gather and gso features on sama5d3x boards.
>
> What will happen were the driver to attempt to use the features on this
> board?
>
> How will this affect existing DTBs?
>
> Thanks,
> Mark.
>
Hi Mark,
patch 2 for then scatter-gather feature introducted a new compatible string
"atmel,sama5d3-gem". Its associated config has the MACB_CAPS_SG_DISABLED flag
so the feature is not available indeed.
patch 2 also set the very same flag for the config associated to the already
existing strings "cdns,pc302-gem" and "cdns,gem". Then if you don't update
your device tree, the scatter-gather feature won't be enabled for gem anyway.
However SG feature will be enabled for the old macb.
The main idea is to do the change in two steps to avoid indroducing bugs. This
series of patches is the first step. Later an additionnal patch may be
introduced to enable SG feature for gem on all platforms but sama5d3x. This
should be done by removing the MACB_CAPS_SG_DISABLED flag from pc302gem_config.
Till then you don't need to update your device tree.
For now, the SG feature is known to be broken on sama5d3x and there is work in
progress with Cadence support to fix this issue. It seems to be specific to
sama5d3x gem. SG feature was successfully tested on sama5d3x macb and also on
sama5d4 gem.
Regards,
Cyrille
>>
>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>> ---
>> arch/arm/boot/dts/sama5d3_gmac.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/sama5d3_gmac.dtsi b/arch/arm/boot/dts/sama5d3_gmac.dtsi
>> index a6cb050..de5ed59 100644
>> --- a/arch/arm/boot/dts/sama5d3_gmac.dtsi
>> +++ b/arch/arm/boot/dts/sama5d3_gmac.dtsi
>> @@ -74,7 +74,7 @@
>> };
>>
>> macb0: ethernet at f0028000 {
>> - compatible = "cdns,pc302-gem", "cdns,gem";
>> + compatible = "atmel,sama5d3-gem";
>> reg = <0xf0028000 0x100>;
>> interrupts = <34 IRQ_TYPE_LEVEL_HIGH 3>;
>> pinctrl-names = "default";
>> --
>> 1.8.2.2
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
next prev parent reply other threads:[~2014-07-24 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 11:50 [PATCH v2 0/6] net/macb: add HW features to macb driver Cyrille Pitchen
2014-07-24 11:50 ` [PATCH v2 1/6] net/macb: configure for FIFO mode and non-gigabit Cyrille Pitchen
2014-07-24 11:50 ` [PATCH v2 2/6] net/macb: add scatter-gather hw feature Cyrille Pitchen
2014-07-24 11:51 ` [PATCH v2 3/6] net/macb: add TX checksum offload feature Cyrille Pitchen
2014-07-24 11:51 ` [PATCH v2 4/6] net/macb: add RX " Cyrille Pitchen
2014-07-24 11:51 ` [PATCH v2 5/6] ARM: at91: change compatibility string for sama5d3x gem Cyrille Pitchen
2014-07-24 15:15 ` Mark Rutland
2014-07-24 15:57 ` Cyrille Pitchen [this message]
2014-07-24 11:51 ` [PATCH v2 6/6] net/macb: enable scatter-gather feature and set DMA burst length for sama5d4 gem Cyrille Pitchen
2014-07-25 6:40 ` [PATCH v2 0/6] net/macb: add HW features to macb driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D12CF6.6070502@atmel.com \
--to=cyrille.pitchen@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).