From: gdjakov@mm-sol.com (Georgi Djakov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: dts: qcom: Add initial IFC6540 board device tree
Date: Fri, 05 Sep 2014 18:59:10 +0300 [thread overview]
Message-ID: <5409DDCE.7080106@mm-sol.com> (raw)
In-Reply-To: <5409C803.8060007@suse.de>
Hi
On 09/05/2014 05:26 PM, Andreas F?rber wrote:
<...>
>> + reg-names = "hc_mem", "core_mem";
>> + interrupts = <0 123 0>, <0 138 0>;
>
> I see that you've used GPIO_ACTIVE_* above. Is the trailing zero here
> possibly IRQ_TYPE_NONE?
>
Yes, it is. Will update it. Thanks!
>> + interrupt-names = "hc_irq", "pwr_irq";
>> + clocks = <&gcc GCC_SDCC1_APPS_CLK>, <&gcc GCC_SDCC1_AHB_CLK>;
>> + clock-names = "core", "iface";
>> + status = "disabled";
>> + };
>> +
>> + sdhci at f98a4900 {
>> + compatible = "qcom,sdhci-msm-v4";
>> + reg = <0xf98a4900 0x11c>, <0xf98a4000 0x800>;
>> + reg-names = "hc_mem", "core_mem";
>> + interrupts = <0 125 0>, <0 221 0>;
>> + interrupt-names = "hc_irq", "pwr_irq";
>> + clocks = <&gcc GCC_SDCC2_APPS_CLK>, <&gcc GCC_SDCC2_AHB_CLK>;
>> + clock-names = "core", "iface";
>> + status = "disabled";
>> + };
>
> If you assign labels to these two nodes, you can reference them in the
> .dts as &labelname {...};. Same for the uart node. That avoids
> duplicating the hierarchy, detects spelling mistakes at compile time and
> reduces indentation. Cf. the recent ifc6410 patch.
Sure, adding a label will not hurt.
>
> Also, is sdhci the best node name here? Usually it's not supposed to
> reflect the exact interface used (e.g., usb vs. ehci).
>
Ok, I'll figure out something better.
>> };
>> };
>
> Otherwise looks good.
>
Thanks for reviewing!
BR,
Georgi
prev parent reply other threads:[~2014-09-05 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 16:50 [PATCH v3] ARM: dts: qcom: Add initial IFC6540 board device tree Georgi Djakov
2014-09-05 14:26 ` Andreas Färber
2014-09-05 15:20 ` Kumar Gala
2014-09-05 16:00 ` Andreas Färber
2014-09-05 15:59 ` Georgi Djakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5409DDCE.7080106@mm-sol.com \
--to=gdjakov@mm-sol.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).