linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: monstr@monstr.eu (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: xilinx: Use standard num-cs binding
Date: Thu, 12 Feb 2015 10:45:02 +0100	[thread overview]
Message-ID: <54DC761E.9040701@monstr.eu> (raw)
In-Reply-To: <67f3c196833c427a489ca2c530d08987a6b5ee2a.1421412912.git.michal.simek@xilinx.com>

Hi Mark,

On 01/16/2015 01:55 PM, Michal Simek wrote:
> Use standard num-cs binding property and setup
> "xlnx,num-ss-bits" as deprecated.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  drivers/spi/spi-xilinx.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index 79bd84f43430..30e5180195bb 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -338,8 +338,15 @@ static int xilinx_spi_probe(struct platform_device *pdev)
>  		num_cs = pdata->num_chipselect;
>  		bits_per_word = pdata->bits_per_word;
>  	} else {
> -		of_property_read_u32(pdev->dev.of_node, "xlnx,num-ss-bits",
> -					  &num_cs);
> +		if (of_property_read_u32(pdev->dev.of_node, "num-cs",
> +					 &num_cs)) {
> +			if (!of_property_read_u32(pdev->dev.of_node,
> +						  "xlnx,num-ss-bits",
> +						  &num_cs)) {
> +				dev_err(&pdev->dev,
> +					"property name 'xlnx,num-ss-bits' is deprecated.\n");
> +			}
> +		}
>  	}
> 
>  	if (!num_cs) {
> --
> 1.8.2.3
> 

Any update on this one?

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150212/cb78f389/attachment.sig>

  reply	other threads:[~2015-02-12  9:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16 12:55 [PATCH] spi: xilinx: Use standard num-cs binding Michal Simek
2015-02-12  9:45 ` Michal Simek [this message]
     [not found] ` <CAHTX3dJRGhwo7FW+VJxfEJmx-9FdjFN5EnxG0RRDfMOm3=VU4A@mail.gmail.com>
     [not found]   ` <20150214053543.GL9110@finisterre.sirena.org.uk>
2015-02-23 10:22     ` Michal Simek
2015-02-24 14:52       ` Mark Brown
2015-03-08 19:00 ` Mark Brown
2015-03-27 10:55   ` Michal Simek
2015-03-27 17:53     ` Mark Brown
2015-03-30  6:46       ` Michal Simek
2015-03-31  5:47         ` Mark Brown
2015-03-31  8:16           ` Michal Simek
2015-03-31 11:16             ` Mark Brown
2015-03-31 11:25               ` Michal Simek
2015-03-31 12:24                 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DC761E.9040701@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).