From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB36FC10F11 for ; Wed, 10 Apr 2019 10:57:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B7DE2075B for ; Wed, 10 Apr 2019 10:57:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G4LwNuoq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B7DE2075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UdCUFueLoKWIO+aa7RJX6b79echaD0V0DRwVchfT3BQ=; b=G4LwNuoqSOyCC/O0Vl8GyMjBr EyEtFu9vaXpq8UtnS4cqOs7FSs05SRd9t8/LV06+xlRgb4jpkvch2NW3S778t0THTK8smEv+S3Nsa 3aV23JCFPVl31WUYSp+k/a0nBDO4gvgI2Pdo6CZycCh1yrlnXtWMXogWQ1LVtV4joy1oGilZ+bt7J GQcqucYFse2xQzZVa9E7i8Dlp+UmGntEXzE0YXG45PHWSEgtpqTLfb0ssXp6Dr4SIXcomicCrkzwU IFAbwxYLT2klAfFzLSOo8KL7dRn+QA3Zgh11rfdMP/k1Nm8k47Hatf8FCs9jq1V5L9dxg4nmI5tON 3AxpGmtkA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEAv8-0007mD-M0; Wed, 10 Apr 2019 10:57:34 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEAv5-0007lN-AK for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2019 10:57:33 +0000 Received: from [IPv6:2a02:2450:102f:3e0:9891:9d6a:3d2f:24f2] (unknown [IPv6:2a02:2450:102f:3e0:9891:9d6a:3d2f:24f2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: robertfoss) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 18CD627F6D6; Wed, 10 Apr 2019 11:57:27 +0100 (BST) Subject: Re: [PATCH] ARM: dts: imx6qdl-nitrogen6_max: Disable LVDS channels To: Gary Bisson References: <20190408175319.9106-1-robert.foss@collabora.com> <4fd506a1-c961-0569-6d39-283758f363d9@collabora.com> From: Robert Foss Message-ID: <550afae6-8dd8-39aa-c7a2-01b27557aa53@collabora.com> Date: Wed, 10 Apr 2019 12:57:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190410_035731_627319_2667D31E X-CRM114-Status: GOOD ( 25.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Shawn Guo , Sascha Hauer , linux-kernel , Troy Kisky , Rob Herring , NXP Linux Team , Sascha Hauer , Fabio Estevam , Fabio Estevam , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Gary, On 4/10/19 9:35 AM, Gary Bisson wrote: > Hi, > > On Tue, Apr 9, 2019 at 2:07 AM Robert Foss wrote: >> >> Hey Fabio, >> >> On 4/8/19 10:37 PM, Fabio Estevam wrote: >>> Hi Robert, >>> >>> [Adding Gary] > > Adding Troy, I'm no longer a full-time employee at Boundary Devices. > >>> On Mon, Apr 8, 2019 at 2:54 PM Robert Foss wrote: >>>> >>>> If a LVDS device is not connected, having the LVDS channels >>>> enabled will prevent imx-ldb from probing correctly even >>>> if other CRTCs are connected. >>>> >>>> Signed-off-by: Robert Foss >>>> --- >>>> arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi >>>> index 39200e5dc896..5b413cf4c250 100644 >>>> --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi >>>> +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi >>>> @@ -703,7 +703,7 @@ >>>> status = "okay"; >>>> >>>> lvds-channel@0 { >>>> - status = "okay"; >>>> + status = "disabled"; >>>> >>>> port@4 { >>>> reg = <4>; >>>> @@ -715,7 +715,7 @@ >>>> }; >>>> >>>> lvds-channel@1 { >>>> - status = "okay"; >>>> + status = "disabled"; >>> >>> I am not sure I understood what you are trying to fix. >> >> If CONFIG_DRM_IMX_LDB is enabled, LVDS DT channels are enabled >> and no LVDS-panels are connected the imx-ldb driver will >> fail to bind. >> >> This is a problem, since it will prevent other actually connected >> display output from being used, even if they bind properly. >> >>> >>> Could you please share some logs when imx-ldb fails to probe correctly? >> >> >> [ 2.119563] component_bind_all() trying to bind: ldb >> [ 2.124600] imx-drm display-subsystem: binding ldb (ops imx_ldb_ops) >> [ 2.146169] drm_of_find_panel_or_bridge() np->name=lvds-channel np->type= >> [ 2.153709] drm_of_find_panel_or_bridge() no panel found for remote >> [ 2.160081] drm_of_find_panel_or_bridge() bridge needed >> [ 2.162043] drm_of_find_panel_or_bridge() bridge not found >> [ 2.165331] drm_of_find_panel_or_bridge() failed >> [ 2.170023] imx-drm display-subsystem: failed to bind ldb (ops imx_ldb_ops): -517 >> >> This at the same time as HDMI binds properly: >> >> [ 4.458954] dwhdmi-imx 120000.hdmi: Detected HDMI TX controller v1.30a with >> HDCP (DWC HDMI 3D TX PHY) >> [ 4.469633] imx-drm display-subsystem: bound 120000.hdmi (ops dw_hdmi_imx_ops) >> >> Which in the end causes the IMX driver to not initialize properly >> and ignore the HDMI connection that bound properly. >> This in turn prevents us from having any graphical output while there >> is no LVDS panel connected. > > Does this happen if the LVDS is disabled in cmdline? (adding "video=LVDS-1:d") I hadn't tried this before, but is seems yo yield the same results # cat /proc/cmdline video=LVDS-1:d enforcing=0 ip=dhcp rw rootwait root=/dev/mmcblk1p1 log_buf_len=16M cma=512M vmalloc=512M # dmesg imx-drm display-subsystem: failed to bind disp0 (ops imx_pd_ops): -517 imx-drm display-subsystem: master bind failed: -517 This dmesg log is failing to bind disp0 at another point than what I was seeing before, yet the result is the same. The connected HDMI output is not brought online correctly. > > Note that a bootscript was written for mainline kernel that takes care > of display configuration [1]. > > Currently this bootscript disables all the displays that aren't used. > It was tested with HDMI, where LVDS and LCD display are disabled, and > it *used to* work. > > If this doesn't work then there's most likely a regression somewhere. > > Regards, > Gary > > [1] https://github.com/boundarydevices/u-boot-imx6/blob/boundary-v2018.07/board/boundary/bootscripts/bootscript-mainline.txt#L90 > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel