linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "Zidenberg, Tsahi" <tsahee@amazon.com>
To: Robin Murphy <robin.murphy@arm.com>,
	"will@kernel.org" <will@kernel.org>,
	 "mark.rutland@arm.com" <mark.rutland@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"patrik.berglund@arm.com" <patrik.berglund@arm.com>,
	"tuanphan@os.amperecomputing.com"
	<tuanphan@os.amperecomputing.com>,
	"harb@amperecomputing.com" <harb@amperecomputing.com>,
	"james.yang@arm.com" <james.yang@arm.com>,
	"Saidi, Ali" <alisaidi@amazon.com>
Subject: Re: [PATCH v2 0/3] Arm CMN-600 PMU driver
Date: Mon, 5 Oct 2020 09:16:13 +0000	[thread overview]
Message-ID: <55205AE5-EBBD-47F3-AA22-3B2A370CCF22@amazon.com> (raw)
In-Reply-To: <cover.1600357241.git.robin.murphy@arm.com>



On 18/09/2020, 16:29, "Robin Murphy" <robin.murphy@arm.com> wrote:
    > Here's an update with some very minor cleanup tweaks, plus a proposal
    > for some more in-depth debug information. Given that nobody seems to
    > have any significant complaints about the interface, I assume we're all
    > happy to merge the basic driver as-is and fix anything later if needed.
    >
    > Robin.

Agree with merging the driver as-is.
Tested both the updated driver and the debugfs on Graviton2 (ACPI). 
Both map and initial numbers seem right.

Tested-by: Tsahi Zidenberg <tsahee@amazon.com>

May I offer a small addition to the documentation?
Something along these lines:

--- a/Documentation/admin-guide/perf/arm-cmn.rst
+++ b/Documentation/admin-guide/perf/arm-cmn.rst
@@ -41,8 +41,14 @@ specified by "occupid".
 
 By default each event provides an aggregate count over all nodes of the
 given type. To target a specific node, "bynodeid" must be set to 1 and
-"nodeid" to the appropriate value derived from the CMN configuration
-(as defined in the "Node ID Mapping" section of the TRM).
+"nodeid" to the appropriate value derived from the CMN configuration.
+
+The CMN map is available in /sys/kernel/debug/arm-cmn/map.
+A nodeid could be calculated with this formulae:
+  node-id = d | (p << 2) | (y << 3) | (x << (3 + xybits))
+where:
+  x,y,p,d are node location as can be seen in the map
+  xybits is 2 for meshes <= 2*2, and 3 otherwise.
 
 Watchpoints
 -----------

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-10-05  9:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 13:28 [PATCH v2 0/3] Arm CMN-600 PMU driver Robin Murphy
2020-09-18 13:28 ` [PATCH v2 1/3] perf: Add Arm CMN-600 DT binding Robin Murphy
2020-09-18 17:31   ` Rob Herring
2020-09-18 13:28 ` [PATCH v2 2/3] perf: Add Arm CMN-600 PMU driver Robin Murphy
2020-09-18 13:28 ` [RFC 3/3] perf/arm-cmn: Add debugfs topology info Robin Murphy
2020-09-18 18:24 ` [PATCH v2.1 1/3] perf: Add Arm CMN-600 DT binding Robin Murphy
2020-09-18 18:54   ` Rob Herring
2020-09-19  0:23     ` Robin Murphy
2020-10-05  9:16 ` Zidenberg, Tsahi [this message]
2020-10-05 10:21   ` [PATCH v2 0/3] Arm CMN-600 PMU driver Will Deacon
2020-10-14 16:31     ` Robin Murphy
2020-10-15  7:26       ` Zidenberg, Tsahi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55205AE5-EBBD-47F3-AA22-3B2A370CCF22@amazon.com \
    --to=tsahee@amazon.com \
    --cc=alisaidi@amazon.com \
    --cc=devicetree@vger.kernel.org \
    --cc=harb@amperecomputing.com \
    --cc=james.yang@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=patrik.berglund@arm.com \
    --cc=robin.murphy@arm.com \
    --cc=tuanphan@os.amperecomputing.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).