From: jh80.chung@samsung.com (Jaehoon Chung)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] mmc: dw_mmc: dt-binding: Add tuning related things
Date: Wed, 02 Sep 2015 14:01:52 +0900 [thread overview]
Message-ID: <55E682C0.6050204@samsung.com> (raw)
In-Reply-To: <1441045446-30858-6-git-send-email-heiko@sntech.de>
Hi, Heiko.
On 09/01/2015 03:24 AM, Heiko Stuebner wrote:
> From: Alexandru M Stan <amstan@chromium.org>
>
> Add ciu_drv, ciu_sample clocks and default-sample-phase. This will later
> be used by tuning code.
As i know, ciu_drv and ciu_sample clocks are generated with "ciu" clock.
But in these patch-set, ciu_drv and ciu_sample are controlled by clock framework.
It's a little strange.
Are there ciu_drv and ciu_sample clock on Rockchip?
Best Regards,
Jaehoon Chung
>
> We do not touch ciu_drive (and by extension define default-drive-phase).
> Drive phase is mostly used to define minimum hold times, while one could
> write some code to determine what phase meets the minimum hold time
> (ex 10 degrees) this will not work with the current clock phase framework
> (which floors angles, so we'll get 0 deg, and there's no way to know what
> resolution the floors happen at). We assume that the default drive angles
> set by the hardware are good enough.
>
> Signed-off-by: Alexandru M Stan <amstan@chromium.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt
> index 346c609..5edadc2 100644
> --- a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt
> +++ b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt
> @@ -42,11 +42,13 @@ Optional properties:
> * clocks: from common clock binding: handle to biu and ciu clocks for the
> bus interface unit clock and the card interface unit clock.
>
> -* clock-names: from common clock binding: Shall be "biu" and "ciu".
> - If the biu clock is missing we'll simply skip enabling it. If the
> - ciu clock is missing we'll just assume that the clock is running at
> +* clock-names: from common clock binding: Shall be "biu", "ciu", "ciu_drv" and
> + "ciu_sample". If the biu clock is missing we'll simply skip enabling it.
> + If the ciu clock is missing we'll just assume that the clock is running at
> clock-frequency. It is an error to omit both the ciu clock and the
> - clock-frequency.
> + clock-frequency. "ciu_drv" and "ciu_sample" are used to control the clock
> + phases, "ciu_sample" is required for tuning high speed modes (if no other
> + custom tuning method is defined).
>
> * clock-frequency: should be the frequency (in Hz) of the ciu clock. If this
> is specified and the ciu clock is specified then we'll try to set the ciu
> @@ -75,6 +77,10 @@ Optional properties:
> * vmmc-supply: The phandle to the regulator to use for vmmc. If this is
> specified we'll defer probe until we can find this regulator.
>
> +* default-sample-phase: The default phase to set ciu_sample at probing, low
> + speeds or in case where all phases work at tuning time. If not specified
> + 0 deg will be used.
> +
> Aliases:
>
> - All the MSHC controller nodes should be represented in the aliases node using
>
next prev parent reply other threads:[~2015-09-02 5:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 18:23 [PATCH 0/8] mmc: dw_mmc: allow tuning using the clk-phase api Heiko Stuebner
2015-08-31 18:23 ` [PATCH 1/8] clk: rockchip: Allow more precision for some mmc clock phases Heiko Stuebner
2015-08-31 18:24 ` [PATCH 2/8] clk: rockchip: Make calculations use rounding Heiko Stuebner
2015-08-31 18:24 ` [PATCH 3/8] mmc: core: Add mmc_regulator_set_vqmmc() Heiko Stuebner
2015-09-02 11:38 ` Ulf Hansson
2015-09-02 16:20 ` Doug Anderson
2015-09-10 12:40 ` Ulf Hansson
2015-08-31 18:24 ` [PATCH 4/8] mmc: dw_mmc: Use mmc_regulator_set_vqmmc in start_signal_voltage_switch Heiko Stuebner
2015-08-31 18:24 ` [PATCH 5/8] mmc: dw_mmc: dt-binding: Add tuning related things Heiko Stuebner
2015-09-02 5:01 ` Jaehoon Chung [this message]
2015-09-02 7:41 ` Heiko Stuebner
2015-08-31 18:24 ` [PATCH 6/8] mmc: dw_mmc: Generic MMC tuning with the clock phase framework Heiko Stuebner
2015-09-15 8:25 ` Jaehoon Chung
2015-09-15 22:09 ` Heiko Stübner
2015-09-16 2:30 ` Jaehoon Chung
2015-09-16 14:52 ` Heiko Stübner
2015-09-17 2:03 ` Jaehoon Chung
2015-08-31 18:24 ` [PATCH 7/8] ARM: dts: rockchip: Add drive/sample clocks for rk3288 dw_mmc devices Heiko Stuebner
2015-08-31 18:24 ` [PATCH 8/8] ARM: dts: rockchip: add tuning related settings to veyron devices Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E682C0.6050204@samsung.com \
--to=jh80.chung@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).