From: Heiko Stuebner <heiko@sntech.de>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Justin Swartz <justin.swartz@risingedge.co.za>,
mturquette@baylibre.com, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] ARM: dts: rockchip: add display nodes for rk322x
Date: Sat, 15 Jun 2019 01:05:27 +0200 [thread overview]
Message-ID: <5617164.NpQ99z5SQI@phil> (raw)
In-Reply-To: <20190614203610.959DA217F9@mail.kernel.org>
Stephen,
Am Freitag, 14. Juni 2019, 22:36:09 CEST schrieb Stephen Boyd:
> Quoting Heiko Stuebner (2019-06-14 12:33:12)
> > Am Freitag, 14. Juni 2019, 20:32:35 CEST schrieb Justin Swartz:
> > > On 2019-06-14 19:45, Stephen Boyd wrote:
> > > >> diff --git a/arch/arm/boot/dts/rk322x.dtsi
> > > >> b/arch/arm/boot/dts/rk322x.dtsi
> > > >> index da102fff96a2..148f9b5157ea 100644
> > > >> --- a/arch/arm/boot/dts/rk322x.dtsi
> > > >> +++ b/arch/arm/boot/dts/rk322x.dtsi
> > > >> @@ -143,6 +143,11 @@
> > > >> #clock-cells = <0>;
> > > >> };
> > > >>
> > > >> + display_subsystem: display-subsystem {
> > > >> + compatible = "rockchip,display-subsystem";
> > > >> + ports = <&vop_out>;
> > > >> + };
> > > >> +
> > > >
> > > > What is this? It doesn't have a reg property so it looks like a virtual
> > > > device. Why is it in DT?
> > >
> > > This is a virtual device.
> > >
> > > I assumed it would be acceptable to it find in a device tree due to
> > > binding documentation,
> > > "Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt,
> > > which states:
> > >
> > > <quote>
> > > The Rockchip DRM master device is a virtual device needed to list all
> > > vop devices or other display interface nodes that comprise the
> > > graphics subsystem.
> > > </quote>
> > >
> > > Without the "display_subsystem" device node, the HDMI PHY and
> > > rockchipdrmfb frame buffer device are not initialized.
> > >
> > > Perhaps I should have included this in my commit message? :)
> >
> > As Justin said, that is very much common as the root of the components
> > that make up the drm device and pretty much common in a lot of devicetrees
> > for the last 5 years and longer ;-) .
> >
> > Also gpio-keys also don't have a reg property ;-) .
> >
>
> Do you have a SoC node? If so, this virtual device should live in the
> root, away from the nodes that have reg properties and are thus in the
> SoC node.
no we don't have any soc node and that display-subsystem is really the
same on _all_ currently supported Rockchip socs ... has gone through
dt-reviews numerous times for multiple socs, so I'm somewhat
confident that we're not doing something terrible wrong.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-14 23:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 16:54 [PATCH 0/4] hdmi on rk3229 Heiko Stuebner
2019-06-14 16:54 ` [PATCH 1/4] clk: rockchip: add clock id for hdmi_phy special clock Heiko Stuebner
2019-06-14 20:38 ` Justin Swartz
2019-06-14 16:54 ` [PATCH 2/4] clk: rockchip: export HDMIPHY clock Heiko Stuebner
2019-06-14 20:38 ` Justin Swartz
2019-06-14 16:54 ` [PATCH 3/4] ARM: dts: rockchip: add display nodes for rk322x Heiko Stuebner
2019-06-14 17:45 ` Stephen Boyd
2019-06-14 18:32 ` Justin Swartz
2019-06-14 19:33 ` Heiko Stuebner
2019-06-14 20:36 ` Stephen Boyd
2019-06-14 23:05 ` Heiko Stuebner [this message]
2019-06-14 16:54 ` [PATCH 4/4] ARM: dts: rockchip: fix vop iommu-cells on rk322x Heiko Stuebner
2019-06-27 10:40 ` [PATCH 0/4] hdmi on rk3229 Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5617164.NpQ99z5SQI@phil \
--to=heiko@sntech.de \
--cc=justin.swartz@risingedge.co.za \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).