From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8D63C433F5 for ; Sun, 28 Nov 2021 16:16:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2ZNZ1k4r01rPAVdyhzLHlCMI4c3BPT8Qub5nPDu6CpM=; b=C6/XwFVx9Hc6vn M7qh5VKMkE6sHlgUqO5GY8hzbbM0CTJSUuDs2zSPm83XthVHWTdWg7ShkRhgG7LcwY0evhNcOnRi7 7BNnpshegWmj5yW7ypVtYnSl5V0rwNMtXGZ0VNNfDOlYD0Eo6SOpcBSKgEPHxrUOJqikSyB7nT4eb cgGMZl0kQRdSbssV6MAcH4OgvC6ssa8Vy39TtGhTHfrF9Pj0HEWFn9Hmo+0zGUtcRwXVnQ5p5yM6u fa7BMwWoDoAvBYJEsnOzupQPwRhUpg7ZW92c9IEy1Cd1WBZWBL3HUcroWdSONA7d661N7MxqHIPeX UV9nJpxo6U6SDibdwveg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrMox-00G9Vk-Le; Sun, 28 Nov 2021 16:14:31 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrMot-00G9Uy-6p for linux-arm-kernel@lists.infradead.org; Sun, 28 Nov 2021 16:14:28 +0000 Received: by mail-ed1-x52a.google.com with SMTP id z5so61561829edd.3 for ; Sun, 28 Nov 2021 08:14:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=gCyjIL0QmQDMGw6Npf54FjjJ7vMykPnD9qOLabxp0UU=; b=j3CLuspKfS4rIe3FxWvI10fvqZkxQIG87u2io706rNuvQQA1QPBa9MIrAuZEuDVRaT YKDJ6bXeqoLxcSJuxbiFc531aZTNpiY9OlwKnRL2SEt+L5/j0+yJZb75njiGVpUHxIfG 8Ep6yr+Llqu79gkX/Acw5Yvb3Pzr9z6CeoOj9WIr0Za9fKfO+ZQn3Qyw7Ot+0/4a1irP 8DpgDhUu0VkL9/9mAlnDMH/XUwYdj6UO7Lic+JfpafiWSZL1hWLaAVTPY0Et9pkrV8nA HQ5L8PLfajdJbllV/tQ4KnPV9DEwrrZUnJxp/ip/cOjIcw0FpD1P9zqqz/Z0q4+EmELA HHqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gCyjIL0QmQDMGw6Npf54FjjJ7vMykPnD9qOLabxp0UU=; b=FULhUScum6i2bvhyH2Uj7Op1Pvxp+XnnD87Grkq5jXYp4iQi7UxraowDj+eXFcZg5r LsQDgqW30DzvWX11FkBYzqmmqE9RnDkyomx1b9CEbj9+NQq9ajuWJNmS3gRROC9IBuJW wZ44cGc1YQKOtc5S45rcjAs2R90sYuEpWIG7LytMrscO5ftX9iimXKhQEBTkjJkNnOt6 zc1kSLO5hvEbMzCltrg20CiaiGRvBeAB1NTZN4XZOBvA5UERZsAMmmcZAV640auUtodr CklbB0fXxgYC0xSyh6fqKzoxFws7otJYV6A5AgL44bRNqknuOPEhHpV5o2xr/CxyRrxA 3vtw== X-Gm-Message-State: AOAM530MuE6bUAFroQKxGaFHWG6vsKpshtqU+8+8zlWfATXxKUmKI/21 kKbgBXCzuVNG0SaxqSyCoSg= X-Google-Smtp-Source: ABdhPJwhIQaDzN6FmUtw9lBFmsFhZWMTLtM+FEin+Bbk3EyzWs/TIH4oEqwSIthbdRKsCYEPLw5MEw== X-Received: by 2002:a17:907:3e13:: with SMTP id hp19mr24250858ejc.376.1638116064509; Sun, 28 Nov 2021 08:14:24 -0800 (PST) Received: from jernej-laptop.localnet (89-212-178-211.dynamic.t-2.net. [89.212.178.211]) by smtp.gmail.com with ESMTPSA id y15sm7703088edr.35.2021.11.28.08.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 08:14:24 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Philip Rinn Subject: Re: [PATCH v2] arm64: dts: allwinner: a64: olinuxino: Enable audio Date: Sun, 28 Nov 2021 17:14:23 +0100 Message-ID: <5768727.lOV4Wx5bFT@jernej-laptop> In-Reply-To: <19597618-ad48-ca3e-0c4d-78274671d80d@inventati.org> References: <19597618-ad48-ca3e-0c4d-78274671d80d@inventati.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211128_081427_330927_38DAEDD3 X-CRM114-Status: GOOD ( 18.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Philip! Dne nedelja, 28. november 2021 ob 16:19:34 CET je Philip Rinn napisal(a): > Enable the audio hardware on the Olimex A64-OLinuXino board family. > Tested on the A64-OLinuXino-2Ge8G-IND variant. > > Signed-off-by: Philip Rinn > > --- You should put changelog here when you send new version of the patch. > > .../dts/allwinner/sun50i-a64-olinuxino.dts | 51 +++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts > b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts > > index ec7e2c0e82c1..e2f518c5854a 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts > > @@ -32,6 +32,22 @@ hdmi_con_in: endpoint { > > }; > > }; > > > > + hdmi-sound { > > + compatible = "simple-audio-card"; > > + simple-audio-card,format = "i2s"; > > + simple-audio-card,name = "allwinner,hdmi"; > > + simple-audio-card,mclk-fs = <256>; > > + status = "okay"; > > + > > + simple-audio-card,codec { > > + sound-dai = <&hdmi>; > > + }; Drop everything related to hdmi audio. There was quite a few e-mails regarding how to best approach hdmi audio implementation on A64 and other SoCs with DW HDMI core. Agreement is that we should introduce HDMI audio card driver instead of simple audio card. I have this almost implemented, but I didn't find time to polish it. Another thing is that there is nothing board specific about HDMI audio, so nodes should reside in SoC DTSI file anyway. Best regards, Jernej > > + > > + simple-audio-card,cpu { > > + sound-dai = <&i2s2>; > > + }; > > + }; > > + > > leds { > > compatible = "gpio-leds"; > > > > @@ -58,6 +74,15 @@ wifi_pwrseq: wifi_pwrseq { > > }; > > }; > > > > +&codec { > > + status = "okay"; > > +}; > > + > > +&codec_analog { > > + cpvdd-supply = <®_eldo1>; > > + status = "okay"; > > +}; > > + > > &cpu0 { > > cpu-supply = <®_dcdc2>; > > }; > > @@ -74,6 +99,10 @@ &cpu3 { > > cpu-supply = <®_dcdc2>; > > }; > > > > +&dai { > > + status = "okay"; > > +}; > > + > > &de { > > status = "okay"; > > }; > > @@ -97,6 +126,7 @@ &emac { > > }; > > > > &hdmi { > > + #sound-dai-cells = <0>; > > hvcc-supply = <®_dldo1>; > > status = "okay"; > > }; > > @@ -107,6 +137,10 @@ hdmi_out_con: endpoint { > > }; > > }; > > > > +&i2s2 { > > + status = "okay"; > > +}; > > + > > &mdio { > > ext_rgmii_phy: ethernet-phy@1 { > > compatible = "ethernet-phy-ieee802.3-c22"; > > @@ -328,6 +362,23 @@ &simplefb_hdmi { > > vcc-hdmi-supply = <®_dldo1>; > > }; > > > > +&sound { > > + simple-audio-card,aux-devs = <&codec_analog>; > > + simple-audio-card,widgets = "Microphone", "Microphone Jack Left", > > + "Microphone", "Microphone Jack Right", > > + "Headphone", "Headphone Jack"; > > + simple-audio-card,routing = "Left DAC", "DACL", > > + "Right DAC", "DACR", > > + "Headphone Jack", "HP", > > + "ADCL", "Left ADC", > > + "ADCR", "Right ADC", > > + "Microphone Jack Left", "MBIAS", > > + "MIC1", "Microphone Jack Left", > > + "Microphone Jack Left", "HBIAS", > > + "MIC2", "Microphone Jack Right"; > > + status = "okay"; > > +}; > > + > > &uart0 { > > pinctrl-names = "default"; > > pinctrl-0 = <&uart0_pb_pins>; > > -- > > 2.33.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel