From: alim.akhtar@samsung.com (Alim Akhtar)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: dts: exynos: Properly select eMMC HighSpeed mode
Date: Fri, 15 Jul 2016 08:56:53 +0530 [thread overview]
Message-ID: <578857FD.7030601@samsung.com> (raw)
In-Reply-To: <1468500458-7142-1-git-send-email-k.kozlowski@samsung.com>
Hi Krzysztof,
On 07/14/2016 06:17 PM, Krzysztof Kozlowski wrote:
> Exynos5410 supports eMMC version 4.41 so HS200 is the top mode which
> should be configured. This is reflected in usage of
> "samsung,exynos5250-dw-mshc" compatible. However DTS contained also
> property "mmc-hs400-1_8v" which is parsed by MMC core therefore
> resulting in mixed configuration. MMC core set HS400 but dwmmc_exynos
> driver did not configure the data strobe for HS400 DDR mode.
>
> Removal of HS400 properties fixes semi-random mmc errors during boot:
> mmc_host mmc0: Bus speed (slot 0) = 400000000Hz (slot req 200000000Hz, actual 200000000HZ div = 1)
> mmc0: mmc_select_hs400 failed, error -84
> mmc0: error -84 whilst initialising MMC card
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> index d9499310a301..7536164438ca 100644
> --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
> +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> @@ -447,14 +447,12 @@
> samsung,dw-mshc-ciu-div = <3>;
> samsung,dw-mshc-sdr-timing = <0 4>;
> samsung,dw-mshc-ddr-timing = <0 2>;
> - samsung,dw-mshc-hs400-timing = <0 2>;
not sure but can we use /delete-property/ option for this removable?
> samsung,read-strobe-delay = <90>;
this also need to be removed.
> pinctrl-names = "default";
> pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd>;
> bus-width = <8>;
> cap-mmc-highspeed;
> mmc-hs200-1_8v;
> - mmc-hs400-1_8v;
same as above if possible use /delete-property/
> vmmc-supply = <&ldo20_reg>;
> vqmmc-supply = <&ldo11_reg>;
> };
>
next prev parent reply other threads:[~2016-07-15 3:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 12:47 [PATCH] ARM: dts: exynos: Properly select eMMC HighSpeed mode Krzysztof Kozlowski
2016-07-15 3:26 ` Alim Akhtar [this message]
2016-07-15 7:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578857FD.7030601@samsung.com \
--to=alim.akhtar@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).