From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [net-next PATCH 1/3] net: phy: dp83867: Add documentation for optional impedance control
Date: Wed, 20 Jul 2016 10:33:39 -0500 [thread overview]
Message-ID: <578F99D3.9090601@ti.com> (raw)
In-Reply-To: <20160720145614.13132-2-mugunthanvnm@ti.com>
On 07/20/2016 09:56 AM, Mugunthan V N wrote:
> Add documention of ti,impedance-control which can be used to
> correct MAC impedance mismatch using phy extended registers.
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> ---
> Documentation/devicetree/bindings/net/ti,dp83867.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.txt b/Documentation/devicetree/bindings/net/ti,dp83867.txt
> index 5d21141..531ea3c5 100644
> --- a/Documentation/devicetree/bindings/net/ti,dp83867.txt
> +++ b/Documentation/devicetree/bindings/net/ti,dp83867.txt
> @@ -9,6 +9,13 @@ Required properties:
> - ti,fifo-depth - Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h
> for applicable values
>
> +Optional property:
> + - ti,impedance-control - MAC Interface Impedance control to vary the
> + output impedance with an approximate range
> + from 35-70 ohms in 32 steps. Value range can
> + be 0x0 to 0x1f. Lowest impedance value is
> + 0x1f and highest impedance being 0x0.
> +
Should'nt you be using the impedance values of 35 to 70 as the valid
values here? that would be the hardware description, and the values to
program corresponding to those are 0x00 to 0x1f. Right?
Rob: is'nt that the right way to do it?
> Default child nodes are standard Ethernet PHY device
> nodes as described in Documentation/devicetree/bindings/net/phy.txt
>
>
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2016-07-20 15:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 14:56 [net-next PATCH 0/3] add support for impedance control for TI dp83867 phy and fix 2nd ethernet on dra72 rev C evm Mugunthan V N
2016-07-20 14:56 ` [net-next PATCH 1/3] net: phy: dp83867: Add documentation for optional impedance control Mugunthan V N
2016-07-20 15:33 ` Nishanth Menon [this message]
2016-07-21 6:22 ` Sekhar Nori
2016-07-21 21:14 ` Rob Herring
2016-07-22 10:05 ` Mugunthan V N
2016-07-20 14:56 ` [net-next PATCH 2/3] net: phy: dp83867: add support for MAC impedance configuration Mugunthan V N
2016-07-20 14:56 ` [net-next PATCH 3/3] ARM: dts: dra72-evm-revc: fix non-working cpsw second ethernet Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578F99D3.9090601@ti.com \
--to=nm@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).