linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: irq_create_fwspec_mapping() in 4.8-rc2
Date: Fri, 2 Sep 2016 16:31:09 +0100	[thread overview]
Message-ID: <57C99B3D.3010405@arm.com> (raw)
In-Reply-To: <B721D80D-B240-4779-8748-5CFAD330D986@gmail.com>

+Linus, Jean-Christophe, Jon

On 02/09/16 16:15, Andras Szemzo wrote:
> Hi,
> 
>> On 02 Sep 2016, at 17:09, Marc Zyngier <marc.zyngier@arm.com> wrote:
>>
>> So something has already configured the interrupt to be
>> IRQ_TYPE_EDGE_BOTH, and this clashes with your
>> IRQ_TYPE_EDGE_FALLING.
>>
>> My bet is on this one:
>>
>> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
>> index 80daead..9f09041 100644
>> --- a/drivers/pinctrl/pinctrl-at91.c
>> +++ b/drivers/pinctrl/pinctrl-at91.c
>> @@ -1614,7 +1614,7 @@ static int at91_gpio_of_irq_setup(struct platform_device *pdev,
>> 				   &gpio_irqchip,
>> 				   0,
>> 				   handle_edge_irq,
>> -				   IRQ_TYPE_EDGE_BOTH);
>> +				   IRQ_TYPE_NONE);
>> 	if (ret) {
>> 		dev_err(&pdev->dev, "at91_gpio.%d: Couldn't add irqchip to gpiochip.\n",
>> 			at91_gpio->pioc_idx);
>>
>> Can you give it a go and let me know what happens?
> 
> yes, this fixed the problem. Thank you, it was fast!

Right. So the at91 pinctlr seems to enforce a default configuration. The
question is *why*? All interrupts connected to it should provide their
own trigger coming from DT.

As we now actually check that we have some consistency between what is
configured and what is requested, it is bound to fail, unless you happen
to match the default.

What am I missing?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2016-09-02 15:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02  6:51 irq_create_fwspec_mapping() in 4.8-rc2 Andras Szemzo
2016-09-02 14:15 ` Marc Zyngier
2016-09-02 14:29   ` Andras Szemzo
2016-09-02 14:47     ` Marc Zyngier
2016-09-02 14:52       ` Andras Szemzo
2016-09-02 15:09         ` Marc Zyngier
2016-09-02 15:15           ` Andras Szemzo
2016-09-02 15:31             ` Marc Zyngier [this message]
2016-09-05 12:40               ` Linus Walleij
2016-09-05 12:56                 ` Marc Zyngier
2016-09-05 21:41                   ` Linus Walleij
2016-09-06  5:53                     ` Nicolas Ferre
2016-09-05 13:10                 ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57C99B3D.3010405@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).