From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40304C433EF for ; Tue, 30 Nov 2021 11:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pj461YYouiXCOelOQQYCK0/LQm6bbmFvhiYEt03MQiI=; b=2PCp5SSsiZSAwtd0ZsZOp3Asub En6Dhu8zHi6MCsODJ7A8qolR9zNL6rqplI1E2rQxzSYArfIRcROb6NCOVQJ6kJwUyvaAfJbgC8+n3 Ln+HWpXnn9t8OEz/Z5dAE5q+RXEhkZxzKcnuwj0BHwLa0RE9vq8t4ybQkbN0SC/VHYBqH1w2MXo7C rNl554utVJVNR2N7jJJY8ZgutBTvThPvqpNfC9CxFwtFJVQCRy28Z4W2myabRQBZeZnUXqezfVcHQ j09I0hEQHPoaF4HoMFTj1qo9SNOql8+euIrffJgxUieKimife0W5GRf8F9WypdZHT8iS+bl93CCm0 E2ojJO6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms1Nu-004sUD-T5; Tue, 30 Nov 2021 11:33:19 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms1Np-004sT0-0n; Tue, 30 Nov 2021 11:33:15 +0000 Received: from [IPv6:2a00:c281:1409:4a00:f02c:94f7:9527:dda] (unknown [IPv6:2a00:c281:1409:4a00:f02c:94f7:9527:dda]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dafna) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id CAFDD1F410B9; Tue, 30 Nov 2021 11:33:07 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1638271989; bh=kPPICgkzXFPBrIYmZPv1q+nwez55PhApUTcS0F/NeBo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Deq8PqlhTo0QneJhYsfmqFdvxX1pqWMpB6c+zvITaBH3pEHHh5JGO5Sy0evRJAMI9 sXnuDdpZy+Lzle2eErvroT2n1r7myLSrKb7RX9bn/3wyfymXBt7gIo2qzAg+O+tDVl 8g6XEBjqU88FYPMQuzdS3sfsmUhfCo4BqUZJGyKn++t/O7QRj2haWB0dvTk0zDvHR5 dhM/+BpZGzAnzR4gHl12N8WgTJ8MYmgsjcO/NvwBrZ9o1AqMTauccppSbv4A+MOev3 UI6LMYtsBuAdh8dQyjs0dD2AYCZliYOcfnfD4yqIaMlsUpP7BvgHZmZnKEc0Gzymkw zKy8tz0LHsrRA== Subject: Re: [PATCH v3 12/33] iommu/mediatek: Always tlb_flush_all when each PM resume To: Yong Wu Cc: Krzysztof Kozlowski , Tomasz Figa , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, Hsin-Yi Wang , youlin.pei@mediatek.com, anan.sun@mediatek.com, yen-chang.chen@mediatek.com, AngeloGioacchino Del Regno , Fabien Parent , sebastian.reichel@collabora.com, Collabora Kernel ML , Joerg Roedel , Rob Herring , Matthias Brugger , Will Deacon , Robin Murphy , mingyuan.ma@mediatek.com, yf.wang@mediatek.com References: <20210923115840.17813-1-yong.wu@mediatek.com> <20210923115840.17813-13-yong.wu@mediatek.com> <5c4dd67ae7c81721d8cfd2c3b23b7c6df493cb5a.camel@mediatek.com> <4dd4cf8d-0f52-afae-f7d9-8e3cfdf3b729@collabora.com> <128eb1874127b2b9b42a7419e26090d1d192666f.camel@mediatek.com> From: Dafna Hirschfeld Message-ID: <58b13d3a-e89b-d2e3-278d-af8859d901b9@collabora.com> Date: Tue, 30 Nov 2021 13:33:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <128eb1874127b2b9b42a7419e26090d1d192666f.camel@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_033313_492224_44763B7C X-CRM114-Status: GOOD ( 33.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30.11.21 09:39, Yong Wu wrote: > On Sat, 2021-11-27 at 12:11 +0200, Dafna Hirschfeld wrote: >> >> On 10.11.21 09:50, Yong Wu wrote: >>> On Wed, 2021-11-10 at 07:29 +0200, Dafna Hirschfeld wrote: >>>> >>>> On 10.11.21 04:20, Yong Wu wrote: >>>>> On Tue, 2021-11-09 at 14:21 +0200, Dafna Hirschfeld wrote: >>>>>> Hi >>>>>> This patch is needed in order to update the tlb when a device >>>>>> is >>>>>> powered on. >>>>>> Could you send this patch alone without the whole series so >>>>>> it >>>>>> get >>>>>> accepted easier? >>>>> >>>>> Which SoC are you testing on? In previous SoC, the IOMMU HW >>>>> don't >>>>> have >>>>> power-domain, and we have a "has_pm"[1] in the tlb function for >>>>> that >>>>> case. The "has_pm" should be always 0 for the previous SoC like >>>>> mt8173, >>>>> it should always tlb synchronize. >>>>> >>>>> thus, Could you help share more about your issue? In which case >>>>> it >>>>> lack >>>>> the necessary tlb operation. At least, We need confirm if it >>>>> needs >>>>> a >>>>> "Fixes" tags if sending this patch alone. >>>> >>>> Hi, >>>> I work with the mtk-vcodec driver on mt8173. As you wrote, the >>>> iommu >>>> doesn't >>>> have a power-domain and so when allocating buffers before the >>>> device >>>> is powered >>>> on, there is the warning >>>> "Partial TLB flush timed out, falling back to full flush" >>>> flooding the log buf. >>> >>> oh. Thanks very much for your information. Get it now. >>> >>> This issue should be introduced by the: >>> >>> b34ea31fe013 ("iommu/mediatek: Always enable the clk on resume") >> >> Hi, reverting this commit didn't solve those warnings, >> I think this is because in the function mtk_iommu_attach_device >> the first call to pm_runtime_resume_and_get does not turn the clks on >> since m4u_dom is not yet initialize. And then mtk_iommu_attach_device >> calls pm_runtime_put right after mtk_iommu_hw_init is called >> (where the clks are turned on) > > oh. Right. this is also related with the patch of "Add power-domain > operation". > > The current problem is that there is a redundant log of "Partial TLB > flush timed out" in mt8173. We need fix this issue firstly. Are you > going to prepare the patches again? If not, I could help this. You > could help confirm them if you are free. Hi, I already sent a patch last week: https://lore.kernel.org/linux-iommu/afb46ad6ca9477a2bf71233858406caa6ccb1588.camel@mediatek.com/T/ could you please review it? Thanks, Dafna > > Thanks. > >> >> thanks, >> Dafna >> >> >>> >>> tlb failed due to the bclk is not enabled. Could you help try that >>> after reverting this? >>> >>>> >>>> Sebastian Reichel suggested to remove the 'if(has_pm)' check to >>>> avoid >>>> this warning, >>>> and avoid flushing the tlb if the device is off: >>>> >>>> [1] http://ix.io/3Eyr >>>> >>>> This fixes the warning, but then the tlb is not flushed in sync, >>>> Therefore the tlb should be flushed when the device is resumed. >>>> >>>> So the two patches (the one suggested in the link [1] and this >>>> patch) >>>> should be sent together as a 2-patch series. >>> >>> then this is reasonable. You could help this into a new patchset if >>> you >>> are free(add Fixes tag). >>> >>> Thanks. >>> >>>> >>>> Thanks, >>>> Dafna >>>> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel