From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 448E8C4727C for ; Tue, 29 Sep 2020 17:23:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDB522075A for ; Tue, 29 Sep 2020 17:23:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QcmNu8HA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bgj1j3bR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDB522075A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:Subject: From:References:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4zUr3cvlupaw/KrMr51JzthG0SRd+f44Tt2Z4M8GqJU=; b=QcmNu8HAwaEW1U7hQLD7JM3OE GoGueWALLiWreiQnXaij7MQcdHo1wI2xlNLDNT/VW2nRUs0V05TsYdFUmQMzJQ9LspxJ9uTw014/k NX657CKW9kCOrgZAA6BYq6HqimstOCPDobAA3GbGeX6HUGqoPT976iSokn1XgRmPlTsc/56lJCegY tkjXytdLXb8p7DHaVVrhdEMMwoOYYmec5d/U1SI98+7L5Uox6fHJtDhrKgBJzHSLyTl3GG8FqTrul niagfl74RAgrMuoSwToqwvAujyRV70MR7D/wpMNpswFEYRuBaRxRq5WdEoK6yUikwgGUS6TnRZzfM 8vNwuyR/g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNJJz-00010f-Ut; Tue, 29 Sep 2020 17:21:47 +0000 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNJJy-000101-44 for linux-arm-kernel@lists.infradead.org; Tue, 29 Sep 2020 17:21:46 +0000 Received: by mail-pj1-x1041.google.com with SMTP id jw11so3017118pjb.0 for ; Tue, 29 Sep 2020 10:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:references:from:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rBXbeDo5gD+4FDRb87rnz1r0cdYjyTBeDR6yZRHzpjA=; b=bgj1j3bRNEiqEbiuK/yW29y+gBZ6yvbdniimnTIlRrMffKAzJNHl4amkcbklMk6URG VjO1NmwylBLur92EWZkQs+Cr3WCP6K+gud0W+t7Er8XdZB8exTbnqg5oR+WM6JmH3Xev IGsFj3D+ezFcHFg8Fvlfpl9cwuxtCoX9HfDICm6oCvgLt+sPP0lx1w99KYr58G2e/gYG po5Lj249CkNOdnAFoGvW5HTmVosbX6xZrZj1T5NpPSxKHHma67h5hrIK5AIlH0X4JR2r f0dGSli2hdVXA/2eOFg+MXzhR2soQRjTtqJZxV65r+/UUTQG9a40RLaHtdUJ1z1z43ap Bvsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rBXbeDo5gD+4FDRb87rnz1r0cdYjyTBeDR6yZRHzpjA=; b=fBbp4At2CE7Y1F9lWKAaHWX/36lC6uIpQyCpCyx+obBf4LcKiRiSQx1GY9bHyPNwS7 o7hxrU4f+Nn2s/0Tl15ooLTHJfKuwVHNRuvj+dZxHkD/7uC1jwHtSPI1HOvjI5f0hkhE BfMXYbwZLXUJwYRcd2PWdcObIUdW3SEvRWiGbOnYVv4hzrQTC/vVPuLCa9NJDvqADmLh FGsKNykALQ8y/xpTVa3TNglZT4XJFw+YfXES+n3b3Rzu4gk2VBzPyjghrIBEIEa6YUv/ dMKWlttGNVenTDyvhL7UBFtFkFkEfUnb48+rYEKwsJLW6FnDZxBaYcrVNNag9RPJzKp8 ngqw== X-Gm-Message-State: AOAM531eOsTpgpdkPpMXH1Z3egRC9cD//0VklyUIn7r5jdLb11Bmfmaz bmppnyYOZYWlZVgwBnSGXUY= X-Google-Smtp-Source: ABdhPJxP7ZtWQ+aXZc6S4B7bquKFc5F0dcrNfqzg+2SsauyJJQVVmv2K+rKi8KsnckmxMbgqOp355g== X-Received: by 2002:a17:90a:9307:: with SMTP id p7mr5006822pjo.47.1601400102662; Tue, 29 Sep 2020 10:21:42 -0700 (PDT) Received: from [10.230.29.112] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 206sm5383477pgh.26.2020.09.29.10.21.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Sep 2020 10:21:41 -0700 (PDT) To: Matija Glavinic Pecotic , linux-arm-kernel@lists.infradead.org, Rob Herring , Russell King References: From: Florian Fainelli Subject: Re: [PATCH] arm: Support initrd with address in boot alias region Message-ID: <58e39504-3970-597f-8146-5180babc6e16@gmail.com> Date: Tue, 29 Sep 2020 10:21:35 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200929_132146_177609_635513D5 X-CRM114-Status: GOOD ( 12.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Sverdlin, Alexander \(Nokia - DE/Ulm\)" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org +Rob, Russell, On 9/29/2020 12:54 AM, Matija Glavinic Pecotic wrote: > If bootloader passes address of initrd in boot alias region, initrd > will fail on memblock_is_region_memory as memblock with such address > doesn't exist. > > Issue was observed with kexec which passed initrd address in boot alias > region, while bootloader will typically pass physical address. Commit > fe7db7570379 ("of/fdt: Populate phys_initrd_start/phys_initrd_size from FDT") > uncovered problem by removing virt_to_phys on the initrd physical > address. __virt_to_phys on our platform coincidentally fixed address. > > Fix by trying to correct address in case of invalid physical address. > > Signed-off-by: Matija Glavinic Pecotic This should have a Fixes tag: fe7db7570379 ("of/fdt: Populate phys_initrd_start/phys_initrd_size from FDT") I am not familiar enough with how the identity map works, but it seems to do what you want it to. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel