From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91206C433ED for ; Tue, 18 May 2021 21:41:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 587826124C for ; Tue, 18 May 2021 21:41:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 587826124C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lucaceresoli.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8qm65gYqu7y5LICGH0yny5+zF/QZ8GjHcA2PzD7C6f0=; b=lSOmRbvajrrvA2Vts5GlfcgIR IFCYuHsp2RoVlG1OyU8CAKAzVGZfS4os+cqetxHxndObmCf8ySTgdwd8bTvlFmhaaqRAUyaxs1LR8 r9MCpkcSdij1WGXGZD8th8iVmk/Zrbp99esDPeSMx/1Yz+P33Uo00SSdYnLWekySIt56PSZztvD9/ /7XNuq961aF0J4MO5gP6U49t5L+qDmet0AxoKwizcEU9Ui8iZzCo9SO2tMI+aFs7XQ6KGB2GPNyNC RpCS2C0LaV8ilDLJDGKcMmVtCwzl5zw1LyJ2DBlb393pZErcERMhahFPlw9akr6WnAyFPKRcgREBU 2DnFnh3dQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lj7Qo-001xTK-S4; Tue, 18 May 2021 21:39:15 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lj7Qk-001xSq-AI for linux-arm-kernel@desiato.infradead.org; Tue, 18 May 2021 21:39:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=Wm9VNVii7ufYlsgw67Vtnuzvn0ReAeNtb77IHjQaYb0=; b=lpPj44/B+QaJcj5tdbWT2HyWLJ 0yN/Bppcn3bcfgG1WSnlpZjHx1w84RBa3c46nVP5wpqTJuBQjtiopE1bbX3QXuVhD+JpowsACCk2U QHKQnyPC0cTEghFLzBAp2V7aVYF3/BZANIQ3cHBDnMaHCZEevEZkdtEmYs6lfdSsLYBwWSBOi8QOo cPn7iQ3cRaIUdaHWe5hqtMREiuboJRZjS150LoH1Po+Mx0R9Pd+i4jaMqklaCUEzqAR6OTDpY6Ke6 OW8cICelBOgtU6LxKu12VmDs1/RdEZW3RVNsfd5+TXo1zyXzhtoAfhasx9QX8VD69GaOiayEz0jJw ljAfV+oQ==; Received: from hostingweb31-40.netsons.net ([89.40.174.40]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lj7Qh-00Eyui-AK for linux-arm-kernel@lists.infradead.org; Tue, 18 May 2021 21:39:08 +0000 Received: from [77.244.183.192] (port=63068 helo=[192.168.178.41]) by hostingweb31.netsons.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1lj7Qd-00080V-Du; Tue, 18 May 2021 23:39:03 +0200 Subject: Re: [PATCH 2/5] PCI: dwc: pci-dra7xx: make it a kernel module To: Rob Herring Cc: PCI , linux-omap , linux-arm-kernel , "linux-kernel@vger.kernel.org" , Kishon Vijay Abraham I , Lorenzo Pieralisi , Bjorn Helgaas , Jingoo Han , Gustavo Pimentel References: <20210517154122.430544-1-luca@lucaceresoli.net> <20210517154122.430544-3-luca@lucaceresoli.net> From: Luca Ceresoli Message-ID: <593829a9-b560-2a87-3f56-48a791201f39@lucaceresoli.net> Date: Tue, 18 May 2021 23:39:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca@lucaceresoli.net X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_143907_552851_0EE17B02 X-CRM114-Status: GOOD ( 13.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On 18/05/21 20:55, Rob Herring wrote: > On Mon, May 17, 2021 at 10:41 AM Luca Ceresoli wrote: >> >> This allows to build the driver as a loadable kernel module. > > Enable building the driver as a loadable kernel module. > >> >> Signed-off-by: Luca Ceresoli >> --- >> drivers/pci/controller/dwc/pci-dra7xx.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c >> index 6457695df00c..fe11b96fe9a5 100644 >> --- a/drivers/pci/controller/dwc/pci-dra7xx.c >> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c >> @@ -15,6 +15,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -949,4 +950,8 @@ static struct platform_driver dra7xx_pcie_driver = { >> }, >> .shutdown = dra7xx_pcie_shutdown, >> }; >> -builtin_platform_driver(dra7xx_pcie_driver); >> +module_platform_driver(dra7xx_pcie_driver); > > You need MODULE_DEVICE_TABLE() too for autoloading. Good catch! Will be fixed in v2. Thanks. -- Luca _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel