From: Alexander Stein <alexander.stein@mailbox.org>
To: Rob Herring <robh+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 1/1] arm64: dts: meson: g12b: odroid-n2: Add I2C RTC device node
Date: Tue, 02 Feb 2021 20:16:35 +0100 [thread overview]
Message-ID: <5974424.6LiauEnjn7@kongar> (raw)
In-Reply-To: <c63a4da5-b598-2484-24bf-d7b4697e28e1@baylibre.com>
Hi,
On Tuesday, February 2, 2021, 6:29:48 PM CET Neil Armstrong wrote:
> Hi,
>
> On 02/02/2021 18:08, Alexander Stein wrote:
> > This is taken from the downstream kernel and works out of the box.
>
> Please keep authorship of the downstream commit.
Sure, will do.
> > +&i2c3 {
> > + status = "okay";
> > + pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>;
> > + pinctrl-names = "default";
> > +
> > + rtc: rtc@51 {
> > + compatible = "nxp,pcf8563";
> > + reg = <0x51>;
>
> Interrupt line is missing, Anand added:
> +» » /*·RTC·INT·*/
> +» » interrupts·=·<GPIOAO_7·IRQ_TYPE_LEVEL_LOW>;
> +» » interrupt-parent·=·<&gpio_intc>;
>
> > + wakeup-source;
> > + };
> > +};
Eh, where did you get that? I'm talking about this commit https://github.com/
hardkernel/linux/commit/b2e22de15e55bb070a2fd45150a6d3e0179ed0e6
There is no interrupt line, although I understand it's missing.
Best regards,
Alexander
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-02 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 17:08 [PATCH 1/1] arm64: dts: meson: g12b: odroid-n2: Add I2C RTC device node Alexander Stein
2021-02-02 17:29 ` Neil Armstrong
2021-02-02 19:16 ` Alexander Stein [this message]
2021-02-02 23:10 ` Alexander Stein
2021-02-03 16:47 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5974424.6LiauEnjn7@kongar \
--to=alexander.stein@mailbox.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).