From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65827C43461 for ; Wed, 16 Sep 2020 01:44:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE19C2076C for ; Wed, 16 Sep 2020 01:44:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YF0W6FPz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE19C2076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vffrlGaoTlE+VZ8UZ93nVzWjE0v6FfHDjeZtBZdbAIk=; b=YF0W6FPzx05wlD+aLJLiE0Jtw xUvofqhe6wETGpCZsrJOYycIciuDjiHc6zNbjm4Gzg6h0wf6JV28vDFSrpVz8df7L2B58MpbYFIAl ujVCjqRYi7EZlX07VUdCXfoTFHWqa2BMfHCH4ktr8IcNcnk0Tno3+m5Gy6zRmYxD7Yp55ysuraAdG +TpNJiiunr+2jhVmLh5Oeu+GODedhg3iU4E2NAk7ZVTKeXQyMKMTXbVotEWW1/IMdIbkh4YswR1Fs pkZ2Jj1lSo1vYFhBsVdR87Uod/EvaIiDsOYsHrceZV4T8x5FblKCCyW0ZlAxh/d8cWcN0ag1A42cf kMdSttsJg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIMTH-0005cq-In; Wed, 16 Sep 2020 01:42:55 +0000 Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIMTF-0005bH-24 for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 01:42:53 +0000 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id EFEAF68F0E45DF751A7D; Wed, 16 Sep 2020 09:42:45 +0800 (CST) Received: from [10.57.101.250] (10.57.101.250) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Wed, 16 Sep 2020 09:42:42 +0800 Subject: Re: [PATCH v3 6/6] ARM: dts: hisilicon: Fix SP805 clocks List-Id: To: Andre Przywara , References: <20200907121831.242281-1-andre.przywara@arm.com> <20200907121831.242281-7-andre.przywara@arm.com> From: Wei Xu Message-ID: <5F616D92.3070201@hisilicon.com> Date: Wed, 16 Sep 2020 09:42:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20200907121831.242281-7-andre.przywara@arm.com> X-Originating-IP: [10.57.101.250] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200915_214253_343952_4F9079B2 X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Chanho Min , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020/9/7 20:18, Andre Przywara wrote: > The SP805 DT binding requires two clocks to be specified, but > Hisilicon platform DTs currently only specify one clock. > > In practice, Linux would pick a clock named "apb_pclk" for the bus > clock, and the Linux and U-Boot SP805 driver would use the first clock > to derive the actual watchdog counter frequency. > > Since currently both are the very same clock, we can just double the > clock reference, and add the correct clock-names, to match the binding. > > Signed-off-by: Andre Przywara Thanks! Applied to the hisilicon arm32 dt tree. Best Regards, Wei > --- > arch/arm/boot/dts/hisi-x5hd2.dtsi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi > index 3ee7967c202d..e2dbf1d8a67b 100644 > --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi > +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi > @@ -370,8 +370,9 @@ > arm,primecell-periphid = <0x00141805>; > reg = <0xa2c000 0x1000>; > interrupts = <0 29 4>; > - clocks = <&clock HIX5HD2_WDG0_RST>; > - clock-names = "apb_pclk"; > + clocks = <&clock HIX5HD2_WDG0_RST>, > + <&clock HIX5HD2_WDG0_RST>; > + clock-names = "wdog_clk", "apb_pclk"; > }; > }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel