From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=BUG6152_INVALID_DATE_TZ_ABSURD,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID, INVALID_DATE_TZ_ABSURD,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95242CA9ED3 for ; Mon, 4 Nov 2019 17:00:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6154C214B2 for ; Mon, 4 Nov 2019 17:00:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="drV91oqM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6154C214B2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:From:Date: MIME-Version:Subject:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZK/gxlLK8M6lrtcz0oB3VLwAfpCr+tyW3lrSXdLEL5E=; b=drV91oqMAMvy8Kkm4tRHWOS8C tyLoXMqe2fHIyZF2bIwEWBjz/vYpv1pEYrCMWydZP57HxRRnAzyLAswcrEnrer84YX3xoVoQES3uQ PGE/x23FkdkS2dGRzvSbt6bM8/fuT73mfEqw6v9glXhgArkwHyBE3kdPyKkuCbO8xHldIepPE/t2/ zgLOotZ+zF71IfEH6rMT5k339naoVHDDJWBpQejVXmPiC3vFI1o6KHgUjVbtBkm+xP1fMygyhFlYi ck6PdK6LT2KYvm1spYm5tModjjVxi084p+HUqaw0HRFGKOOKZDO1z3P9pu2H9TSNs2+vu1PuFtijt aAbHc9czg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRfi4-0002MM-JM; Mon, 04 Nov 2019 17:00:08 +0000 Received: from inca-roads.misterjones.org ([213.251.177.50]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRfi1-0001iq-JA for linux-arm-kernel@lists.infradead.org; Mon, 04 Nov 2019 17:00:07 +0000 Received: from www-data by cheepnis.misterjones.org with local (Exim 4.80) (envelope-from ) id 1iRfhR-0008Lz-89; Mon, 04 Nov 2019 17:59:29 +0100 To: Sami Tolvanen Subject: Re: [PATCH v4 06/17] scs: add accounting X-PHP-Originating-Script: 0:main.inc MIME-Version: 1.0 Date: Mon, 04 Nov 2019 18:08:50 +0109 From: Marc Zyngier In-Reply-To: References: <20191018161033.261971-1-samitolvanen@google.com> <20191101221150.116536-1-samitolvanen@google.com> <20191101221150.116536-7-samitolvanen@google.com> <791fc70f7bcaf13a89abaee9aae52dfe@www.loen.fr> Message-ID: <5aaee4e0339daef7deadf29db9ea1747@www.loen.fr> X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/0.7.2 X-SA-Exim-Connect-IP: X-SA-Exim-Rcpt-To: samitolvanen@google.com, will@kernel.org, catalin.marinas@arm.com, rostedt@goodmis.org, mhiramat@kernel.org, ard.biesheuvel@linaro.org, dave.martin@arm.com, keescook@chromium.org, labbott@redhat.com, mark.rutland@arm.com, ndesaulniers@google.com, jannh@google.com, miguel.ojeda.sandonis@gmail.com, yamada.masahiro@socionext.com, clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191104_090005_795948_3D4CCE07 X-CRM114-Status: UNSURE ( 8.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , LKML , Steven Rostedt , Miguel Ojeda , Masami Hiramatsu , clang-built-linux , Kernel Hardening , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2019-11-04 17:52, Sami Tolvanen wrote: > On Mon, Nov 4, 2019 at 5:13 AM Marc Zyngier wrote: >> Is there any reason why you're not consistently using only one of >> "#if IS_ENABLED(...)" or "#ifdef ...", but instead a mix of both? > > This is to match the style already used in each file. For example, > fs/proc/meminfo.c uses #ifdef for other configs in the same function, > and include/linux/mmzone.h uses #if IS_ENABLED(...). Ah, fair enough. M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel