From: Marek Vasut <marex@denx.de>
To: Shawn Guo <shawnguo@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Christoph Niedermaier <cniedermaier@dh-electronics.com>,
Fabio Estevam <festevam@gmail.com>,
Ludwig Zenz <lzenz@dh-electronics.com>,
NXP Linux Team <linux-imx@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] ARM: dts: imx6q-dhcom: Add PU,VDD1P1,VDD2P5 regulators
Date: Thu, 4 Mar 2021 13:07:32 +0100 [thread overview]
Message-ID: <5ae1374f-fd10-523f-7b6f-fa7fb40eba20@denx.de> (raw)
In-Reply-To: <20210304075652.GN15865@dragon>
On 3/4/21 8:56 AM, Shawn Guo wrote:
> On Wed, Mar 03, 2021 at 03:04:07PM +0100, Marek Vasut wrote:
>> On 3/3/21 1:56 PM, Shawn Guo wrote:
>>> On Thu, Feb 04, 2021 at 12:54:03AM +0100, Marek Vasut wrote:
>>>> Per schematic, both PU and SOC regulator are supplied from LTC3676 SW1
>>>> via VDDSOC_IN rail, add the PU input. Both VDD1P1, VDD2P5 are supplied
>>>> from LTC3676 SW2 via VDDHIGH_IN rail, add both inputs.
>>>>
>>>> Fixes: 52c7a088badd ("ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2")
>>>
>>> It's more like an improvement or additions rather than fixes. I dropped
>>> the tag and applied for -next.
>>
>> I would argue that describing SoC regulators correctly is a bugfix, since it
>> can lead to stability issues of the SoC.
>
> Then resend the patch with details of the issue that it fixes.
Can you please tell me what is missing in the original patch description
that justifies dropping the Fixes: tag ? I would argue that fully
describing CPU regulators in DT is a fix which should go through the
stable tree and the original patch description is accurate.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-04 12:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 23:54 [PATCH] ARM: dts: imx6q-dhcom: Add PU,VDD1P1,VDD2P5 regulators Marek Vasut
2021-03-03 12:56 ` Shawn Guo
2021-03-03 14:04 ` Marek Vasut
2021-03-04 7:56 ` Shawn Guo
2021-03-04 12:07 ` Marek Vasut [this message]
2021-03-05 8:39 ` Shawn Guo
2021-03-05 11:19 ` Marek Vasut
2021-03-06 11:07 ` Shawn Guo
2021-03-06 11:21 ` Shawn Guo
2021-03-06 16:17 ` Marek Vasut
2021-03-07 1:40 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ae1374f-fd10-523f-7b6f-fa7fb40eba20@denx.de \
--to=marex@denx.de \
--cc=arnd@arndb.de \
--cc=cniedermaier@dh-electronics.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=lzenz@dh-electronics.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).