From: Randy Dunlap <rdunlap@infradead.org>
To: Jiping Ma <jiping.ma2@windriver.com>,
peppe.cavallaro@st.com, alexandre.torgue@st.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] stmmac: debugfs entry name is not be changed when udev rename device name.
Date: Mon, 30 Dec 2019 18:11:24 -0800 [thread overview]
Message-ID: <5b10a5ff-8428-48c7-a60d-69dd62009716@infradead.org> (raw)
In-Reply-To: <20191231020302.71792-1-jiping.ma2@windriver.com>
Hi,
On 12/30/19 6:03 PM, Jiping Ma wrote:
> Add one notifier for udev changes net device name.
>
> Signed-off-by: Jiping Ma <jiping.ma2@windriver.com>
> ---
> .../net/ethernet/stmicro/stmmac/stmmac_main.c | 38 ++++++++++++++++++-
> 1 file changed, 37 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index b14f46a57154..c1c877bb4421 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -4038,6 +4038,40 @@ static int stmmac_dma_cap_show(struct seq_file *seq, void *v)
> }
> DEFINE_SHOW_ATTRIBUTE(stmmac_dma_cap);
>
> +/**
Just use /* here since this is not a kernel-doc comment.
/** is reserved for kernel-doc comments/notation.
> + * Use network device events to create/remove/rename
> + * debugfs file entries
> + */
> +static int stmmac_device_event(struct notifier_block *unused,
> + unsigned long event, void *ptr)
> +{
> @@ -4050,7 +4084,6 @@ static int stmmac_init_fs(struct net_device *dev)
>
> return -ENOMEM;
> }
> -
> /* Entry to report DMA RX/TX rings */
> priv->dbgfs_rings_status =
> debugfs_create_file("descriptors_status", 0444,
I don't see a problem with the blank line. Why remove it?
thanks.
--
~Randy
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next parent reply other threads:[~2019-12-31 2:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191231020302.71792-1-jiping.ma2@windriver.com>
2019-12-31 2:11 ` Randy Dunlap [this message]
[not found] ` <719d8dd3-0119-0c93-b299-d2b3d66b1e06@windriver.com>
2019-12-31 2:22 ` [PATCH] stmmac: debugfs entry name is not be changed when udev rename device name Randy Dunlap
2019-12-31 10:12 ` Sergei Shtylyov
[not found] <20200102013544.19271-1-jiping.ma2@windriver.com>
2020-01-05 4:18 ` David Miller
[not found] <20200106023341.206459-1-jiping.ma2@windriver.com>
2020-01-06 21:45 ` David Miller
[not found] ` <15aedd71-e077-4c6c-e30c-9396d16eaeec@windriver.com>
2020-01-07 2:22 ` David Miller
[not found] ` <99d183bc-7668-7749-54d6-3649c549dec8@windriver.com>
2020-01-07 4:44 ` Florian Fainelli
2020-01-07 21:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b10a5ff-8428-48c7-a60d-69dd62009716@infradead.org \
--to=rdunlap@infradead.org \
--cc=alexandre.torgue@st.com \
--cc=jiping.ma2@windriver.com \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).