From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0EA5C433F5 for ; Thu, 26 May 2022 12:09:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gqyexiZr/R520T+3E4kTZjAJHsZOTMHXj50L66dM2d0=; b=AeS/FV6UT6Rrfg xZDiJcuO0GxqhAAkVWE036VtpuAWYNHw3Oamnhlnp12DQiXq+vtdc53S15dkfI05Ta0CH5k8zZ5RH 5K3c/miUZV3KMgWq9i8fdLyP7MuNE1qs71/tW6EQJZ2kOAaCT44tRHDJXzjdtBRIcFkoeosMPfhAi ROHVH7Cw+fqWjLZieYWU7jxyieMvQojfEAW/emzEfhjCVSpkJS+KbAra4+mPLCQ79J26RH1hsuFgS iQnvvzqMmd58oj/HnUQty89IPWWF0OXQ8cJk11t2c9erHuy0xPHZ+JneBGtynPa9SBu14IumcuUOg fpR+1/eXbemZocL8rjrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuCHr-00ElAK-8q; Thu, 26 May 2022 12:08:19 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuCHo-00El9Y-3A for linux-arm-kernel@lists.infradead.org; Thu, 26 May 2022 12:08:18 +0000 Received: by mail-ej1-x62b.google.com with SMTP id n10so2644940ejk.5 for ; Thu, 26 May 2022 05:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=djaXZvKnQ48OkK/XXFXcCAtGydBecmNA8ztZBz8O8C0=; b=B7bKYNL3NKxnfWA7VWZz4UmFeTe3x68RQORyEnkm/BdZCx1XebjX31Yk8CZDkah/g0 P+U8liuUMu7jPILg21Z/KX5VeWh6PP/XPz3p/CWY8ljnS05J3jUBZxGPmyFDWwlCSbCa b4I39CLOBG+KfGHNrWVlML2KZJU6MCgtk5r7P3zylVJJm2LrVC++uHBDugBB2ZHPDJYr AecB7iWy/c7y8wKrhSm2pUm4xIdUt3hy/mAFbdHs0Zr3WOFCix2OFMqNIMsPF9DP4qrw XUn+DHwVanhrLQMoUAqIkeFrWjRcdYf/Bs4+slPsV27akWBdHW9uMfllZ4QqjBb6u0/K h9iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=djaXZvKnQ48OkK/XXFXcCAtGydBecmNA8ztZBz8O8C0=; b=F4B7/F/fxrwPuXEuAh4MnzElJj9bMtdtBZuJQFFycQdv7OCzg6Uul2kLjIozH8/Do3 +QCMIKeTDB2329VtMUeNRLHUAGw4stjj4iSq/7mfxGCNvQyA49FHyrnAGB6jtvjSbDjN hO65Z8x1BVwrKIYsqXPogZhxdm9JUKHruyIAgOwKg/6hAhgByDA4NUwXPj+DNzrNLxW5 8fRrrz/9OixIfDyoMPlCsP9mxaMCkPFaofyqGk6LLIeYzLSmFrgzynSy15EUVazlHP53 YRrB8kAqXJDqa0hvVql0FfT8Z/uO+qjGKcTW3LvSj3fUYmiOg7VBC3PmN5j0agIQ41fH At3Q== X-Gm-Message-State: AOAM531momE0ndHjUwKjtb8PP97hC+gauIZu1w7APYIYrMiLNHKD35Br bQk4oPaLs6ljwh5jjkzZ3hcwmw== X-Google-Smtp-Source: ABdhPJzBiozFQoOEfgdUuTji2WDG3/g4GQcDomYSSDDDagDRvXyQOsy/n250JZCuXQ+xqdY0jps9og== X-Received: by 2002:a17:907:8a03:b0:6fe:c10d:4bf8 with SMTP id sc3-20020a1709078a0300b006fec10d4bf8mr23014549ejc.308.1653566894204; Thu, 26 May 2022 05:08:14 -0700 (PDT) Received: from [192.168.0.177] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id s16-20020a056402521000b0042bd6630a14sm745106edd.87.2022.05.26.05.08.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 May 2022 05:08:13 -0700 (PDT) Message-ID: <5bcbf7d3-daa8-6f00-6743-3d0328a82980@linaro.org> Date: Thu, 26 May 2022 14:08:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/7] dt-bindings: soc: add bindings for i.MX93 SRC Content-Language: en-US To: Peng Fan , "Peng Fan (OSS)" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "sboyd@kernel.org" , "mturquette@baylibre.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" Cc: Aisheng Dong , "l.stach@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" References: <20220523113029.842753-1-peng.fan@oss.nxp.com> <20220523113029.842753-2-peng.fan@oss.nxp.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220526_050816_185111_E11248D6 X-CRM114-Status: GOOD ( 17.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/05/2022 14:07, Peng Fan wrote: >> Subject: Re: [PATCH 1/7] dt-bindings: soc: add bindings for i.MX93 SRC >> >> On 24/05/2022 12:37, Peng Fan wrote: >>>> Subject: Re: [PATCH 1/7] dt-bindings: soc: add bindings for i.MX93 >>>> SRC >>>> >>>> On 23/05/2022 13:30, Peng Fan (OSS) wrote: >>>>> From: Peng Fan >>>>> >>>>> Add bindings for i.MX93 System Reset Controller(SRC). SRC supports >>>>> resets and power gating for mixes. >>>>> >>>>> Signed-off-by: Peng Fan >>>>> --- >>>>> .../bindings/soc/imx/fsl,imx93-src.yaml | 88 >>>> +++++++++++++++++++ >>>>> include/dt-bindings/power/imx93-power.h | 11 +++ >>>>> 2 files changed, 99 insertions(+) >>>>> create mode 100644 >>>>> Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml >>>> >>>> File should be in respective subsystem, so probably power/reset? >>> >>> ok, will put under power. >>> >>>> >>>>> create mode 100644 include/dt-bindings/power/imx93-power.h >>>>> >>>>> diff --git >>>>> a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml >>>>> b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml >>>>> new file mode 100644 >>>>> index 000000000000..d45c1458b9c1 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml >>>>> @@ -0,0 +1,88 @@ >>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 >>>>> +--- >>>>> +$id: >>>>> +> > +title: NXP i.MX9 System Reset Controller >>>>> + >>>>> +maintainers: >>>>> + - Peng Fan >>>>> + >>>>> +description: | >>>>> + The System Reset Controller (SRC) is responsible for the >>>>> +generation of >>>>> + all the system reset signals and boot argument latching. >>>>> + >>>>> + Its main functions are as follows, >>>>> + - Deals with all global system reset sources from other modules, >>>>> + and generates global system reset. >>>>> + - Responsible for power gating of MIXs (Slices) and their memory >>>>> + low power control. >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + items: >>>>> + - const: fsl,imx93-src >>>>> + - const: syscon >>>>> + >>>>> + reg: >>>>> + maxItems: 1 >>>>> + >>>>> + slice: >>>> >>>> Why do you need this subnode, instead of listing domains here? >>> >>> I follow >>> Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml >>> >>> There are several slices in SRC, just like there are many pgcs in gpcv2. >> >> Wait, but you have only one slice and you do no allow more of them. > > Slice is just a group node that could include many child nodes, > such as > slice { > mediamix { > }; > mlmix { > }; > } > > The same >> as for gpcv2 - there is only one pgc. What's the point of that node? > > There are many pgcs, pgc is just a group node there, > See arch/arm64/boot/dts/freescale/imx8mp.dtsi. So this does not explain my question at all. Why do you need "slice" (or pgc) node? You have only one slice in this device, so this is some indirect layer without meaning... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel